Do not call ResendWalletTransactions when reindexing or importing #2259

1. 
   rdponticelli commented at 11:51 AM on February 1, 2013: contributor

   Calling ResendWalletTransactions when reindexing or importing spams other nodes with our old transactions, because they become unconfirmed.

2. 
   sipa commented at 11:52 AM on February 1, 2013: member

   ACK

3. 
   BitcoinPullTester commented at 2:51 PM on February 5, 2013: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/55a05fb8d268d9faa5aca48f7d1a10f2afd636da for binaries and test log.

4. 
   gavinandresen commented at 3:14 PM on February 5, 2013: contributor

   ACK. There will be a lot of reindexing with 0.8, so I'm inclined to pull this sooner.

5. 
   gmaxwell commented at 4:43 PM on February 5, 2013: contributor

   Agreed on the 0.8 reindexing— However, I suggest this also be guarded by IsInitialBlockDownload (I actually thought we were already doing that) so that we minimize spamming the content of an old wallet while syncing up a node from the network (a very common 0.8 install pattern, I expect).

6. Do not call ResendWalletTransactions when reindexing, importing or on IBD

   Calling ResendWalletTransactions when reindexing, importing or on IBD spams
   other nodes with our old transactions, because they become unconfirmed.

   e90b831e83
7. 
   rdponticelli commented at 9:48 PM on February 5, 2013: contributor

   Added @gmaxwell suggestion, and a comment on the source.

8. 
   sipa commented at 3:28 PM on February 6, 2013: member

   ACK; before 0.8

9. 
   Diapolo commented at 4:57 PM on February 6, 2013: none

   Is that logical && correct?

10. 
    gavinandresen commented at 5:17 PM on February 6, 2013: contributor

    Yes, it is logical and correct. Pulling.

11. gavinandresen referenced this in commit 43ba1a19b8 on Feb 6, 2013
12. gavinandresen merged this on Feb 6, 2013
13. gavinandresen closed this on Feb 6, 2013

    ---

14. rdponticelli deleted the branch on Feb 6, 2013
15. laudney referenced this in commit 431ba2f2bb on Mar 19, 2014
16. DrahtBot locked this on Sep 8, 2021

Milestone
0.8.0