Improve grammar #22599

pull ShadySuperCoder wants to merge 1 commits into bitcoin:master from ShadySuperCoder:patch-1 changing 1 files +3 −3
  1. ShadySuperCoder commented at 11:06 PM on August 1, 2021: none

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. GUI-related pull requests should be opened against https://github.com/bitcoin-core/gui first. See CONTRIBUTING.md -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

    Improved grammar -- no code changes.

  2. Improve grammar abf4176ad4
  3. in doc/dnsseed-policy.md:23 in abf4176ad4 
      19 | @@ -20,14 +20,14 @@ functioning Bitcoin nodes from the public network to the best of the
  20 |  operator's understanding and capability.
  21 |  
  22 |  2. For the avoidance of doubt, the results may be randomized but must not
  23 | -single-out any group of hosts to receive different results unless due to an
  24 | +single-out any group of hosts to receive different results, unless due to an
    Zero-1729 commented at 12:37 AM on August 2, 2021:

    Not sure about this punctuation here.

  4. Zero-1729 commented at 12:37 AM on August 2, 2021: contributor

    Light code review and concept ACK.

    Consider renaming your commit and the PR title to maybe docs: minor grammar fixes to dnsseed-policy.md, or something more specific and in accordance with the Contributing docs.

    Note: I recommend going through the contributing docs.

  5. DrahtBot added the label Docs on Aug 2, 2021
  6. fanquake commented at 2:10 AM on August 2, 2021: member

    ShadySuperCoder

    no code changes.

    Thanks. However if you're looking to start contributing, I'd suggest looking at the good first issue list. As mentioned, please also read our contributing docs. If you are going to open PRs like this, at least accompany them with a proper commit message.

  7. fanquake closed this on Aug 2, 2021
  8. MarcoFalke commented at 6:32 AM on August 2, 2021: member

    Some more pointers:

    Getting started to contribute to Bitcoin Core

    Setting up your development environment

    New developers are very welcome and needed. There are a lot of open issues of any difficulty waiting to be fixed. However, before you start contributing, familiarize yourself with the Bitcoin Core build system and tests. Refer to the documentation in the repository on how to build Bitcoin Core and how to run the unit and functional tests. Once that is done, you are all set.

    If you need more help getting started, please refer to the following resources:

    Pick something to work on

    If you are looking for useful contributions to help out with, you can

    • Search through the good first issues or the ones that are up for grabs. Some of them might no longer be applicable. So if you are interested, but unsure, you might want to leave a comment on the issue first.
    • Write tests to improve the coverage. Any kind of test is welcome and coverage information can be obtained from a relatively recent coverage report. If you are unsure, don't hesitate to check back first.
    • Help with review and testing. There are easy ones such as the gui and rpc. However, review on any open pull request is welcome. Review will also help you understand the codebase better.
    • Help on meta projects related to Bitcoin Core, such as a high-level performance monitor.
    • Join us on irc and let us know what you are interested in.
  9. fanquake locked this on Aug 9, 2021
Contributors
ShadySuperCoderZero-1729fanquakeMarcoFalke
Labels
Docs
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 18:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me