[22.0] build: Version info ignores a tag #22623

1. 
   hebasto commented at 12:35 pm on August 4, 2021: member

   When building against a tagged commit (e.g., https://github.com/bitcoin/bitcoin/releases/tag/v22.0rc2) the version info should pull a tag rather a git commit hash.

   Compare:

    0$ bin/bitcoind -version
    1Bitcoin Core version v0.21.0rc2
    2Copyright (C) 2009-2020 The Bitcoin Core developers
    3
    4Please contribute if you find Bitcoin Core useful. Visit
    5<https://bitcoincore.org/> for further information about the software.
    6The source code is available from <https://github.com/bitcoin/bitcoin>.
    7
    8This is experimental software.
    9Distributed under the MIT software license, see the accompanying file COPYING
   10or <https://opensource.org/licenses/MIT>
   

   and

   0$ bin/bitcoind -version
   1Bitcoin Core version v22.0.0-g873fbc745d037ad43570f81e58334c397bc95477
   

2. hebasto added the label Bug on Aug 4, 2021
3. hebasto added the label Build system on Aug 4, 2021
4. 
   MarcoFalke commented at 2:31 pm on August 4, 2021: member

   Is this a bug? I assumed it was a desired change, but I might be mistaken.
5. 
   hebasto commented at 2:34 pm on August 4, 2021: member

   I assumed it was a desired change, but I might be mistaken.

   Maybe it’s my mistake? Did I miss a discussion of that change?

6. 
   hebasto commented at 3:09 pm on August 4, 2021: member

   The reason of such behavior is https://github.com/bitcoin/bitcoin/blob/873fbc745d037ad43570f81e58334c397bc95477/share/genbuild.sh#L23 where git rev-parse --is-inside-work-tree does not return true.
7. 
   hebasto commented at 3:09 pm on August 4, 2021: member

   cc @dongcarl
8. 
   hebasto commented at 10:15 pm on August 5, 2021: member

   Fixed in #22625.
9. 
   achow101 commented at 1:55 am on August 11, 2021: member

   I have an alternative solution in #22680
10. 
    dongcarl commented at 11:42 pm on August 11, 2021: member

    Fix for the underlying problem in: #22685
11. fanquake referenced this in commit 3facf0a8ae on Aug 16, 2021
12. 
    fanquake commented at 4:22 am on August 16, 2021: member

    Fixed in #22685.
13. fanquake closed this on Aug 16, 2021

    ---

14. sidhujag referenced this in commit f287c95739 on Aug 20, 2021
15. PastaPastaPasta referenced this in commit 8504c5a139 on May 11, 2022
16. kittywhiskers referenced this in commit 754ca58d38 on May 17, 2022
17. DrahtBot locked this on Aug 18, 2022

Contributors
hebasto MarcoFalke achow101 dongcarl fanquake

Labels
Bug Build system