properly deprecate mempool entry RPC fee fields #22682

issue glozow openend this issue on August 11, 2021
  1. glozow commented at 12:51 pm on August 11, 2021: member

    RPCs that return detailed information about mempool entries (e.g. getmempoolentry and getrawmempool(verbose=True) include the fields fee, modifiedfee, descendantfees, and ancestorfees which were marked as “DEPRECATED” and replaced with a fees object field in #12240 (since v0.17).

    We should remove these fields, but first, properly deprecate them using -deprecatedrpc.

    Useful skills:

    • basic understanding of Bitcoin Core RPC interface

    Want to work on this issue?

    For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

  2. glozow added the label RPC/REST/ZMQ on Aug 11, 2021
  3. glozow added the label good first issue on Aug 11, 2021
  4. fanquake commented at 2:23 am on August 12, 2021: member
    Concept ACK. I think we can move ahead with “properly” deprecating these as part of v23.0.
  5. fanquake added this to the milestone 23.0 on Aug 12, 2021
  6. josibake commented at 11:14 am on August 12, 2021: member
    picking this up
  7. fanquake deleted a comment on Aug 14, 2021
  8. fanquake deleted a comment on Aug 16, 2021
  9. fanquake deleted a comment on Aug 16, 2021
  10. MarcoFalke referenced this in commit 4fd0ce75c5 on Dec 7, 2021
  11. MarcoFalke closed this on Dec 7, 2021

  12. DrahtBot locked this on Dec 7, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-05 00:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me