contrib: use keys.openpgp.org to retrieve builder keys #22688

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:use_ubuntu_keyserver changing 3 files +3 −3
  1. fanquake commented at 8:45 am on August 12, 2021: member

    hkps://hkps.pool.sks-keyservers.net is essentially no-longer functional, and a number of distributions and GPG tools have since switched to using the keys.openpgp.org key server as their default.

    See this Debian patch for additional context: https://salsa.debian.org/debian/gnupg2/-/blob/debian/main/debian/patches/Use-hkps-keys.openpgp.org-as-the-default-keyserver.patch

    Switch to using keys.openpgp.org in the CI as well.

  2. fanquake added the label Scripts and tools on Aug 12, 2021
  3. hebasto commented at 8:48 am on August 12, 2021: member

    Concept ACK.

    Does gpg --refresh-keys also require specifying of a key server?

  4. Zero-1729 commented at 10:20 am on August 12, 2021: contributor

    Concept ACK @hebasto I don’t think it should, but maybe as a precaution (just in case there are any revoked keys, new user IDs, sigs, etc. or if facing remote server issues). Just spitballing here though.

    #!/bin/zsh                                                                                                                                      
    
    while read fingerprint keyholder_name
        do gpg --keyserver hkp://subset.pool.sks-keyservers.net --recv-keys ${fingerprint}
    done < ./keys.txt
    

    Also, I tried to run the script above with subset.pool.sks-keyservers.net, and it just returned gpg: keyserver receive failed: No name for all entries in contrib/builder-keys/keys.txt. It only successfully fetched the keys in the file after swapping out the keyserver with keyserver.ubuntu.com:80.

  5. Zero-1729 commented at 10:25 am on August 12, 2021: contributor

    I think SKS is deprecated or something.

    Found a related StackExchange question which referenced the following message from ‘https://sks-keyservers.net/ ‘:

    0This service is deprecated. This means it is no longer maintained, and new HKPS certificates will not be issued. Service reliability should not be expected.
    1
    2Update 2021-06-21: Due to even more GDPR takedown requests, the DNS records for the pool will no longer be provided at all.
    
  6. dongcarl commented at 7:52 pm on August 13, 2021: member

    Just a datapoint: it would seem that since the launch of keys.openpgp.org, many GPG tools and certain distros (Debian, NixOS) have switched over to that as the default server.

    Debian switched in July 2019: https://salsa.debian.org/debian/gnupg2/-/blob/01898735a015541e3ffb43c7245ac1e612f40836/debian/NEWS#L10-29

    Reproduced:

     0  Upstream GnuPG now defaults to not accepting third-party certifications
     1  from the keyserver network.  Given that the SKS keyserver network is
     2  under attack via certificate flooding, and third-party certifications
     3  will not be accepted anyway, we now ship with the more tightly-constrained
     4  and abuse-resistant system hkps://keys.openpgp.org as the default
     5  keyserver.
     6
     7  Users with bandwidth to spare who want to try their luck with the SKS
     8  pool should add the following line to ~/.gnupg/dirmngr.conf to revert to
     9  upstream's default keyserver:
    10
    11      keyserver hkps://hkps.pool.sks-keyservers.net
    12
    13  See the 2.2.17 section in the upstream NEWS file at
    14  /usr/share/doc/gnupg/NEWS.gz for more information about fully
    15  reverting to the old, risky behavior.
    

    Their patch (includes more context): https://salsa.debian.org/debian/gnupg2/-/blob/debian/main/debian/patches/Use-hkps-keys.openpgp.org-as-the-default-keyserver.patch

  7. fanquake force-pushed on Aug 16, 2021
  8. fanquake renamed this:
    contrb: use `keyserver.ubuntu.com` to retrieve builder keys
    contrb: use `keys.openpgp.org` to retrieve builder keys
    on Aug 16, 2021
  9. fanquake commented at 3:33 am on August 16, 2021: member

    Just a datapoint: it would seem that since the launch of keys.opengpg.org, many GPG tools and certain distros (Debian, NixOS) have switched over to that as the default server.

    Looks like keys.opengpg.org also has more of the builder keys available than the Ubuntu server, as well as some newer signatures for keys that are available on either.

    I’ve changed this PR to swap both the README and the CI to use keys.opengpg.org.

  10. in contrib/builder-keys/README.md:23 in b4f1f99823 outdated
    19@@ -20,7 +20,7 @@ To fetch keys of builders and active developers, feed the list of fingerprints
    20 of the primary keys into gpg:
    21 
    22 ```sh
    23-while read fingerprint keyholder_name; do gpg --keyserver hkp://subset.pool.sks-keyservers.net --recv-keys ${fingerprint}; done < ./keys.txt
    24+while read fingerprint keyholder_name; do gpg --keyserver hkps://keys.openpgp.org --recv-keys ${fingerprint}; done < ./keys.txt
    


    MarcoFalke commented at 7:47 am on August 16, 2021:

    Are all builder keys on that keyserver? IIRC only persons with access to the email that the key is attached to can upload there.

    Also the src/minisketch/test file added in this pull seems unrelated.


    MarcoFalke commented at 7:48 am on August 16, 2021:

    Nvm, just read your previous comment:

    Looks like keys.opengpg.org also has more of the builder keys available than the Ubuntu server, as well as some newer signatures for keys that are available on either.

  11. MarcoFalke renamed this:
    contrb: use `keys.openpgp.org` to retrieve builder keys
    contrib: use `keys.openpgp.org` to retrieve builder keys
    on Aug 16, 2021
  12. MarcoFalke commented at 7:49 am on August 16, 2021: member
    Approach ACK b4f1f998236ab1ae44a1a3c8ae84213474cae4dc, but the exe should be removed
  13. fanquake force-pushed on Aug 16, 2021
  14. fanquake commented at 7:52 am on August 16, 2021: member

    but the exe should be removed

    Done. Not sure how I didn’t notice that. Fixed the commit message typo as well.

  15. MarcoFalke commented at 7:52 am on August 16, 2021: member
    cr ACK a3e4ff63e3e5bd5fb46f872c59d3ca74f81c56fa
  16. laanwj commented at 12:33 pm on August 16, 2021: member

    hkps://hkps.pool.sks-keyservers.net is essentially no-longer functional,

    It kind of gives me the feeling that we keep migrating from keyserver to keyserver as they become no-longer functional one by one.

    But sure if it’s needed it’s needed. I don’t see any better solution to this mess, mind you.

  17. laanwj commented at 12:38 pm on August 16, 2021: member
    FWIW, there’s another mention of keyserver in contrib/verify-commits/README.md. Maybe replace this one too?
  18. Zero-1729 commented at 1:20 pm on August 16, 2021: contributor
    Yeah, I think contrib/verify-commits/README.md might as well be updated too. More generally, though, I see moving to keys.openpgp.org as more of an LTS move; I don’t think the keyserver will be down anytime soon.
  19. contrib: use hkps://keys.openpgp.org to retrieve builder keys
    hkps://hkps.pool.sks-keyservers.net is essentially no-longer functional,
    and a number of distributions and GPG tools have since switched to using
    this key server as their default.
    
    See this Debian patch for additional context:
    https://salsa.debian.org/debian/gnupg2/-/blob/debian/main/debian/patches/Use-hkps-keys.openpgp.org-as-the-default-keyserver.patch
    
    Switch to using keys.openpgp.org in the CI as well.
    4c43b7d41d
  20. fanquake force-pushed on Aug 17, 2021
  21. fanquake commented at 1:00 am on August 17, 2021: member

    FWIW, there’s another mention of keyserver in contrib/verify-commits/README.md. Maybe replace this one too?

    Thanks. Have replaced that as well.

  22. fanquake deleted a comment on Aug 17, 2021
  23. MarcoFalke commented at 6:16 am on August 17, 2021: member
    cr ACK 4c43b7d41d11072f382f938379d21cd2e0bcbb47
  24. Zero-1729 commented at 7:59 am on August 17, 2021: contributor
    ACK 4c43b7d41d11072f382f938379d21cd2e0bcbb47
  25. fanquake referenced this in commit fdd80b0a53 on Aug 17, 2021
  26. fanquake commented at 8:07 am on August 17, 2021: member
    This was merged in fdd80b0a53b4af0b29cb6e03118e2456d053a757.
  27. fanquake closed this on Aug 17, 2021

  28. fanquake deleted the branch on Aug 17, 2021
  29. sidhujag referenced this in commit 05bbb0f8ab on Aug 20, 2021
  30. fanquake referenced this in commit 90f1f849e9 on Nov 8, 2021
  31. fanquake referenced this in commit c702d1fefd on Nov 8, 2021
  32. sidhujag referenced this in commit cf315e0d3d on Nov 9, 2021
  33. PastaPastaPasta referenced this in commit 8bcfec2167 on Apr 3, 2022
  34. DrahtBot locked this on Aug 18, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-29 01:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me