build: enable SC2046 and SC2086 in lint-shell #22695

1. 
   Zero-1729 commented at 6:18 am on August 13, 2021: contributor

   Update: Closing this in favour of Hebasto’s replacement PR.

   As per #20879, this PR enables the shellcheck rules SC2046 and SC2086 respectfully in the lint-shell.sh script to, amongst other things, prevent unintentional word-splitting, and make the shell scripts “conformant and therefore more robust”, as dongcarl stated here.

   • Enable SC2046 & SC2086 rules (7f1fc5ef5b3cc5a34ac709db1fe64fdf7665d62a)
   • Fix all SC2046 warnings
   • Fix all SC2086 warnings

   Closes #20879

2. build: enable SC2046 and SC2086 in lint-shell 7f1fc5ef5b
3. 
   fanquake commented at 6:37 am on August 13, 2021: member

   If you want to enable these you actually need to fix all of the warnings / issues in the code. You will see them all in the lint CI output. Or you can run the linter locally.
4. fanquake added the label Scripts and tools on Aug 13, 2021
5. 
   Zero-1729 commented at 6:44 am on August 13, 2021: contributor

   Ran the linter locally, and can see the following count of cases:

   0$ test/lint/lint-shell.sh | grep SC2046 | wc -l
   118
   2
   3$ test/lint/lint-shell.sh | grep SC2086 | wc -l
   4178
   

   Thanks @fanquake for the clarification, I’ll fix all cases and push.

6. Zero-1729 marked this as a draft on Aug 13, 2021
7. 
   jonatack commented at 1:00 pm on August 13, 2021: member

   Concept ACK
8. 
   laanwj commented at 3:34 pm on August 18, 2021: member

   Concept ACK, these seem quite serious.
9. 
   MarcoFalke commented at 5:13 pm on August 18, 2021: member

   This might accidentally fix #12528
10. laanwj added the label Waiting for author on Oct 1, 2021
11. 
    hebasto commented at 7:38 pm on November 7, 2021: member

    This might accidentally fix #12528

    No, it does not fix #12528. Tested on macOS Big Sur 11.6.1 (20G224) + #23462.

12. 
    Zero-1729 commented at 9:40 pm on November 7, 2021: contributor

    Sorry, lost track of this PR. @hebasto thanks for opening a replacement! Closing this now in favour of yours.
13. Zero-1729 closed this on Nov 7, 2021

    ---

14. laanwj referenced this in commit aec631bccc on Nov 15, 2021
15. DrahtBot locked this on Nov 7, 2022

Contributors
Zero-1729 fanquake jonatack laanwj MarcoFalke hebasto

Labels
Scripts and tools Waiting for author