Fix build with Boost 1.77.0 #22713

1. 
   sizeofvoid commented at 4:38 am on August 16, 2021: contributor

   BOOST_FILESYSTEM_C_STR changed to accept the path as an argument.
2. 
   sizeofvoid commented at 4:38 am on August 16, 2021: contributor

   This will fix https://github.com/bitcoin/bitcoin/issues/22482
3. 
   fanquake commented at 4:44 am on August 16, 2021: member

   Concept ACK.

   Even though we will hopefully be removing Boost Filesystem in master (#20744), fixing this is still needed, as we’ll have to at least backport the change to 22.x and 0.21, as users building those branches being using newer Boost versions.

4. bob-beck referenced this in commit 965435c36d on Aug 16, 2021
5. bob-beck referenced this in commit 5ce49197de on Aug 16, 2021
6. DrahtBot added the label Wallet on Aug 16, 2021
7. MarcoFalke removed the label Wallet on Aug 16, 2021
8. MarcoFalke added the label Build system on Aug 16, 2021
9. MarcoFalke added the label Needs backport (0.21) on Aug 16, 2021
10. MarcoFalke added the label Needs backport (22.x) on Aug 16, 2021
11. 
    MarcoFalke commented at 8:34 am on August 16, 2021: member

    Looks like boost 1.77 was released with this, so Concept ACK. Didn’t test with that boost version, though.
12. 
    DrahtBot commented at 8:41 am on August 16, 2021: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    No conflicts as of last run.

13. 
    laanwj commented at 2:22 pm on August 16, 2021: member

    Concept ACK, I don’t have that boost version to test with yet. Would be nice to see an independent confirmation that this solves the issue (maybe from @brad0 , the original reporter) before merging.
14. 
    brad0 commented at 11:54 pm on August 16, 2021: none

    Concept ACK, I don’t have that boost version to test with yet. Would be nice to see an independent confirmation that this solves the issue (maybe from @brad0 , the original reporter) before merging.

    Yes, it is building fine now.

15. in src/fs.cpp:246 in 5825876a23 outdated

    241@@ -242,7 +242,11 @@ void ofstream::close()
    242 }
    243 #else // __GLIBCXX__
    244 
    245+#if BOOST_VERSION >= 107700
    246+static_assert(sizeof(BOOST_FILESYSTEM_C_STR(*fs::path())) == sizeof(wchar_t),
    

    ---

    ---

    

    laanwj commented at 12:24 pm on August 18, 2021:

    Wouldn’t

    0static_assert(sizeof(*BOOST_FILESYSTEM_C_STR(fs::path())) == sizeof(wchar_t),
    

    communicate the intent here better?

    ---

    

    hebasto commented at 9:46 am on August 20, 2021:

    Agree.

    The member access operator has higher precedence than the indirection operator.

    ---

    

    sizeofvoid commented at 8:04 am on August 24, 2021:

    Agree!
16. 
    hebasto commented at 7:58 am on August 20, 2021: member

    Concept ACK.
17. 
    hebasto commented at 9:48 am on August 20, 2021: member

    Tested 5825876a2339be72f205cc850cb3b28dbb10c412 using boost 1.77 from depends. @laanwj’s comment should be addressed before merging.
18. 
    hebasto commented at 7:20 am on August 24, 2021: member

    @sizeofvoid

    Could you address this comment to get this PR ready?

19. sizeofvoid force-pushed on Aug 24, 2021
20. 
    hebasto commented at 8:19 am on August 24, 2021: member

    @sizeofvoid

    Sorry, but it looks like you changed the wrong line in your recent push. No need to change the old static_assert. Only the new one should be fixed.

21. sizeofvoid force-pushed on Aug 24, 2021
22. 
    sizeofvoid commented at 8:50 am on August 24, 2021: contributor

    @sizeofvoid

    Sorry, but it looks like you changed the wrong line in your recent push. No need to change the old static_assert. Only the new one should be fixed.

    Ops, sorry. Fixed!

23. 
    hebasto commented at 9:05 am on August 24, 2021: member

    ACK acb7aad27ec8a184808aa7905887e3b2c5d54e9c
24. Fix build with Boost 1.77.0

    BOOST_FILESYSTEM_C_STR changed to accept the path as an argument

    acb7aad27e
25. benthecarman approved
26. 
    benthecarman commented at 4:59 pm on August 25, 2021: contributor

    ACK acb7aad27ec8a184808aa7905887e3b2c5d54e9c
27. fanquake approved
28. 
    fanquake commented at 8:16 am on August 26, 2021: member

    ACK acb7aad27ec8a184808aa7905887e3b2c5d54e9c - tested the fix with Boost 1.77.0 and 1.71.0.
29. fanquake merged this on Aug 26, 2021
30. fanquake closed this on Aug 26, 2021

    ---

31. hebasto referenced this in commit 32e1424f84 on Aug 26, 2021
32. 
    hebasto commented at 11:52 am on August 26, 2021: member

    Backported to 22.x in #22629.
33. hebasto removed the label Needs backport (22.x) on Aug 26, 2021
34. laanwj referenced this in commit 4a25e39624 on Aug 26, 2021
35. hebasto referenced this in commit f5180d2317 on Aug 26, 2021
36. 
    hebasto commented at 5:37 pm on August 26, 2021: member

    Backported to 0.21 in #22808.
37. hebasto removed the label Needs backport (0.21) on Aug 26, 2021
38. hebasto referenced this in commit d9b18c1290 on Aug 27, 2021
39. fujicoin referenced this in commit f8c21deb34 on Aug 27, 2021
40. fanquake referenced this in commit 6ebb9d0e46 on Aug 28, 2021
41. sidhujag referenced this in commit 81e8b88185 on Aug 28, 2021
42. Fabcien referenced this in commit 868322caea on Jan 6, 2022
43. pkvk referenced this in commit cf85109bfc on Feb 9, 2022
44. PastaPastaPasta referenced this in commit 92230c754b on Mar 13, 2022
45. gwillen referenced this in commit 18cee94832 on Jul 27, 2022
46. gwillen referenced this in commit 45898781ec on Aug 1, 2022
47. apoelstra referenced this in commit e295862057 on Aug 14, 2022
48. PiRK referenced this in commit c12bafcfed on Aug 16, 2022
49. schancel referenced this in commit 0c207a7270 on Aug 17, 2022
50. DrahtBot locked this on Aug 26, 2022

Contributors
sizeofvoid fanquake MarcoFalke DrahtBot laanwj brad0 hebasto benthecarman

Labels
Build system