test: add aarch64-apple-darwin platform entry to get_previous_releases #22790

Over the course of reviewing a PR, I had to edit test/get_previous_releases.py (after I ran git clean -xdff) to run the backwards compatibility tests (e.g. wallet_upgradewallet, feature_backwards_compatibility, etc.), as currently on master, running the script as indicated in test/README.md, for example, on an M1 machine results in the following error, as the aarch64-apple-darwin* platform entry is presently not recognised:

Output from an M1 machine running macOS v11.5.2

$ test/get_previous_releases.py -b v0.20.1 v0.19.1 v0.18.1 v0.17.2 v0.16.3 v0.15.2
Releases directory: releases
Not sure which binary to download for aarch64-apple-darwin20.6.0

As a quick fix, this PR adds the missing aarch64-apple-darwin* platform entry. Running the script now results in fetching the old binaries, as expected:

$ test/get_previous_releases.py -b v0.20.1 v0.19.1 v0.18.1 v0.17.2 v0.16.3 v0.15.2

Releases directory: releases
Fetching: https://bitcoincore.org/bin/bitcoin-core-0.20.1/bitcoin-0.20.1-osx64.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0 20.9M    0     0    0     0      0      0 --:--:--  0:00:02 --:--:--     0
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 20.9M  100 20.9M    0     0   136k      0  0:02:37  0:02:37 --:--:-- 95607
Checksum matched

…

Checksum matched

After this patch, the backwards compatibility tests also run successfully, as expected.

Note: I am open to other possible solutions.

Steps to reproduce:

Ensure you take out the binaries in releases if they already exist.

Try running test/get_previous_releases.py -b v0.15.2 or similar to fetch the old release binaries.

cc @hebasto @jarolrod @fanquake

Would love feedback from other M1 users as well.

So these are run via emulation?

So these are run via emulation?

I haven't tried running it via emulation, I ran it locally on my machine.

You're downloading x86-64 binaries, not AArch64 binaries. That only makes sense if they actually work.

You're downloading x86-64 binaries, not AArch64 binaries. That only makes sense if they actually work.

Yes, I am aware running the script fetches the old x86-64 osx binaries. The good thing is these old binaries work on the machine (thanks to rosetta 2 translation). Hence, adding the 'aarch64' platform to fetch these old binaries is an easy solution for Apple Silicon machines to run those binaries and the functional tests that require them.

Works as expected.

arm64

The good thing is these old binaries work on the machine (thanks to rosetta 2 translation).

Great, that's what I was asking :)