GetMyExternalIP() and the hard-coded stuff in it #2280

issue Diapolo opened this issue on February 6, 2013

Diapolo commented at 5:36 PM on February 6, 2013: none

checkip.dyndns.org - resolves to 91.198.22.70, 216.146.38.70 and 216.146.39.70 (we only have 91.198.22.70 hard-coded)

74.208.43.192 - can't be resolved, timeout when I try to open it with my browser www.showmyip.com - resolves to 2a01:608:ffff:2872::10 and 212.117.175.194, timeout when I try to open it with my browser

Just mentioning it, perhaps we can remove / update / rework that.

https://github.com/bitcoin/bitcoin/blob/master/src/net.cpp#L351
hughdavenport commented at 2:11 AM on July 22, 2013: none

Having quick look at code looks like it will still resolve the other ips if the hard coded ip fails.

Also, if someone is thinking of cleaning this up a bit, i've already made a external ip checker (in perl), which uses a few services. See https://github.com/hughdavenport/dynamic-ip-checker/blob/master/checkip.pl#L11-L26
gmaxwell commented at 2:15 AM on July 22, 2013: contributor

We shouldn't be using any of these services at all (because it allows them to track bitcoin users, at least ones who haven't -discover=0 or -listen=0). UPNP covers this for cases where upnp supported, and we have apparent addresses in our own protocol which we could use...
laanwj commented at 10:13 AM on October 21, 2013: member

It's come to the point that it is currently breaking, See #3088 for the solution.
Diapolo commented at 1:02 PM on December 9, 2014: none

As this was removed from our codebase (Thx @gmaxwell), I'll close this!
Diapolo closed this on Dec 9, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels