build: Add ability to build qt in depends with -stdlib=libc++

hebasto commented at 0:51 am on August 27, 2021: member

This PR makes possible to build the qt package in depends against libc++ for x86_64 platform.

Required for #22815.

Also this PR fixes the [no wallet] [bionic] task on CI:

on master (a8bbd4cc819633ec50ed0f763b6a75330ae055fb), https://api.cirrus-ci.com/v1/task/5558609250615296/logs/ci.log:

0Options used to compile and link:
1  external signer = yes
2  multiprocess    = no
3  with libs       = yes
4  with wallet     = no
5  with gui / qt   = no

this PR, https://api.cirrus-ci.com/v1/task/5502605561430016/logs/ci.log:

0Options used to compile and link:
1  external signer = yes
2  multiprocess    = no
3  with libs       = yes
4  with wallet     = no
5  with gui / qt   = yes

hebasto commented at 0:52 am on August 27, 2021: member

cc @fanquake @MarcoFalke @jarolrod

fanquake added the label Build system on Aug 27, 2021

MarcoFalke added the label DrahtBot Guix build requested on Aug 27, 2021

hebasto commented at 9:34 am on August 27, 2021: member

Guix builds:

 0$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 1db06398ab9b1be8f1d28c19c2a07fb60ca5ca499136258e5de9388af2ac795cb  guix-build-7ae424b899cf/output/aarch64-linux-gnu/SHA256SUMS.part
 2f700183e5fcb96e9cea08089e657dc5ed9c23dab92a7cf7952a2c7db654f1883  guix-build-7ae424b899cf/output/aarch64-linux-gnu/bitcoin-7ae424b899cf-aarch64-linux-gnu-debug.tar.gz
 3ffd040f434d84f5c1a46eda650f65ade7ccac0f5719a789ade4aace267c10dc4  guix-build-7ae424b899cf/output/aarch64-linux-gnu/bitcoin-7ae424b899cf-aarch64-linux-gnu.tar.gz
 4a2fe9a28b19aef232c55fcd35312b0f9d6790a25e9d5a872abc28b5cd324e323  guix-build-7ae424b899cf/output/arm-linux-gnueabihf/SHA256SUMS.part
 579746b31031f5950190a472f9a91583d9ff4403cd856677269bcc138b3576029  guix-build-7ae424b899cf/output/arm-linux-gnueabihf/bitcoin-7ae424b899cf-arm-linux-gnueabihf-debug.tar.gz
 62615275085c93cd089f1f500ce4253f75d4c58bf24981b53b1c85206a634ec6e  guix-build-7ae424b899cf/output/arm-linux-gnueabihf/bitcoin-7ae424b899cf-arm-linux-gnueabihf.tar.gz
 70ad134b4125aa88d782c7f3a80759215653198ff05a237244bc596eeb3634c1c  guix-build-7ae424b899cf/output/dist-archive/bitcoin-7ae424b899cf.tar.gz
 84e9ddbb7cc2ac67d1cbf79664c33ba8d3b9f87cc6c1eac5249b6210c15130c2f  guix-build-7ae424b899cf/output/powerpc64-linux-gnu/SHA256SUMS.part
 95b4c2beb03ad62db8de988816b5a510153bc2fdece83c030d1b31a84aa5d909e  guix-build-7ae424b899cf/output/powerpc64-linux-gnu/bitcoin-7ae424b899cf-powerpc64-linux-gnu-debug.tar.gz
104a7f5af8c45e169e19cd0c11bc16a348d88101199406b62541e6592a72b5081c  guix-build-7ae424b899cf/output/powerpc64-linux-gnu/bitcoin-7ae424b899cf-powerpc64-linux-gnu.tar.gz
11e502aac9fda9c243ba6d9811f39b4c05e63be3f26ceffe8258baa82a1392aa48  guix-build-7ae424b899cf/output/powerpc64le-linux-gnu/SHA256SUMS.part
12031dc8a8013be209535bfd2ebaf08bfdedb8144f8112471eb4f2bcb52dea4f85  guix-build-7ae424b899cf/output/powerpc64le-linux-gnu/bitcoin-7ae424b899cf-powerpc64le-linux-gnu-debug.tar.gz
13198a468ef0ef8a123fedb5fe71687111eebfaf9b7802683b0f95b986d417d38f  guix-build-7ae424b899cf/output/powerpc64le-linux-gnu/bitcoin-7ae424b899cf-powerpc64le-linux-gnu.tar.gz
14ed7bfa400f02db88b8be10c48b1dd711bd39917daba0a59a431b18074c1b2d37  guix-build-7ae424b899cf/output/riscv64-linux-gnu/SHA256SUMS.part
15edf5c552492e0795a78dd4f7f053f0d57ad2fcae80db9e654da7c5a79c941c42  guix-build-7ae424b899cf/output/riscv64-linux-gnu/bitcoin-7ae424b899cf-riscv64-linux-gnu-debug.tar.gz
16883bb26954b56bfe31c952bdd8b40541110f53a2181d719b321c49da01738e53  guix-build-7ae424b899cf/output/riscv64-linux-gnu/bitcoin-7ae424b899cf-riscv64-linux-gnu.tar.gz
179b01fc0dffcdde81ca4f87197652b6d499b9482ea7d87a496e71bf2bc9fdb470  guix-build-7ae424b899cf/output/x86_64-apple-darwin18/SHA256SUMS.part
18c10750e2271074ea735d5b908f5ec206dfbf6d4fbe64bca0ae31caa8ae5e942d  guix-build-7ae424b899cf/output/x86_64-apple-darwin18/bitcoin-7ae424b899cf-osx-unsigned.dmg
199bb167d2f957baa1b1150823ba7064be6ff47459dfe1aa3821aa4e1a23775840  guix-build-7ae424b899cf/output/x86_64-apple-darwin18/bitcoin-7ae424b899cf-osx-unsigned.tar.gz
202ed89ce2ddfdbee3240c3653c074955ea1a800fb6a386c34edfbca6394dd1754  guix-build-7ae424b899cf/output/x86_64-apple-darwin18/bitcoin-7ae424b899cf-osx64.tar.gz
21668afc33cbf9791933a92727f360d7d553a5de36d12162af2a9a25c256847fc7  guix-build-7ae424b899cf/output/x86_64-linux-gnu/SHA256SUMS.part
220f913f662f5d16d499bd60177221b8ab02c2ca3fff28b56a28da9c7a20480f91  guix-build-7ae424b899cf/output/x86_64-linux-gnu/bitcoin-7ae424b899cf-x86_64-linux-gnu-debug.tar.gz
23cc1a1a1bcb621b20bb982fa2b8b79a8f94358c34d8dd7d474ecbfff9db72ff14  guix-build-7ae424b899cf/output/x86_64-linux-gnu/bitcoin-7ae424b899cf-x86_64-linux-gnu.tar.gz
2457a4a6e420c4f8721e4981a306c0f94f2ca6578f362c9fb7e5a4d4378027d43c  guix-build-7ae424b899cf/output/x86_64-w64-mingw32/SHA256SUMS.part
25120c7df398b70556bff009afb9e3a96780ba6b46d59f7af98b0e3140f8ff1089  guix-build-7ae424b899cf/output/x86_64-w64-mingw32/bitcoin-7ae424b899cf-win-unsigned.tar.gz
263f24b0301b20de690516cfe734a84c83e05bea64c31d767770e239466da06586  guix-build-7ae424b899cf/output/x86_64-w64-mingw32/bitcoin-7ae424b899cf-win64-debug.zip
275eb6564689adac44c63c800586db0740515786a244ba506658f988ec5711f759  guix-build-7ae424b899cf/output/x86_64-w64-mingw32/bitcoin-7ae424b899cf-win64-setup-unsigned.exe
284ac3c715e8977fcfd6b9ae50a54f3b8080e6bb69367960e05f53551c716ec965  guix-build-7ae424b899cf/output/x86_64-w64-mingw32/bitcoin-7ae424b899cf-win64.zip

hebasto commented at 8:45 pm on August 27, 2021: member

Also #22815 (review)

DrahtBot removed the label DrahtBot Guix build requested on Aug 29, 2021

jarolrod commented at 4:37 am on August 30, 2021: member

GUIX hashes mine match @hebasto:

 0find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 1
 2db06398ab9b1be8f1d28c19c2a07fb60ca5ca499136258e5de9388af2ac795cb  guix-build-7ae424b899cf/output/aarch64-linux-gnu/SHA256SUMS.part
 3f700183e5fcb96e9cea08089e657dc5ed9c23dab92a7cf7952a2c7db654f1883  guix-build-7ae424b899cf/output/aarch64-linux-gnu/bitcoin-7ae424b899cf-aarch64-linux-gnu-debug.tar.gz
 4ffd040f434d84f5c1a46eda650f65ade7ccac0f5719a789ade4aace267c10dc4  guix-build-7ae424b899cf/output/aarch64-linux-gnu/bitcoin-7ae424b899cf-aarch64-linux-gnu.tar.gz
 5a2fe9a28b19aef232c55fcd35312b0f9d6790a25e9d5a872abc28b5cd324e323  guix-build-7ae424b899cf/output/arm-linux-gnueabihf/SHA256SUMS.part
 679746b31031f5950190a472f9a91583d9ff4403cd856677269bcc138b3576029  guix-build-7ae424b899cf/output/arm-linux-gnueabihf/bitcoin-7ae424b899cf-arm-linux-gnueabihf-debug.tar.gz
 72615275085c93cd089f1f500ce4253f75d4c58bf24981b53b1c85206a634ec6e  guix-build-7ae424b899cf/output/arm-linux-gnueabihf/bitcoin-7ae424b899cf-arm-linux-gnueabihf.tar.gz
 80ad134b4125aa88d782c7f3a80759215653198ff05a237244bc596eeb3634c1c  guix-build-7ae424b899cf/output/dist-archive/bitcoin-7ae424b899cf.tar.gz
 94e9ddbb7cc2ac67d1cbf79664c33ba8d3b9f87cc6c1eac5249b6210c15130c2f  guix-build-7ae424b899cf/output/powerpc64-linux-gnu/SHA256SUMS.part
105b4c2beb03ad62db8de988816b5a510153bc2fdece83c030d1b31a84aa5d909e  guix-build-7ae424b899cf/output/powerpc64-linux-gnu/bitcoin-7ae424b899cf-powerpc64-linux-gnu-debug.tar.gz
114a7f5af8c45e169e19cd0c11bc16a348d88101199406b62541e6592a72b5081c  guix-build-7ae424b899cf/output/powerpc64-linux-gnu/bitcoin-7ae424b899cf-powerpc64-linux-gnu.tar.gz
12e502aac9fda9c243ba6d9811f39b4c05e63be3f26ceffe8258baa82a1392aa48  guix-build-7ae424b899cf/output/powerpc64le-linux-gnu/SHA256SUMS.part
13031dc8a8013be209535bfd2ebaf08bfdedb8144f8112471eb4f2bcb52dea4f85  guix-build-7ae424b899cf/output/powerpc64le-linux-gnu/bitcoin-7ae424b899cf-powerpc64le-linux-gnu-debug.tar.gz
14198a468ef0ef8a123fedb5fe71687111eebfaf9b7802683b0f95b986d417d38f  guix-build-7ae424b899cf/output/powerpc64le-linux-gnu/bitcoin-7ae424b899cf-powerpc64le-linux-gnu.tar.gz
15ed7bfa400f02db88b8be10c48b1dd711bd39917daba0a59a431b18074c1b2d37  guix-build-7ae424b899cf/output/riscv64-linux-gnu/SHA256SUMS.part
16edf5c552492e0795a78dd4f7f053f0d57ad2fcae80db9e654da7c5a79c941c42  guix-build-7ae424b899cf/output/riscv64-linux-gnu/bitcoin-7ae424b899cf-riscv64-linux-gnu-debug.tar.gz
17883bb26954b56bfe31c952bdd8b40541110f53a2181d719b321c49da01738e53  guix-build-7ae424b899cf/output/riscv64-linux-gnu/bitcoin-7ae424b899cf-riscv64-linux-gnu.tar.gz
189b01fc0dffcdde81ca4f87197652b6d499b9482ea7d87a496e71bf2bc9fdb470  guix-build-7ae424b899cf/output/x86_64-apple-darwin18/SHA256SUMS.part
19c10750e2271074ea735d5b908f5ec206dfbf6d4fbe64bca0ae31caa8ae5e942d  guix-build-7ae424b899cf/output/x86_64-apple-darwin18/bitcoin-7ae424b899cf-osx-unsigned.dmg
209bb167d2f957baa1b1150823ba7064be6ff47459dfe1aa3821aa4e1a23775840  guix-build-7ae424b899cf/output/x86_64-apple-darwin18/bitcoin-7ae424b899cf-osx-unsigned.tar.gz
212ed89ce2ddfdbee3240c3653c074955ea1a800fb6a386c34edfbca6394dd1754  guix-build-7ae424b899cf/output/x86_64-apple-darwin18/bitcoin-7ae424b899cf-osx64.tar.gz
22668afc33cbf9791933a92727f360d7d553a5de36d12162af2a9a25c256847fc7  guix-build-7ae424b899cf/output/x86_64-linux-gnu/SHA256SUMS.part
230f913f662f5d16d499bd60177221b8ab02c2ca3fff28b56a28da9c7a20480f91  guix-build-7ae424b899cf/output/x86_64-linux-gnu/bitcoin-7ae424b899cf-x86_64-linux-gnu-debug.tar.gz
24cc1a1a1bcb621b20bb982fa2b8b79a8f94358c34d8dd7d474ecbfff9db72ff14  guix-build-7ae424b899cf/output/x86_64-linux-gnu/bitcoin-7ae424b899cf-x86_64-linux-gnu.tar.gz
2557a4a6e420c4f8721e4981a306c0f94f2ca6578f362c9fb7e5a4d4378027d43c  guix-build-7ae424b899cf/output/x86_64-w64-mingw32/SHA256SUMS.part
26120c7df398b70556bff009afb9e3a96780ba6b46d59f7af98b0e3140f8ff1089  guix-build-7ae424b899cf/output/x86_64-w64-mingw32/bitcoin-7ae424b899cf-win-unsigned.tar.gz
273f24b0301b20de690516cfe734a84c83e05bea64c31d767770e239466da06586  guix-build-7ae424b899cf/output/x86_64-w64-mingw32/bitcoin-7ae424b899cf-win64-debug.zip
285eb6564689adac44c63c800586db0740515786a244ba506658f988ec5711f759  guix-build-7ae424b899cf/output/x86_64-w64-mingw32/bitcoin-7ae424b899cf-win64-setup-unsigned.exe
294ac3c715e8977fcfd6b9ae50a54f3b8080e6bb69367960e05f53551c716ec965  guix-build-7ae424b899cf/output/x86_64-w64-mingw32/bitcoin-7ae424b899cf-win64.zip

build: Add ability to build qt in depends with -stdlib=libc++ 33796a964a

in depends/packages/qt.mk:143 in 7ae424b899 outdated

139@@ -140,7 +140,11 @@ $(package)_config_opts_linux += -no-feature-vulkan
140 $(package)_config_opts_linux += -dbus-runtime
141 $(package)_config_opts_arm_linux += -platform linux-g++ -xplatform bitcoin-linux-g++
142 $(package)_config_opts_i686_linux  = -xplatform linux-g++-32
143+ifneq (,$(findstring clang++ -stdlib=libc++,$($(1)_cxx)))

fanquake commented at 5:47 am on September 28, 2021:

As mentioned in the comment from #22815 (review):

Looking only at the argument (which should directly follow the compiler name) looks kind of fragile and will not catch every case where someone links against libc++.

To expand on that, as-is this also wont work when you’re using a versioned clang, i.e clang++-12, which we often do in our CIs.

hebasto commented at 8:24 am on September 28, 2021:

Thanks! Updated.

hebasto force-pushed on Sep 28, 2021

hebasto commented at 6:21 am on September 28, 2021: member

Updated 7ae424b899cf5fb32f0a0bba487ea54e53ab276f -> 33796a964a8c605ce482959456d1ca78638340d9 (pr22814.01 -> pr22814.02):

addressed #22814 (review)
rebased on top of the #23060 (see #23060 (review))

MarcoFalke added the label DrahtBot Guix build requested on Sep 28, 2021

MarcoFalke deleted a comment on Sep 28, 2021

hebasto commented at 8:22 am on September 28, 2021: member

Guix builds:

 0$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 131a154cc2f48e8ca97f653f654d468df9f9e576d04e4e6108d78cbd4e861e47c  guix-build-33796a964a8c/output/aarch64-linux-gnu/SHA256SUMS.part
 2d86132ea582f2bd4f9c628ac7df4a2aa6e0c3e64a48bf0a16cd1c3293f8b2b27  guix-build-33796a964a8c/output/aarch64-linux-gnu/bitcoin-33796a964a8c-aarch64-linux-gnu-debug.tar.gz
 3d43e49a3443413f72383c4327f402de787af0b7bbc7d8e661e651137bd636f73  guix-build-33796a964a8c/output/aarch64-linux-gnu/bitcoin-33796a964a8c-aarch64-linux-gnu.tar.gz
 4673b67b092e19486d5fede917a5236f0f5320d70664903152717ecefbe120b05  guix-build-33796a964a8c/output/arm-linux-gnueabihf/SHA256SUMS.part
 5fbc7f256d71d0a30f18319cc68a52c32d0f192b1a3974dc34e4e2cb1a508044a  guix-build-33796a964a8c/output/arm-linux-gnueabihf/bitcoin-33796a964a8c-arm-linux-gnueabihf-debug.tar.gz
 614bbca1070e063a7581f91cfaec15b5002aa07d26e6f7c111527c3865cbd7325  guix-build-33796a964a8c/output/arm-linux-gnueabihf/bitcoin-33796a964a8c-arm-linux-gnueabihf.tar.gz
 7caed4f216af6f9917bde8d944165d27848227bcbccca11838c7634d6dcb7dbe5  guix-build-33796a964a8c/output/dist-archive/bitcoin-33796a964a8c.tar.gz
 80db4e2338b1fa32661b87623e0fd68a8a7d8f69ce9cbfb5ed9f1937a5f50b19f  guix-build-33796a964a8c/output/powerpc64-linux-gnu/SHA256SUMS.part
 9a427c3af3cdfd25e4e4c4ffbea0c7e1267d21a6e7bbab827568e9c50166f571f  guix-build-33796a964a8c/output/powerpc64-linux-gnu/bitcoin-33796a964a8c-powerpc64-linux-gnu-debug.tar.gz
109569e3390fb92a15316373f6808ed0bce80ca2fd0aed4a3fa25498bf4ecca076  guix-build-33796a964a8c/output/powerpc64-linux-gnu/bitcoin-33796a964a8c-powerpc64-linux-gnu.tar.gz
118e025033de78cb51c74ed1cfc0e3af560ec1a8a41d553ffac84475532073461a  guix-build-33796a964a8c/output/powerpc64le-linux-gnu/SHA256SUMS.part
129da7c9d12736f18c1f8bb0c58602a7aa4e6053e5bed61a2bb6fe09b5418e0030  guix-build-33796a964a8c/output/powerpc64le-linux-gnu/bitcoin-33796a964a8c-powerpc64le-linux-gnu-debug.tar.gz
1330020d531a2ab4bd5278d7c399ee23eadf3c6e2479df0a79dcefb750d81d99cf  guix-build-33796a964a8c/output/powerpc64le-linux-gnu/bitcoin-33796a964a8c-powerpc64le-linux-gnu.tar.gz
141c0bf18ef8dc592ed5864f121cca0ce0ca4b35710bcdc9fca8ce5fceec4bf7e5  guix-build-33796a964a8c/output/riscv64-linux-gnu/SHA256SUMS.part
150f7bbf8d0c13b9a519883f8a4697324eb410940fe83d03fb69da485edee66ac1  guix-build-33796a964a8c/output/riscv64-linux-gnu/bitcoin-33796a964a8c-riscv64-linux-gnu-debug.tar.gz
16cc68b0024c038b4eaa831ba261d58a0204886dd5ed6d0d227f450b01da2d77d5  guix-build-33796a964a8c/output/riscv64-linux-gnu/bitcoin-33796a964a8c-riscv64-linux-gnu.tar.gz
171876ed8ba6f21810fe990ab4bfa167506e568716c242385bf7d7dde130a2dcf4  guix-build-33796a964a8c/output/x86_64-apple-darwin19/SHA256SUMS.part
18c646278110ed3a1e13935e549a8bc94f7aaa61e2eccdf9d9bf26a34e1b7fe3c6  guix-build-33796a964a8c/output/x86_64-apple-darwin19/bitcoin-33796a964a8c-osx-unsigned.dmg
19168df829ba479e3d55500e825c22e4db2d464c238176475c304c923b72201cd2  guix-build-33796a964a8c/output/x86_64-apple-darwin19/bitcoin-33796a964a8c-osx-unsigned.tar.gz
208d35196f6010aafa93a29e11a9b25c894eef32162e897bef98beb60d452fc6d7  guix-build-33796a964a8c/output/x86_64-apple-darwin19/bitcoin-33796a964a8c-osx64.tar.gz
2141560bde25a0c8606e91e7166a8ad5239b86066692ec588dc4537f970e0acee4  guix-build-33796a964a8c/output/x86_64-linux-gnu/SHA256SUMS.part
229197132a68e6b2bba14a706f9e758e7399d62c5ed9473ef85d13b9b2fd98c2fc  guix-build-33796a964a8c/output/x86_64-linux-gnu/bitcoin-33796a964a8c-x86_64-linux-gnu-debug.tar.gz
238753052b0996e3411d0ac221dc4601cdb2a7b9f93278573d13dbb177a17b7d33  guix-build-33796a964a8c/output/x86_64-linux-gnu/bitcoin-33796a964a8c-x86_64-linux-gnu.tar.gz
2488dfef76cfc0ee47635328537e64af72a066ad76f9bd7dac33364d02c2132678  guix-build-33796a964a8c/output/x86_64-w64-mingw32/SHA256SUMS.part
25d746acda77584ec0f2f41a016a94b3d192d4f1087baf5706970743d509a5531f  guix-build-33796a964a8c/output/x86_64-w64-mingw32/bitcoin-33796a964a8c-win-unsigned.tar.gz
26f757730a7f6a327915e1b07f73927454c9870f675ee00b20f9d3204a8c8a1d15  guix-build-33796a964a8c/output/x86_64-w64-mingw32/bitcoin-33796a964a8c-win64-debug.zip
270c211ecd900ea5de9d552b2ae2c19665c9b48e7dbab688f54c46c8e891f62307  guix-build-33796a964a8c/output/x86_64-w64-mingw32/bitcoin-33796a964a8c-win64-setup-unsigned.exe
284b3fdc40d3028c6e1663f498ed04e5ead39922986b7928c8e8966c2664a92b31  guix-build-33796a964a8c/output/x86_64-w64-mingw32/bitcoin-33796a964a8c-win64.zip

hebasto commented at 8:45 am on September 28, 2021: member

Also this PR fixes the [no wallet] [bionic] task on CI:

on master (a8bbd4cc819633ec50ed0f763b6a75330ae055fb), https://api.cirrus-ci.com/v1/task/5558609250615296/logs/ci.log:

0Options used to compile and link:
1  external signer = yes
2  multiprocess    = no
3  with libs       = yes
4  with wallet     = no
5  with gui / qt   = no

this PR, https://api.cirrus-ci.com/v1/task/5502605561430016/logs/ci.log:

0Options used to compile and link:
1  external signer = yes
2  multiprocess    = no
3  with libs       = yes
4  with wallet     = no
5  with gui / qt   = yes

MarcoFalke commented at 9:42 am on September 28, 2021: member

Concept ACK

DrahtBot commented at 9:08 am on September 30, 2021: member

Guix builds

File	commit a9d0cec4991ab057557af9992daa4c8146a9b9d0(master)	commit c87b9c97399c49ea328df71c91421e9d2a5e9025(master and this pull)
SHA256SUMS.part	`7515a94e8ec61689...`	`fe7a91ebed9fcf37...`
*-aarch64-linux-gnu-debug.tar.gz	`55081b5b7874710a...`	`39e80b299ef67fea...`
*-aarch64-linux-gnu.tar.gz	`623bb4c744291b69...`	`c3fdf2779ba7db7d...`
*-arm-linux-gnueabihf-debug.tar.gz	`d805e5e115e09452...`	`e1a4ae83418fd04f...`
*-arm-linux-gnueabihf.tar.gz	`560ce13e78acc471...`	`b1082ec018a55fe3...`
*-osx-unsigned.dmg	`d917795016a6ee7a...`	`8fda8dda92109cdc...`
*-osx-unsigned.tar.gz	`d3150732da8919da...`	`c0909779d1d9d8f0...`
*-osx64.tar.gz	`0b2a0f5e4bc3ddbe...`	`5fe0453ae005b5ec...`
*-powerpc64-linux-gnu-debug.tar.gz	`2e90483aac2fe695...`	`57911e65ce28282b...`
*-powerpc64-linux-gnu.tar.gz	`722ef98b5b21f7f4...`	`0291ec46e1a5195d...`
*-powerpc64le-linux-gnu-debug.tar.gz	`ae3c660b90f712c2...`	`c97d7e2123031892...`
*-powerpc64le-linux-gnu.tar.gz	`472173a41ad9eb77...`	`57b9de1ecd8fa14e...`
*-riscv64-linux-gnu-debug.tar.gz	`99d9bed96dfea989...`	`9e579db241b281f2...`
*-riscv64-linux-gnu.tar.gz	`53f76b6a1abcead2...`	`9e978cedb60e54b9...`
*-win-unsigned.tar.gz	`76aea975aa54ac73...`	`eadabd9c12de92b2...`
*-win64-debug.zip	`db22fb74fc614854...`	`3c95166acd120cb2...`
*-win64-setup-unsigned.exe	`76d2381980e51efe...`	`5fb81ab736d1feb2...`
*-win64.zip	`7fe55e8b661c214b...`	`05953d316d60d5ac...`
*-x86_64-linux-gnu-debug.tar.gz	`495c16d923659eba...`	`abb5ffd0143b068d...`
*-x86_64-linux-gnu.tar.gz	`e17a0f993a02c997...`	`771da59cc7f842be...`
*.tar.gz	`e34cf78d2f5cc54a...`	`3db876f68d3c56a1...`
guix_build.log	`b7778a2d279eb1ed...`	`1ba55a48690195d5...`
guix_build.log.diff		`d728f2407944188d...`

DrahtBot removed the label DrahtBot Guix build requested on Sep 30, 2021

jarolrod commented at 4:56 am on November 3, 2021: member

contributing guix hashes, mine match @hebasto second round of hashes:

 0find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 1
 231a154cc2f48e8ca97f653f654d468df9f9e576d04e4e6108d78cbd4e861e47c  guix-build-33796a964a8c/output/aarch64-linux-gnu/SHA256SUMS.part
 3d86132ea582f2bd4f9c628ac7df4a2aa6e0c3e64a48bf0a16cd1c3293f8b2b27  guix-build-33796a964a8c/output/aarch64-linux-gnu/bitcoin-33796a964a8c-aarch64-linux-gnu-debug.tar.gz
 4d43e49a3443413f72383c4327f402de787af0b7bbc7d8e661e651137bd636f73  guix-build-33796a964a8c/output/aarch64-linux-gnu/bitcoin-33796a964a8c-aarch64-linux-gnu.tar.gz
 5673b67b092e19486d5fede917a5236f0f5320d70664903152717ecefbe120b05  guix-build-33796a964a8c/output/arm-linux-gnueabihf/SHA256SUMS.part
 6fbc7f256d71d0a30f18319cc68a52c32d0f192b1a3974dc34e4e2cb1a508044a  guix-build-33796a964a8c/output/arm-linux-gnueabihf/bitcoin-33796a964a8c-arm-linux-gnueabihf-debug.tar.gz
 714bbca1070e063a7581f91cfaec15b5002aa07d26e6f7c111527c3865cbd7325  guix-build-33796a964a8c/output/arm-linux-gnueabihf/bitcoin-33796a964a8c-arm-linux-gnueabihf.tar.gz
 8caed4f216af6f9917bde8d944165d27848227bcbccca11838c7634d6dcb7dbe5  guix-build-33796a964a8c/output/dist-archive/bitcoin-33796a964a8c.tar.gz
 90db4e2338b1fa32661b87623e0fd68a8a7d8f69ce9cbfb5ed9f1937a5f50b19f  guix-build-33796a964a8c/output/powerpc64-linux-gnu/SHA256SUMS.part
10a427c3af3cdfd25e4e4c4ffbea0c7e1267d21a6e7bbab827568e9c50166f571f  guix-build-33796a964a8c/output/powerpc64-linux-gnu/bitcoin-33796a964a8c-powerpc64-linux-gnu-debug.tar.gz
119569e3390fb92a15316373f6808ed0bce80ca2fd0aed4a3fa25498bf4ecca076  guix-build-33796a964a8c/output/powerpc64-linux-gnu/bitcoin-33796a964a8c-powerpc64-linux-gnu.tar.gz
128e025033de78cb51c74ed1cfc0e3af560ec1a8a41d553ffac84475532073461a  guix-build-33796a964a8c/output/powerpc64le-linux-gnu/SHA256SUMS.part
139da7c9d12736f18c1f8bb0c58602a7aa4e6053e5bed61a2bb6fe09b5418e0030  guix-build-33796a964a8c/output/powerpc64le-linux-gnu/bitcoin-33796a964a8c-powerpc64le-linux-gnu-debug.tar.gz
1430020d531a2ab4bd5278d7c399ee23eadf3c6e2479df0a79dcefb750d81d99cf  guix-build-33796a964a8c/output/powerpc64le-linux-gnu/bitcoin-33796a964a8c-powerpc64le-linux-gnu.tar.gz
151c0bf18ef8dc592ed5864f121cca0ce0ca4b35710bcdc9fca8ce5fceec4bf7e5  guix-build-33796a964a8c/output/riscv64-linux-gnu/SHA256SUMS.part
160f7bbf8d0c13b9a519883f8a4697324eb410940fe83d03fb69da485edee66ac1  guix-build-33796a964a8c/output/riscv64-linux-gnu/bitcoin-33796a964a8c-riscv64-linux-gnu-debug.tar.gz
17cc68b0024c038b4eaa831ba261d58a0204886dd5ed6d0d227f450b01da2d77d5  guix-build-33796a964a8c/output/riscv64-linux-gnu/bitcoin-33796a964a8c-riscv64-linux-gnu.tar.gz
181876ed8ba6f21810fe990ab4bfa167506e568716c242385bf7d7dde130a2dcf4  guix-build-33796a964a8c/output/x86_64-apple-darwin19/SHA256SUMS.part
19c646278110ed3a1e13935e549a8bc94f7aaa61e2eccdf9d9bf26a34e1b7fe3c6  guix-build-33796a964a8c/output/x86_64-apple-darwin19/bitcoin-33796a964a8c-osx-unsigned.dmg
20168df829ba479e3d55500e825c22e4db2d464c238176475c304c923b72201cd2  guix-build-33796a964a8c/output/x86_64-apple-darwin19/bitcoin-33796a964a8c-osx-unsigned.tar.gz
218d35196f6010aafa93a29e11a9b25c894eef32162e897bef98beb60d452fc6d7  guix-build-33796a964a8c/output/x86_64-apple-darwin19/bitcoin-33796a964a8c-osx64.tar.gz
2241560bde25a0c8606e91e7166a8ad5239b86066692ec588dc4537f970e0acee4  guix-build-33796a964a8c/output/x86_64-linux-gnu/SHA256SUMS.part
239197132a68e6b2bba14a706f9e758e7399d62c5ed9473ef85d13b9b2fd98c2fc  guix-build-33796a964a8c/output/x86_64-linux-gnu/bitcoin-33796a964a8c-x86_64-linux-gnu-debug.tar.gz
248753052b0996e3411d0ac221dc4601cdb2a7b9f93278573d13dbb177a17b7d33  guix-build-33796a964a8c/output/x86_64-linux-gnu/bitcoin-33796a964a8c-x86_64-linux-gnu.tar.gz
2588dfef76cfc0ee47635328537e64af72a066ad76f9bd7dac33364d02c2132678  guix-build-33796a964a8c/output/x86_64-w64-mingw32/SHA256SUMS.part
26d746acda77584ec0f2f41a016a94b3d192d4f1087baf5706970743d509a5531f  guix-build-33796a964a8c/output/x86_64-w64-mingw32/bitcoin-33796a964a8c-win-unsigned.tar.gz
27f757730a7f6a327915e1b07f73927454c9870f675ee00b20f9d3204a8c8a1d15  guix-build-33796a964a8c/output/x86_64-w64-mingw32/bitcoin-33796a964a8c-win64-debug.zip
280c211ecd900ea5de9d552b2ae2c19665c9b48e7dbab688f54c46c8e891f62307  guix-build-33796a964a8c/output/x86_64-w64-mingw32/bitcoin-33796a964a8c-win64-setup-unsigned.exe
294b3fdc40d3028c6e1663f498ed04e5ead39922986b7928c8e8966c2664a92b31  guix-build-33796a964a8c/output/x86_64-w64-mingw32/bitcoin-33796a964a8c-win64.zip

fanquake approved

fanquake commented at 3:35 am on December 30, 2021: member

ACK 33796a964a8c605ce482959456d1ca78638340d9 - While this sort of string matching is fragile, I think the risk of this causing any actual issues is low.

Anyone who was previously building with -stdlib=libc++ in their CXXFLAGS (us in CI) now gets a working Qt build.

Anywhere that was using a Clang which uses -stdlib=libc++ by default (i.e no passing in flags), will get the same (xplatform linux-g++-64) build. If they start passing -stdlib=libc++ they’ll, if anything, get a “more correct” Qt build.

Anyone who is building with GCC / anything else / doesn’t care about this, still gets the same -xplatform linux-g++-64 build.

Note that this is also scoped to Linux, so can’t cause issues with the macOS builds which use libc++.

fanquake merged this on Dec 30, 2021

fanquake closed this on Dec 30, 2021

sidhujag referenced this in commit 4975b13579 on Dec 30, 2021

hebasto deleted the branch on Dec 30, 2021

PastaPastaPasta referenced this in commit 86c0067754 on Apr 7, 2022

PastaPastaPasta referenced this in commit 015034a31d on Apr 11, 2022

gades referenced this in commit 5031959363 on May 12, 2022

DrahtBot locked this on Dec 30, 2022

build: Add ability to build qt in depends with -stdlib=libc++ #22814

Guix builds:

Guix builds:

Guix builds