Remove unused SERIALIZE_METHODS for CBanEntry #22849

1. 
   MarcoFalke commented at 4:30 pm on August 31, 2021: member

   It would be confusing to keep unused and dead code.
2. Remove unused SERIALIZE_METHODS for CBanEntry fab53ff1e5
3. Remove CBanEntry::SetNull fa3bd9de99
4. DrahtBot added the label Tests on Aug 31, 2021
5. ryanofsky approved
6. 
   ryanofsky commented at 4:43 pm on August 31, 2021: member

   Code review ACK fa3bd9de99ee2bdfce2010e9367391a146e41878.

   PR #22848 is related to this one. Without the binary serialization this PR removes, the JSON serialization which #22848 exposes is even more necessary for gui/node process separation. Either binary or json serialization for banmap_t will work for that, as long as there is some publicly exposed banmap<->string serialization function.

7. 
   theStack commented at 7:14 pm on August 31, 2021: member

   Concept ACK
8. 
   Zero-1729 commented at 7:18 pm on August 31, 2021: contributor

   Approach ACK
9. theStack approved
10. 
    theStack commented at 0:36 am on September 1, 2021: member

    Code-review ACK fa3bd9de99ee2bdfce2010e9367391a146e41878
11. 
    DrahtBot commented at 7:14 am on September 1, 2021: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #22848 (MOVEONLY: Expose BanMapToJson / BanMapFromJson by ryanofsky)
    • #22762 (Raise InitError when peers.dat is invalid or corrupted by MarcoFalke)
    • #10102 ([experimental] Multiprocess bitcoin by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

12. MarcoFalke merged this on Sep 1, 2021
13. MarcoFalke closed this on Sep 1, 2021

    ---

14. MarcoFalke deleted the branch on Sep 1, 2021
15. sidhujag referenced this in commit 39216deacc on Sep 1, 2021
16. DrahtBot locked this on Sep 1, 2022

Contributors
MarcoFalke ryanofsky theStack Zero-1729 DrahtBot

Labels
Tests