It would be confusing to keep unused and dead code.
Remove unused SERIALIZE_METHODS for CBanEntry #22849
pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2109-remBanEntrySer changing 3 files +7 −46-
MarcoFalke commented at 4:30 PM on August 31, 2021: member
-
Remove unused SERIALIZE_METHODS for CBanEntry fab53ff1e5
-
Remove CBanEntry::SetNull fa3bd9de99
- DrahtBot added the label Tests on Aug 31, 2021
- ryanofsky approved
-
ryanofsky commented at 4:43 PM on August 31, 2021: member
Code review ACK fa3bd9de99ee2bdfce2010e9367391a146e41878.
PR #22848 is related to this one. Without the binary serialization this PR removes, the JSON serialization which #22848 exposes is even more necessary for gui/node process separation. Either binary or json serialization for banmap_t will work for that, as long as there is some publicly exposed banmap<->string serialization function.
-
theStack commented at 7:14 PM on August 31, 2021: member
Concept ACK
-
Zero-1729 commented at 7:18 PM on August 31, 2021: contributor
Approach ACK
- theStack approved
-
theStack commented at 12:36 AM on September 1, 2021: member
Code-review ACK fa3bd9de99ee2bdfce2010e9367391a146e41878
-
DrahtBot commented at 7:14 AM on September 1, 2021: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #22848 (MOVEONLY: Expose BanMapToJson / BanMapFromJson by ryanofsky)
- #22762 (Raise InitError when peers.dat is invalid or corrupted by MarcoFalke)
- #10102 ([experimental] Multiprocess bitcoin by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- MarcoFalke merged this on Sep 1, 2021
- MarcoFalke closed this on Sep 1, 2021
- MarcoFalke deleted the branch on Sep 1, 2021
- sidhujag referenced this in commit 39216deacc on Sep 1, 2021
- DrahtBot locked this on Sep 1, 2022
