policy: document dust threshold for Taproot outputs #22863

pull darosior wants to merge 1 commits into bitcoin:master from darosior:dust_threshold_doc changing 1 files +6 −1
  1. darosior commented at 11:44 am on September 2, 2021: member
    Following discussions in #22779 .
  2. policy: document we intentionally don't lower the dust threshold for Taproot
    A "correction" of what seemed to be an overlook was initially proposed in
    PR #22779. It was deemed unnecessary to further reduce the dust level,
    so document the intention.
    
    Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
    d873db7f8f
  3. darosior commented at 11:45 am on September 2, 2021: member
    (Happy to bikeshed on the comment)
  4. fanquake added the label Docs on Sep 2, 2021
  5. fanquake added the label TX fees and policy on Sep 2, 2021
  6. TheBlueMatt approved
  7. in src/policy/policy.cpp:38 in d873db7f8f
    33@@ -34,6 +34,11 @@ CAmount GetDustThreshold(const CTxOut& txout, const CFeeRate& dustRelayFeeIn)
    34     int witnessversion = 0;
    35     std::vector<unsigned char> witnessprogram;
    36 
    37+    // Note this computation is for spending a Segwit v0 P2WPKH output (a 33 bytes
    38+    // public key + an ECDSA signature). For Segwit v1 Taproot outputs the minimum
    


    benthecarman commented at 8:07 pm on September 2, 2021:
    nit: maybe say 74 byte DER encoded signature
  8. benthecarman commented at 8:07 pm on September 2, 2021: contributor
    ACK d873db7f8ff37c37f9c72482d8ecd52282f4438e
  9. ariard commented at 10:25 pm on September 10, 2021: member
    Code Review ACK d873db7
  10. theStack approved
  11. theStack commented at 4:23 pm on October 5, 2021: member
    ACK d873db7f8ff37c37f9c72482d8ecd52282f4438e
  12. laanwj merged this on Oct 15, 2021
  13. laanwj closed this on Oct 15, 2021

  14. sidhujag referenced this in commit d79b962852 on Oct 15, 2021
  15. DrahtBot locked this on Oct 30, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me