Improve mempool_package_limits.py #22901

 204 |      }] if parent_locking_script else None
 205 |      signedtx = node.signrawtransactionwithkey(hexstring=rawtx, privkeys=privkeys, prevtxs=prevtxs)
 206 |      assert signedtx["complete"]
 207 |      tx = tx_from_hex(signedtx["hex"])
 208 | -    return (tx, signedtx["hex"], my_value, tx.vout[0].scriptPubKey.hex())
 209 | +    return tx, signedtx["hex"], my_value, tx.vout[0].scriptPubKey.hex()

glozow commented at 1:53 PM on September 6, 2021:

I think #21800 (review) suggested changing this return value to a named tuple instead?

 239 | @@ -238,18 +240,18 @@ def bulk_transaction(tx, node, target_weight, privkeys, prevtxs=None):
 240 |      """Pad a transaction with extra outputs until it reaches a target weight (or higher).
 241 |      returns CTransaction object
 242 |      """
 243 | -    tx_heavy = deepcopy(tx)

glozow commented at 1:55 PM on September 6, 2021:

Can also remove the import as well, iirc

 181 | @@ -182,28 +182,30 @@ def sendrawtransaction(self, *, from_node, tx_hex):
 182 |          from_node.sendrawtransaction(tx_hex)
 183 |          self.scan_tx(from_node.decoderawtransaction(tx_hex))
 184 |  
 185 | -def make_chain(node, address, privkeys, parent_txid, parent_value, n=0, parent_locking_script=None, fee=DEFAULT_FEE):
 186 | -    """Build a transaction that spends parent_txid.vout[n] and produces one output with
 187 | +def make_chain(node, address, privkeys, parent_txid, parent_value, parent_locking_script=None, fee=DEFAULT_FEE):

glozow commented at 1:59 PM on September 6, 2021:

https://github.com/bitcoin/bitcoin/pull/21800/files#r685091478 also suggested renaming this function

I'd suggest something like create_child ?

 132 | @@ -133,7 +133,7 @@ def test_independent(self):
 133 |      def test_chain(self):
 134 |          node = self.nodes[0]
 135 |          first_coin = self.coins.pop()
 136 | -        (chain_hex, chain_txns) = create_raw_chain(node, first_coin, self.address, self.privkeys)
 137 | +        chain_hex, chain_txns = create_raw_chain(node, first_coin, self.address, self.privkeys)

glozow commented at 2:01 PM on September 6, 2021:

You need to add the chain length here now that the default has been removed