test: Switch multiprocess to clang i686 build #22923

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2109-ciClang686 changing 3 files +9 −6
  1. MarcoFalke commented at 5:09 pm on September 8, 2021: member

    Building for i686 with clang helps to catch bugs early for:

    • The OSS-Fuzz i686 clang libFuzzer build
    • The arm 32-bit native clang build

    Fixes #22889

  2. in ci/test/00_setup_env_i686_multiprocess.sh:13 in fa91617be0 outdated
    11+export CONTAINER_NAME=ci_i686_multiprocess
    12 export DOCKER_NAME_TAG=ubuntu:20.04
    13-export PACKAGES="cmake python3 python3-pip llvm clang"
    14-export DEP_OPTS="DEBUG=1 MULTIPROCESS=1"
    15+export PACKAGES="cmake python3 python3-pip llvm clang g++-multilib"
    16+export DEP_OPTS="DEBUG=1 MULTIPROCESS=1 CC='clang -m32' CXX='clang++ -m32'"
    


    hebasto commented at 5:24 pm on September 8, 2021:
    I believe this won’t work due to #22184.

    MarcoFalke commented at 6:17 pm on September 8, 2021:
    It should still compile successfully. Though, I removed it now to minimize the diff

    hebasto commented at 6:34 pm on September 8, 2021:

    It should still compile successfully.

    Yes, it should. But with gcc, not clang.

  3. DrahtBot added the label Tests on Sep 8, 2021
  4. ci: Switch multiprocess to i686 build fae0295a79
  5. MarcoFalke force-pushed on Sep 8, 2021
  6. hebasto commented at 10:06 pm on September 8, 2021: member

    Great!

    CI catches #22889.

    Now add a fix?

  7. bench: Fix 32-bit compilation failure in addrman bench fa309ee61c
  8. practicalswift commented at 8:15 am on September 9, 2021: contributor
    Concept ACK
  9. laanwj commented at 11:02 am on September 9, 2021: member
    Concept ACK
  10. MarcoFalke commented at 11:03 am on September 9, 2021: member

    Now add a fix?

    Done

  11. MarcoFalke renamed this:
    ci: Switch multiprocess to clang i686 build
    test: Switch multiprocess to clang i686 build
    on Sep 9, 2021
  12. hebasto approved
  13. hebasto commented at 11:33 am on September 9, 2021: member
    ACK fa309ee61c09726a8780acaea94502712f817921
  14. laanwj merged this on Sep 9, 2021
  15. laanwj closed this on Sep 9, 2021

  16. MarcoFalke deleted the branch on Sep 9, 2021
  17. sidhujag referenced this in commit 9c64f0c945 on Sep 11, 2021
  18. DrahtBot locked this on Oct 30, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-01-21 06:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me