ci: use Debian Bullseye in ARM CI #22994

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:use_bullseye_arm_ci changing 2 files +3 −3

fanquake commented at 8:03 AM on September 16, 2021: member

This works around an issue when trying to use std::filesystem::remove_all with the ARM GCC on Buster. Has been split out of #20744.

See commentary starting here: #20744 (comment). Also: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93201.

ci: use Debian Bullseye in ARM CI

This works around an issue when trying to use `std::filesystem::remove_all`
with the ARM GCC on Buster. Has been split out of #20744.

See comments starting here:
https://github.com/bitcoin/bitcoin/pull/20744#issuecomment-810279549.
Also: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93201.

252d1a70fb

fanquake added the label Tests on Sep 16, 2021
MarcoFalke commented at 8:11 AM on September 16, 2021: member

We currently use gcc 8.4 for the arm guix builds. Should this be bumped to gcc 10.3?
fanquake commented at 8:22 AM on September 16, 2021: member

We currently use gcc 8.4 for the arm guix builds. Should this be bumped to gcc 10.3?

To match the base GCC in Buster it'd be 10.2, however if we were doing this, I don't think it should be part of this PR. Maybe another PR separate from #20744 that takes care of the more involved build system changes. There is at least some Guix changes required for the Windows build as well.
MarcoFalke commented at 8:24 AM on September 16, 2021: member

Nvm. Looks like this has been backported to gcc 8 after all: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81091#c9
MarcoFalke commented at 8:25 AM on September 16, 2021: member

cr ACK 252d1a70fb452893efe4ab64298139eb08d8ac98

Buster is on gcc 8.3, and it doesn't look like they are going to bump to 8.4 any time soon, so moving to the next debian release seems ok.
fanquake commented at 8:30 AM on September 16, 2021: member

Buster is on gcc 8.3, and it doesn't look like they are going to bump to 8.4 any time soon, so moving to the next debian release seems ok.

Yes, GCC-8 on Buster was bumped from 8.2 to 8.3 in Feb 2019, and received it's last update in April 2019.
hebasto approved
hebasto commented at 8:50 AM on September 16, 2021: member

ACK 252d1a70fb452893efe4ab64298139eb08d8ac98, I have reviewed the code and it looks OK, I agree it can be merged.
MarcoFalke referenced this in commit 87780dfee8 on Sep 16, 2021
MarcoFalke added the label DrahtBot Guix build requested on Sep 16, 2021
MarcoFalke removed the label DrahtBot Guix build requested on Sep 16, 2021
MarcoFalke added this to the milestone Future on Sep 16, 2021
MarcoFalke removed this from the milestone Future on Sep 16, 2021
MarcoFalke commented at 9:07 AM on September 16, 2021: member

This was merged, but not marked as merged by GitHub.
fanquake closed this on Sep 16, 2021
fanquake deleted the branch on Sep 16, 2021
fanquake locked this on Sep 18, 2021

Contributors

Labels

Linked (view graph)

#20744 Use std::filesystem. Remove Boost Filesystem & System