multiprocess: Make interfaces::Chain::isTaprootActive non-const #23003

1. 
   ryanofsky commented at 2:45 am on September 17, 2021: member

   interfaces::Chain is an abstract class, so declaring the method const would be exposing internal implementation details of subclasses to interface callers. And specifically this doesn’t work because the multiprocess implementation of the interfaces::Chain::isTaprootActive method can’t be const because IPC connection state and request state is not constant during the call.

   ---

   This PR is part of the process separation project.

2. multiprocess: Make interfaces::Chain::isTaprootActive non-const

   interfaces::Chain is an abstract class, so declaring the method const
   would be exposing internal implementation details of subclasses to
   interface callers. And specifically this doesn't work because the
   multiprocess implementation of the interfaces::Chain::isTaprootActive
   method can't be const because IPC connection state and request state is
   not constant during the call.

   7e88f61b28
3. fanquake added the label interfaces on Sep 17, 2021
4. fanquake added this to the "In progress" column in a project

   ---

5. 
   DrahtBot commented at 2:34 am on September 18, 2021: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #15719 (Wallet passive startup by ryanofsky)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. jamesob approved
7. 
   jamesob commented at 7:19 pm on October 12, 2021: member

   ACK https://github.com/bitcoin/bitcoin/pull/23003/commits/7e88f61b285e6a356ea4f6ba384858f109559985

   Super trivial, should be quick to review and merge.

8. MarcoFalke merged this on Oct 13, 2021
9. MarcoFalke closed this on Oct 13, 2021

   ---

10. sidhujag referenced this in commit 3dd626eddd on Oct 13, 2021
11. ryanofsky moved this from the "In progress" to the "Done" column in a project

    ---

12. DrahtBot locked this on Oct 30, 2022

Contributors
ryanofsky DrahtBot jamesob

Labels
interfaces