Add separate interfaces::Init subclasses for bitcoin-wallet, bitcoin-gui, and bitcoin-qt binaries instead of sharing bitcoind and bitcoin-node init subclasses in different binaries. After this, the new init subclasses can be customized in #10102, so node and wallet code is dropped from the bitcoin-gui binary and wallet code is dropped from into the bitcoin-node binary.
This PR is part of the process separation project.
Add separate init implementations instead of sharing existing bitcoind
and bitcoin-node ones, so they can start to be differentiated in
upcoming commits with node and wallet code no longer linked into the
bitcoin-gui binary and wallet code no longer linked into the
bitcoin-node binary.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
33+};
34+} // namespace
35+} // namespace init
36+
37+namespace interfaces {
38+std::unique_ptr<Init> MakeGuiInit(int argc, char* argv[]) { return std::make_unique<init::BitcoinQtInit>(); }
src/init/bitcoin-gui.cpp, i.e., make MakeGuiInit multi-line?
re: #23006 (review)
nit: style could follow
src/init/bitcoin-gui.cpp, i.e., makeMakeGuiInitmulti-line?
Done, but formatting came from clang-format with ColumnLimit
0@@ -0,0 +1,9 @@
1+// Copyright (c) 2021 The Bitcoin Core developers
2+// Distributed under the MIT software license, see the accompanying
3+// file COPYING or http://www.opensource.org/licenses/mit-license.php.
4+
5+#include <interfaces/init.h>
6+
7+namespace interfaces {
8+std::unique_ptr<Init> MakeWalletInit(int argc, char* argv[], int& exit_status) { return std::make_unique<Init>(); }
src/init/bitcoin-gui.cpp, i.e., make MakeWalletInit multi-line?
re: #23006 (review)
nit: style could follow
src/init/bitcoin-gui.cpp, i.e., makeMakeWalletInitmulti-line?
Done, but formatting came from clang-format with ColumnLimit
msbuild.
Thanks for reviews!
Updated 2d3d624be4adb789673c25517d2e7b417f563a29 -> d5f985e51f2863fda0c0d632e836eba42a5c3e15 (pr/ipc-init.1 -> pr/ipc-init.2, compare) with suggestions
