ci: Increase the dynamic port range to the maximum on native Windows #23089

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:210924-portrange changing 1 files +5 −1

hebasto commented at 6:53 PM on September 24, 2021: member

Fixes #18548.

The solution suggested in #18548 (comment).

Also more functional tests added to the native Windows task.

ci: Increase the dynamic port range to the maximum on native Windows

This change should mitigate "OSError: [WinError 10048] Only one usage of
each socket address (protocol/network address/port) is normally
permitted".

8e08a4b6ce

ci: Add more functional tests to the native Windows task 097ac74fd2
hebasto added the label Windows on Sep 24, 2021
hebasto added the label Tests on Sep 24, 2021
vincenzopalazzo approved
vincenzopalazzo commented at 10:10 PM on September 24, 2021: none

ack https://github.com/bitcoin/bitcoin/pull/23089/commits/097ac74fd22f706fb7d8d652dadea844dc8198b9
MarcoFalke commented at 6:36 AM on September 25, 2021: member

concept ACK 097ac74fd22f706fb7d8d652dadea844dc8198b9

in .cirrus.yml:153 in 097ac74fd2

 146 | @@ -147,6 +147,10 @@ task:
 147 |      - python test\util\test_runner.py
 148 |      - python test\util\rpcauth-test.py
 149 |    functional_tests_script:
 150 | +    # Increase the dynamic port range to the maximum allowed value to mitigate "OSError: [WinError 10048] Only one usage of each socket address (protocol/network address/port) is normally permitted".
 151 | +    # See: https://docs.microsoft.com/en-us/biztalk/technical-guides/settings-that-can-be-modified-to-improve-network-performance
 152 | +    - netsh int ipv4 set dynamicport tcp start=1025 num=64511
 153 | +    - netsh int ipv6 set dynamicport tcp start=1025 num=64511

MarcoFalke commented at 6:41 AM on September 25, 2021:

does this mean they might collide with the p2p and rpc ports from [TEST_RUNNER_PORT_MIN, TEST_RUNNER_PORT_MIN + 2 * range] ([14000, 24000])?

hebasto commented at 7:29 AM on September 25, 2021:

Yes, if an ephemeral port by accident belongs to that range a collision is possible. But this range limits only ports of P2P and RPC connections. Our test framework uses ports out of this range in the feature_bind_extra.py and feature_proxy.py. The former is skipped on Windows, but the latter still could be a source of port collisions.

MarcoFalke commented at 6:44 AM on September 25, 2021: member

Maybe this allows to revert fab98992043f47fa7240d7c1217920d0c4f783a2 some day?
darosior commented at 7:20 AM on September 25, 2021: member

Concept ACK. Most of the latest PRs are currently failing CI because of this.
MarcoFalke merged this on Sep 25, 2021
MarcoFalke closed this on Sep 25, 2021
hebasto deleted the branch on Sep 25, 2021
MarcoFalke referenced this in commit 58c25bdcea on Sep 27, 2021
sidhujag referenced this in commit 272269f993 on Sep 27, 2021
DrahtBot locked this on Oct 30, 2022

Contributors

Labels

Linked (view graph)

#18548 Tests fail intermittently on Windows (appveyor) "OSError: [WinError 10048] Only one usage of each socket address (protocol/network address/port) is normally permitted"#23092 test: Remove Windows workaround in authproxy (WinError 10053)