refactor: rename DBErrors::RESCAN_REQUIRED to NEED_RESCAN #23147

pull meshcollider wants to merge 1 commits into bitcoin:master from meshcollider:202110_rename_rescan_enum changing 4 files +4 −4

meshcollider commented at 9:33 PM on September 30, 2021: contributor

Suggested here as a trivial follow-up: #23123 (review)

Makes RESCAN_REQUIRED consistent with NEED_REWRITE
achow101 commented at 9:42 PM on September 30, 2021: member

scripted diff?

scripted-diff: rename DBErrors::RESCAN_REQUIRED to NEED_RESCAN

-BEGIN VERIFY SCRIPT-
git grep -l 'RESCAN_REQUIRED' src | xargs sed -i 's/RESCAN_REQUIRED/NEED_RESCAN/g'
-END VERIFY SCRIPT-

8615507a4e

meshcollider commented at 10:05 PM on September 30, 2021: contributor

Added scripted diff
meshcollider added the label Refactoring on Sep 30, 2021

in src/wallet/walletdb.h:52 in 8615507a4e

  48 | @@ -49,7 +49,7 @@ enum class DBErrors
  49 |      TOO_NEW,
  50 |      LOAD_FAIL,
  51 |      NEED_REWRITE,
  52 | -    RESCAN_REQUIRED
  53 | +    NEED_RESCAN

jonatack commented at 10:21 PM on September 30, 2021:

if you have to retouch

    NEED_RESCAN,

jonatack commented at 10:22 PM on September 30, 2021: member

ACK 8615507a4e510bc797b01c4bbe45dc1f91e0bfa0
achow101 commented at 10:38 PM on September 30, 2021: member

ACK 8615507a4e510bc797b01c4bbe45dc1f91e0bfa0
fanquake renamed this:
~~trivial refactor: rename DBErrors::RESCAN_REQUIRED to NEED_RESCAN~~
refactor: rename DBErrors::RESCAN_REQUIRED to NEED_RESCAN
on Sep 30, 2021
fanquake referenced this in commit 33b0696d31 on Oct 1, 2021
fanquake commented at 2:47 AM on October 1, 2021: member

This has been merged.
fanquake closed this on Oct 1, 2021
DrahtBot commented at 2:47 AM on October 1, 2021: member



🐙 This pull request conflicts with the target branch and needs rebase.

<sub>Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".</sub>
DrahtBot added the label Needs rebase on Oct 1, 2021
fanquake removed the label Needs rebase on Oct 1, 2021
meshcollider deleted the branch on Oct 1, 2021
sidhujag referenced this in commit e2498f0a20 on Oct 1, 2021
DrahtBot locked this on Oct 30, 2022

Contributors

Labels

Linked (view graph)

#23123 Remove `-rescan` startup parameter