qa: Intermittent failure in feature_fee_estimation.py #23165

issue hebasto openend this issue on October 3, 2021
  1. hebasto commented at 7:04 am on October 3, 2021: member

    On master (29b030bca31d1246e94b3396b0a01a17dadc96a8), native Windows build:

     050/221 - feature_fee_estimation.py failed, Duration: 49 s
     1stdout:
     22021-10-01T09:05:04.925000Z TestFramework (INFO): Initializing test directory C:\Users\ContainerAdministrator\AppData\Local\Temp\test_runner_₿_🏃_20211001_084858\feature_fee_estimation_176
     32021-10-01T09:05:07.559000Z TestFramework (INFO): This test is time consuming, please be patient
     42021-10-01T09:05:07.559000Z TestFramework (INFO): Splitting inputs so we can generate tx's
     52021-10-01T09:05:15.861000Z TestFramework (INFO): Finished splitting
     62021-10-01T09:05:18.194000Z TestFramework (INFO): Will output estimates for 1/2/3/6/15/25 blocks
     72021-10-01T09:05:18.194000Z TestFramework (INFO): Creating transactions and mining them with a block size that can't keep up
     82021-10-01T09:05:33.053000Z TestFramework (INFO): Creating transactions and mining them at a block size that is just big enough
     92021-10-01T09:05:53.747000Z TestFramework (ERROR): Assertion failed
    10Traceback (most recent call last):
    11  File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\test_framework\test_framework.py", line 131, in main
    12    self.run_test()
    13  File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\feature_fee_estimation.py", line 272, in run_test
    14    check_estimates(self.nodes[1], self.fees_per_kb)
    15  File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\feature_fee_estimation.py", line 156, in check_estimates
    16    check_smart_estimates(node, fees_seen)
    17  File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\feature_fee_estimation.py", line 146, in check_smart_estimates
    18    raise AssertionError(f"Estimated fee ({feerate}) larger than last fee ({last_feerate}) for lower number of confirms")
    19AssertionError: Estimated fee (0.00029) larger than last fee (0.0002826) for lower number of confirms
    

    Similar issues are known (#11800, #20725), but I’m not sure all failures are the same.

  2. hebasto added the label Bug on Oct 3, 2021
  3. meshcollider commented at 11:35 pm on October 11, 2021: contributor

    Hit this again here: https://cirrus-ci.com/task/6508236183437312?logs=ci#L3424

     0test  2021-10-11T23:26:12.597000Z TestFramework (ERROR): Assertion failed 
     1                                   Traceback (most recent call last):
     2                                     File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 132, in main
     3                                       self.run_test()
     4                                     File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_fee_estimation.py", line 364, in run_test
     5                                       self.sanity_check_estimates_range()
     6                                     File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_fee_estimation.py", line 276, in sanity_check_estimates_range
     7                                       check_estimates(self.nodes[1], self.fees_per_kb)
     8                                     File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_fee_estimation.py", line 157, in check_estimates
     9                                       check_smart_estimates(node, fees_seen)
    10                                     File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_fee_estimation.py", line 147, in check_smart_estimates
    11                                       raise AssertionError(f"Estimated fee ({feerate}) larger than last fee ({last_feerate}) for lower number of confirms")
    12                                   AssertionError: Estimated fee (0.00079932) larger than last fee (0.00067525) for lower number of confirms
    

    Perhaps fixed by #21161 ?

  4. fanquake commented at 9:19 pm on February 19, 2022: member

    Seen again here: https://cirrus-ci.com/task/6440635971403776?logs=ci#L3369:

     0 node1 2022-02-19T11:40:30.242543Z [http] [httpserver.cpp:242] [http_request_cb] Received a POST request for / from 127.0.0.1:59090 
     1 node1 2022-02-19T11:40:30.242595Z [httpworker.0] [rpc/request.cpp:179] [parse] ThreadRPCServer method=getmempoolinfo user=__cookie__ 
     2 test  2022-02-19T11:40:30.243000Z TestFramework (ERROR): Assertion failed 
     3                                   Traceback (most recent call last):
     4                                     File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 132, in main
     5                                       self.run_test()
     6                                     File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_fee_estimation.py", line 332, in run_test
     7                                       self.sanity_check_estimates_range()
     8                                     File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_fee_estimation.py", line 250, in sanity_check_estimates_range
     9                                       check_estimates(self.nodes[1], self.fees_per_kb)
    10                                     File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_fee_estimation.py", line 129, in check_estimates
    11                                       check_smart_estimates(node, fees_seen)
    12                                     File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_fee_estimation.py", line 117, in check_smart_estimates
    13                                       f"Estimated fee ({feerate}) larger than last fee ({last_feerate}) for lower number of confirms"
    14                                   AssertionError: Estimated fee (0.00039966) larger than last fee (0.00033786) for lower number of confirms
    15 test  2022-02-19T11:40:30.251000Z TestFramework (DEBUG): Closing down network thread 
    16 test  2022-02-19T11:40:30.301000Z TestFramework (INFO): Stopping nodes 
    17 test  2022-02-19T11:40:30.302000Z TestFramework.node0 (DEBUG): Stopping node 
    
  5. jonatack commented at 11:43 am on May 5, 2022: member

    Seen again: https://cirrus-ci.com/task/5178042396966912?logs=ci#L3381

    0Traceback (most recent call last):
    1File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 133, in main self.run_test()
    2File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_fee_estimation.py", line 297, in run_test self.sanity_check_estimates_range()
    3File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_fee_estimation.py", line 213, in sanity_check_estimates_range check_estimates(self.nodes[1], self.fees_per_kb)
    4File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_fee_estimation.py", line 115, in check_estimates check_smart_estimates(node, fees_seen)
    5File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_fee_estimation.py", line 102, in check_smart_estimates raise AssertionError(
    6AssertionError: Estimated fee (0.00108829) larger than last fee (0.00096573) for lower number of confirms
    
  6. jonatack commented at 10:36 pm on May 31, 2022: member
  7. jonatack commented at 3:10 pm on June 12, 2022: member
  8. hebasto renamed this:
    qa: Intermittent failure in feature_fee_estimation.py
    qa: Intermittent failure in `feature_fee_estimation.py`
    on Jun 27, 2022
  9. jonatack commented at 2:31 pm on July 14, 2022: member
  10. fanquake commented at 11:57 am on November 1, 2022: member
  11. maflcko commented at 5:59 pm on December 7, 2022: member
    Is this still an issue with a recent version of Bitcoin Core? If yes, what are the steps to reproduce?
  12. maflcko closed this on Dec 7, 2022

  13. aureleoules commented at 8:23 am on January 10, 2023: contributor
  14. maflcko reopened this on Jan 10, 2023

  15. fanquake commented at 1:58 pm on March 9, 2023: member

    https://cirrus-ci.com/task/6452772573282304?logs=ci#L3336

     0 test  2023-03-09T10:13:27.038000Z TestFramework (ERROR): Assertion failed 
     1                                   Traceback (most recent call last):
     2                                     File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 134, in main
     3                                       self.run_test()
     4                                     File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/feature_fee_estimation.py", line 313, in run_test
     5                                       self.sanity_check_estimates_range()
     6                                     File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/feature_fee_estimation.py", line 219, in sanity_check_estimates_range
     7                                       check_estimates(self.nodes[1], self.fees_per_kb)
     8                                     File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/feature_fee_estimation.py", line 118, in check_estimates
     9                                       check_smart_estimates(node, fees_seen)
    10                                     File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/feature_fee_estimation.py", line 105, in check_smart_estimates
    11                                       raise AssertionError(
    12                                   AssertionError: Estimated fee (0.00068289) larger than last fee (0.00064707) for lower number of confirms
    13 test  2023-03-09T10:13:27.039000Z TestFramework (DEBUG): Closing down network thread 
    
  16. fanquake commented at 2:57 pm on April 14, 2023: member

    https://cirrus-ci.com/task/6110951150190592?logs=ci#L3312:

     0 node1 2023-04-14T11:01:41.617514Z [http] [httpserver.cpp:257] [http_request_cb] [http] Received a POST request for / from 127.0.0.1:49238 
     1 node1 2023-04-14T11:01:41.617673Z [httpworker.2] [rpc/request.cpp:180] [parse] [rpc] ThreadRPCServer method=getmempoolinfo user=__cookie__ 
     2 test  2023-04-14T11:01:41.618000Z TestFramework (ERROR): Assertion failed 
     3                                   Traceback (most recent call last):
     4                                     File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 132, in main
     5                                       self.run_test()
     6                                     File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/feature_fee_estimation.py", line 313, in run_test
     7                                       self.sanity_check_estimates_range()
     8                                     File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/feature_fee_estimation.py", line 219, in sanity_check_estimates_range
     9                                       check_estimates(self.nodes[1], self.fees_per_kb)
    10                                     File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/feature_fee_estimation.py", line 118, in check_estimates
    11                                       check_smart_estimates(node, fees_seen)
    12                                     File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/feature_fee_estimation.py", line 105, in check_smart_estimates
    13                                       raise AssertionError(
    14                                   AssertionError: Estimated fee (0.00108829) larger than last fee (0.00096573) for lower number of confirms
    15 test  2023-04-14T11:01:41.620000Z TestFramework (DEBUG): Closing down network thread 
    16 test  2023-04-14T11:01:41.670000Z TestFramework (INFO): Stopping nodes 
    
  17. mzumsande commented at 9:30 pm on July 6, 2023: contributor
    Just noting here too (I also posted in #20725) that failures can be reproduced by using the PRNG seed from the log (7288975409214300634 in the most recent one) and running with --randomseed. So it would be good to include that seed in future reports - the earlier ones are no longer accessible from cirrus.
  18. jonatack commented at 6:38 pm on October 11, 2023: member

    https://github.com/bitcoin/bitcoin/actions/runs/6477706663/job/17588320797?pr=28248#step:6:14421

     02023-10-11T05:27:08.637000Z TestFramework (INFO): PRNG seed is: 5585159971690227248
     12023-10-11T05:27:08.643000Z TestFramework (INFO): Initializing test directory /tmp/test_runner_₿_🏃_20231011_052658/feature_fee_estimation_283
     22023-10-11T05:27:08.774000Z TestFramework (INFO): This test is time consuming, please be patient
     32023-10-11T05:27:08.774000Z TestFramework (INFO): Splitting inputs so we can generate tx's
     42023-10-11T05:27:09.262000Z TestFramework (INFO): Finished splitting
     52023-10-11T05:27:09.906000Z TestFramework (INFO): Testing estimates with single transactions.
     62023-10-11T05:27:09.906000Z TestFramework (INFO): Will output estimates for 1/2/3/6/15/25 blocks
     72023-10-11T05:27:09.906000Z TestFramework (INFO): Creating transactions and mining them with a block size that can't keep up
     82023-10-11T05:27:18.350000Z TestFramework (INFO): Creating transactions and mining them at a block size that is just big enough
     92023-10-11T05:27:26.389000Z TestFramework (ERROR): Assertion failed
    10Traceback (most recent call last):
    11  File "/home/runner/work/bitcoin/bitcoin/test/functional/test_framework/test_framework.py", line 131, in main
    12    self.run_test()
    13  File "/home/runner/work/bitcoin/bitcoin/test/functional/feature_fee_estimation.py", line 405, in run_test
    14    self.sanity_check_estimates_range()
    15  File "/home/runner/work/bitcoin/bitcoin/test/functional/feature_fee_estimation.py", line 222, in sanity_check_estimates_range
    16    check_estimates(self.nodes[1], self.fees_per_kb)
    17  File "/home/runner/work/bitcoin/bitcoin/test/functional/feature_fee_estimation.py", line 121, in check_estimates
    18    check_smart_estimates(node, fees_seen)
    19  File "/home/runner/work/bitcoin/bitcoin/test/functional/feature_fee_estimation.py", line 108, in check_smart_estimates
    20    raise AssertionError(
    21AssertionError: Estimated fee (0.00091517) larger than last fee (0.00081208) for lower number of confirms
    

    Reproduced locally with:

    ./test/functional/feature_fee_estimation.py --randomseed 5585159971690227248
  19. jonatack commented at 9:20 pm on November 2, 2023: member
    This is probably resolved by the merge of #21161 and can be closed.
  20. maflcko closed this on Nov 3, 2023

  21. bitcoin locked this on Nov 2, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me