lock contentions in checkqueue_tests after #22904 #23167

1. 
   fanquake commented at 3:12 am on October 4, 2021: member

   Tracking issue for the follow up comments in #22904. It seems that PR has introduced lock contentions, and/or the checkqueue_tests are now behaving very poorly, with long runtimes and generating GBs of log output in some cases. See comments starting here: #22904 (comment).

   cc @ajtowns @theuni @martinus

2. fanquake added the label Bug on Oct 4, 2021
3. 
   vasild commented at 4:30 pm on November 2, 2021: member

   Both #23223 and #23397 alleviate this. Some primitive testing:

   master (9e3f7dcaa2f89efff48d299132f4998bf701c264): with DEBUG_LOG_OUT: 6m28s, 2.2GB log without DEBUG_LOG_OUT: 6m10s, no log

   PR #23223 (6ae9f1cf9604227e9dfda1f6c91fc711d154362e): with DEBUG_LOG_OUT: 1m3s, 5KB log without DEBUG_LOG_OUT: 1m1s, no log

   PR #23397 (5bcfd70a3b): with DEBUG_LOG_OUT: 5m00s, 1.8GB log without DEBUG_LOG_OUT: 5m9s, no log

   (non-optimized debug builds)

4. MarcoFalke referenced this in commit 3c4729a515 on Nov 2, 2021
5. MarcoFalke closed this on Nov 2, 2021

   ---

6. MarcoFalke referenced this in commit b4f647fa36 on Nov 29, 2021
7. sidhujag referenced this in commit 537b8a836d on Nov 29, 2021
8. PastaPastaPasta referenced this in commit c8374bd577 on Apr 7, 2022
9. PastaPastaPasta referenced this in commit 25f8e062c0 on Apr 7, 2022
10. PastaPastaPasta referenced this in commit 572737fff5 on Apr 7, 2022
11. PastaPastaPasta referenced this in commit 22838d1b8c on Apr 11, 2022
12. DrahtBot locked this on Nov 2, 2022

Contributors
fanquake vasild

Labels
Bug