doc: Extract FundTxDoc in rpcwallet #23172

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2110-docRpcWallet changing 1 files +34 −75

MarcoFalke commented at 12:57 PM on October 4, 2021: member

No need to duplicate the documentation for the same field(s) three times.

Fix that by de-duplicating it for the fields: conf_target, estimate_mode, replaceable, and solving_data.

Can be reviewed with --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space.

doc: Extract FundTxDoc

For the fields: conf_target, estimate_mode, replaceable, and solving_data.

fafff132cf

fanquake added the label Docs on Oct 4, 2021
MarcoFalke commented at 1:00 PM on October 4, 2021: member

Rendered diff:
MarcoFalke renamed this:
~~doc: Extract FundTxDoc~~
doc: Extract FundTxDoc in rpcwallet
on Oct 4, 2021
DrahtBot commented at 12:17 PM on October 6, 2021: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #23202 (wallet: allow psbtbumpfee to work with txs with external inputs by achow101)
- #23201 (wallet: Allow users to specify input weights when funding a transaction by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
fanquake approved
fanquake commented at 5:27 AM on October 7, 2021: member

ACK fafff132cf4e5c2950d28f63cb4320236d1a5495
fanquake merged this on Oct 7, 2021
fanquake closed this on Oct 7, 2021
MarcoFalke deleted the branch on Oct 7, 2021
sidhujag referenced this in commit a067ea61af on Oct 7, 2021
MarcoFalke referenced this in commit e7507f333b on Dec 1, 2021
DrahtBot locked this on Oct 30, 2022

Contributors

Labels