Add CJDNS network to -addrinfo and -netinfo #23175

1. 
   jonatack commented at 3:46 pm on October 4, 2021: member

   Follow-up to #23077 and #23324.

    0$ ./src/bitcoin-cli -addrinfo
    1{
    2  "addresses_known": {
    3    "ipv4": 47782,
    4    "ipv6": 10307,
    5    "onion": 8030,
    6    "i2p": 41,
    7    "cjdns": 1,
    8    "total": 66161
    9  }
   10}
   11$ ./src/bitcoin-cli -netinfo 
   12Bitcoin Core client v22.99.0-deb6223d4c55 - server 70016/Satoshi:22.99.0(jon)/
   13
   14        ipv4    ipv6   onion     i2p   cjdns   total   block  manual
   15in         0       5      12       5       1      23
   16out        2       2       9       5       2      20       2      10
   17total      2       7      21      10       3      43
   

   0$ ./src/bitcoin-cli -netinfo 1
   

   

2. DrahtBot added the label Utils/log/libs on Oct 4, 2021
3. 
   laanwj commented at 9:02 pm on October 4, 2021: member

   Concept ACK
4. 
   dunxen commented at 6:10 am on October 5, 2021: contributor

   Concept ACK

   I’m rebasing this on #23077 and testing it out :)

5. 
   practicalswift commented at 10:24 am on October 5, 2021: contributor

   Concept ACK

   Thanks for improving -addrinfo and -netinfo.

6. 
   ghost commented at 11:25 am on October 5, 2021: none

   I am still not sure about CJDNS and have no opinions on #23077

   However, looking at the support from others it will most likely get merged so this PR makes sense.

   Concept ACK

7. 
   DrahtBot commented at 8:55 am on October 21, 2021: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   No conflicts as of last run.

8. laanwj referenced this in commit ee1294f155 on Oct 21, 2021
9. sidhujag referenced this in commit b43d231c1d on Oct 21, 2021
10. 
    Zero-1729 commented at 11:29 am on October 22, 2021: contributor

    Concept ACK
11. 
    laanwj commented at 1:47 pm on November 8, 2021: member

    Needs rebase (and can go out of draft) now that #23175 is merged.
12. 
    prusnak commented at 6:16 pm on November 8, 2021: contributor

    Needs rebase (and can go out of draft) now that #23175 is merged.

    laanwj meant #23077 (#23175 is this PR)

13. cli: add cjdns network to -addrinfo and -netinfo 5bd40a3e84
14. cli: hoist networks class data members to a constant 7b6528746a
15. jonatack marked this as ready for review on Nov 11, 2021
16. 
    jonatack commented at 12:25 pm on November 11, 2021: member

    Thanks! Rebased and updated (simplified) following the merge of #23324, and bringing out of draft now that #23077 has been merged.
17. jonatack force-pushed on Nov 11, 2021
18. prusnak approved
19. 
    prusnak commented at 1:13 pm on November 11, 2021: contributor

    utACK
20. 
    laanwj commented at 9:19 pm on November 15, 2021: member

    Code review ACK 7b6528746acf9c915d7157bb860ec899b58dded7
21. laanwj referenced this in commit caf8b26b52 on Nov 15, 2021
22. DrahtBot added the label Needs rebase on Nov 15, 2021
23. 
    DrahtBot commented at 9:41 pm on November 15, 2021: member

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

24. 
    prusnak commented at 9:53 pm on November 15, 2021: contributor

    This PR has been merged into master via https://github.com/bitcoin/bitcoin/commit/caf8b26b52bf38289899dfa1ca15aa9c9d140971
25. sipa closed this on Nov 15, 2021

    ---

26. 
    sipa commented at 9:57 pm on November 15, 2021: member

    Closing as merged.
27. sidhujag referenced this in commit 5371b96f1e on Nov 16, 2021
28. jonatack deleted the branch on Nov 16, 2021
29. DrahtBot locked this on Nov 17, 2022

Contributors
jonatack laanwj dunxen practicalswift ghost DrahtBot Zero-1729 prusnak sipa

Labels
Utils/log/libs Needs rebase