This small refactoring PR replaces manual bit-fiddling (de)serialization of the BIP32 child number (nChild) by the helpers ReadBE32/WriteBE32. Note that those were first introduced in #4100, almost one year after the BIP32 derivation implementation has been merged (#2829, eb2c9990).
refactor: use `{Read,Write}BE32` helpers for BIP32 nChild (de)serialization #23199
pull theStack wants to merge 1 commits into bitcoin:master from theStack:202110-refactor-use_be32_helpers_for_bip32_nchild changing 3 files +5 −10-
theStack commented at 10:29 PM on October 5, 2021: member
-
refactor: use `{Read,Write}BE32` helpers for BIP32 nChild (de)serialization 7fc487afd1
- fanquake added the label Refactoring on Oct 5, 2021
-
sipa commented at 10:32 PM on October 5, 2021: member
utACK 7fc487afd1249eee97651a0eec0630d7e421924f
-
practicalswift commented at 9:21 AM on October 6, 2021: contributor
Concept ACK
-
laanwj commented at 12:17 PM on October 7, 2021: member
Code review ACK 7fc487afd1249eee97651a0eec0630d7e421924f Checked that all changed sequences match big-endian behavior.
- fanquake merged this on Oct 11, 2021
- fanquake closed this on Oct 11, 2021
- theStack deleted the branch on Oct 11, 2021
- sidhujag referenced this in commit 99b48c9473 on Oct 11, 2021
- PastaPastaPasta referenced this in commit c921d51d51 on Mar 13, 2022
- DrahtBot locked this on Oct 30, 2022
