Replace stoul with ToIntegral in dbwrapper #23214

1. 
   MarcoFalke commented at 9:14 am on October 7, 2021: member

   The string is created with %llu. See: https://github.com/bitcoin/bitcoin/blob/7fcf53f7b4524572d1d0c9a5fdc388e87eb02416/src/leveldb/db/db_impl.cc#L1436-L1437

   So it seems odd to silently accept when parsing: whitespace, a sign character, trailing chars, overflow, ….

   Fix that by using the stricter ToIntegral.

2. Replace stoul with ToIntegral in dbwrapper fa165e9545
3. 
   practicalswift commented at 11:39 am on October 7, 2021: contributor

   Concept ACK

   Very happy to see the KNOWN_VIOLATIONS list in test/lint/lint-locale-dependence.sh shrink. Only a few violations left to tackle! :)

4. 
   laanwj commented at 12:12 pm on October 7, 2021: member

   Code review ACK fa165e954579436fe4b636e4222d8ce0c1269786
5. DrahtBot added the label UTXO Db and Indexes on Oct 7, 2021
6. theStack approved
7. 
   theStack commented at 2:54 pm on October 10, 2021: member

   Code-review ACK fa165e954579436fe4b636e4222d8ce0c1269786
8. 
   practicalswift commented at 3:40 pm on October 10, 2021: contributor

   cr ACK fa165e954579436fe4b636e4222d8ce0c1269786
9. fanquake merged this on Oct 11, 2021
10. fanquake closed this on Oct 11, 2021

    ---

11. MarcoFalke deleted the branch on Oct 11, 2021
12. sidhujag referenced this in commit 614f35a333 on Oct 11, 2021
13. DrahtBot locked this on Oct 30, 2022

Contributors
MarcoFalke practicalswift laanwj theStack

Labels
UTXO Db and Indexes