Add unit tests for Taproot code in src/script/interpreter.cpp #23279

issue practicalswift opened this issue on October 14, 2021

practicalswift commented at 12:48 PM on October 14, 2021: contributor
The Taproot code in src/script/interpreter.cpp is covered by our functional tests (test/functional/feature_taproot.py and test/functional/wallet_taproot.py), but we don't have any unit test coverage for this code.

Unit test coverage for src/script/interpreter.cpp can be found here:
- https://marcofalke.github.io/btc_cov/test_bitcoin.coverage/src/script/interpreter.cpp.gcov.html
These functions in src/script/interpreter.cpp are currently not covered by our unit tests:
- EvalChecksigTapscript
- HandleMissingData
- SignatureHashSchnorr
- GenericTransactionSignatureChecker<T>::VerifySchnorrSignature
- GenericTransactionSignatureChecker<T>::CheckSchnorrSignature
- ComputeTaprootMerkleRoot
- SigVersion::TAPSCRIPT code paths in ExecuteWitnessScript
- Taproot code paths in VerifyWitnessProgram
It would be nice to have C++ unit tests covering this code in addition to the Python functional tests.
fanquake added the label Tests on Oct 14, 2021
maflcko commented at 12:53 PM on October 14, 2021: member

Related: https://github.com/bitcoin/bips/pull/1191
david-bakin commented at 3:47 PM on April 11, 2022: contributor

I'm working on this ... updates shortly.
sipa commented at 3:51 PM on April 11, 2022: member

Part of this is covered by https://github.com/bitcoin/bitcoin/pull/23394
david-bakin commented at 2:05 AM on May 3, 2022: contributor

... still working on this ... PR shortly ...
david-bakin referenced this in commit 5807b4c1b3 on May 4, 2022
david-bakin referenced this in commit d34cbcef50 on May 9, 2022
david-bakin referenced this in commit d692ae7b31 on May 21, 2022
david-bakin referenced this in commit fedc037dba on May 24, 2022
david-bakin referenced this in commit 5d6148b4e4 on Jun 5, 2022
david-bakin referenced this in commit 376afb4b60 on Jun 5, 2022
david-bakin referenced this in commit 047a9f0774 on Jun 5, 2022
david-bakin referenced this in commit eeefec3435 on Jun 5, 2022
billymcbip commented at 5:15 PM on November 27, 2025: none

EvalChecksigTapscript

I've added a unit test for the empty pubkey error in Tapscript signature validation: #33961.

Contributors

Labels

Linked (view graph)

#25097 test: Unit tests for taproot/tapscript coverage in `interpreter.cpp`#34473 test: add Taproot support to script_builder