ci, refactor: Disable binaries for Android task explicitly #23286

1. 
   hebasto commented at 1:13 pm on October 15, 2021: member

   This PR defines a set of binaries that are compiled in the Android APK task explicitly via configure options, that allows to avoid relying on the test_bitcoin_qt target from the src/qt/Makefile.

   It is ported from https://github.com/bitcoin-core/gui-qml/pull/58.

   No behavior change.

2. ci, refactor: Disable binaries for Android task explicitly

   No behavior change.

   67bb6b5c43
3. DrahtBot added the label Tests on Oct 15, 2021
4. 
   MarcoFalke commented at 4:04 pm on October 15, 2021: member

   Excerpt Before:

    0Options used to compile and link:
    1  external signer = yes
    2  multiprocess    = no
    3  with experimental syscall sandbox support = no
    4  with libs       = yes
    5  with wallet     = yes
    6    with sqlite   = yes
    7    with bdb      = yes
    8  with gui / qt   = yes
    9    with qr       = yes
   10  with zmq        = yes
   11  with test       = yes
   12  with bench      = yes
   13  with upnp       = yes
   14  with natpmp     = yes
   15  use asm         = yes
   16  ebpf tracing    = no
   17  sanitizers      = 
   18  debug enabled   = no
   19  gprof enabled   = no
   20  werror          = no
   21
   22  target os       = android
   23  build os        = linux-gnu
   24...
   25  AR       qt/libbitcoinqt.a
   26  CXXLD    qt/bitcoin-qt
   27  CXXLD    qt/test/test_bitcoin-qt
   28make[1]: Leaving directory '/tmp/cirrus-ci-build/src'
   

   Excerpt After:

    0Options used to compile and link:
    1  external signer = yes
    2  multiprocess    = no
    3  with experimental syscall sandbox support = no
    4  with libs       = no
    5  with wallet     = yes
    6    with sqlite   = yes
    7    with bdb      = yes
    8  with gui / qt   = yes
    9    with qr       = yes
   10  with zmq        = yes
   11  with test       = no
   12  with bench      = no
   13  with upnp       = yes
   14  with natpmp     = yes
   15  use asm         = yes
   16  ebpf tracing    = no
   17  sanitizers      = 
   18  debug enabled   = no
   19  gprof enabled   = no
   20  werror          = no
   21
   22  target os       = android
   23  build os        = linux-gnu
   24...
   25  AR       qt/libbitcoinqt.a
   26  CXXLD    qt/bitcoin-qt
   27  CXXLD    qt/test/test_bitcoin-qt
   28make[2]: Leaving directory '/tmp/cirrus-ci-build/src'
   

5. 
   MarcoFalke commented at 4:04 pm on October 15, 2021: member

   cr ACK 67bb6b5c4327d74d0183dc238e0361ede1414481
6. MarcoFalke merged this on Oct 15, 2021
7. MarcoFalke closed this on Oct 15, 2021

   ---

8. hebasto deleted the branch on Oct 15, 2021
9. 
   fanquake commented at 11:59 pm on October 15, 2021: member

   I don’t understand this PR. What is the motivation?

   No behavior change.

   Well now we are testing less than we were before, and I’m not sure what we’ve gained? Even though Android isn’t currently a particularly important part of our CI, I don’t like the idea that we are reducing test coverage here to work around things that might not work in the https://github.com/bitcoin-core/gui-qml repo.

10. 
    hebasto commented at 6:03 am on October 16, 2021: member

    Well now we are testing less than we were before…

    The set of compiled and linked binaries is the same:

    0...
    1  CXXLD    qt/bitcoin-qt
    2  CXXLD    qt/test/test_bitcoin-qt
    3...
    

    What “reducing test coverage” do you mean?

    UPDATE. Now it’s possible to drop --disable-X or --without-Y configure options and increase the test coverage, and it will work in both repos because Android APK task now avoids using of pure Makefile targets.

11. sidhujag referenced this in commit 0d2677df59 on Oct 16, 2021
12. hebasto referenced this in commit 13a95074e2 on Oct 19, 2021
13. DrahtBot locked this on Oct 30, 2022

Contributors
hebasto MarcoFalke fanquake

Labels
Tests