ci: Disable syscall sandbox in valgrind functional tests #23328

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2110-ciValSan changing 1 files +1 −1
  1. MarcoFalke commented at 7:06 PM on October 20, 2021: member

    Otherwise this will fail:

    $ valgrind ./src/bitcoind -regtest -datadir=/tmp -sandbox=log-and-abort 
    ==204660== Memcheck, a memory error detector
    ==204660== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
    ==204660== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
    ==204660== Command: ./src/bitcoind -regtest -datadir=/tmp -sandbox=log-and-abort
    ==204660== 
    Bad system call (core dumped)
    
  2. ci: Disable syscall sandbox in valgrind functional tests fa44406ffd
  3. MarcoFalke force-pushed on Oct 20, 2021
  4. MarcoFalke commented at 7:07 PM on October 20, 2021: member

    I presume valgrind isn't supported @practicalswift ?

  5. MarcoFalke commented at 7:08 PM on October 20, 2021: member

    This config isn't run by any CI task in this repo, but I use it outside

  6. DrahtBot added the label Tests on Oct 20, 2021
  7. laanwj commented at 9:24 PM on October 20, 2021: member

    Concept ACK. I would guess that this doesn't work because valgrind will instrument the process with its own code, which uses system calls that are not allowed by the sandbox.

  8. practicalswift commented at 7:48 AM on October 21, 2021: contributor

    Good catch!

    cr ACK fa44406ffd34670af929f14484042e1de29ffcdd

    I would guess that this doesn't work because valgrind will instrument the process with its own code, which uses system calls that are not allowed by the sandbox.

    Exactly! Same thing with libFuzzer and some sanitizers - that's why we do this in configure.ac:

      AC_MSG_WARN(Specifying --with-sanitizers forces --without-seccomp since the sanitizers
        introduce use of syscalls not allowed by the bitcoind syscall sandbox (-sandbox=<mode>).)
    
  9. MarcoFalke merged this on Oct 21, 2021
  10. MarcoFalke closed this on Oct 21, 2021

  11. MarcoFalke deleted the branch on Oct 21, 2021
  12. sidhujag referenced this in commit 649116d217 on Oct 21, 2021
  13. DrahtBot locked this on Oct 30, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me