build: upgrade to boost 1.77 to fix c++20 compilation #23340

pull PastaPastaPasta wants to merge 1 commits into bitcoin:master from PastaPastaPasta:bump-boost-version-1.73-btc changing 3 files +2 −46
  1. PastaPastaPasta commented at 11:31 pm on October 22, 2021: contributor
    I’ve been investigating compiling bitcoin core using C++20. It appears that our usage of boost requires boost 1.73 or above in order to compile using C++20 (compilation fails with any version lower than that). After initial review, it was recommended to bump boost to 1.77.
  2. DrahtBot added the label Build system on Oct 23, 2021
  3. meshcollider added the label Brainstorming on Oct 23, 2021
  4. meshcollider removed the label Brainstorming on Oct 23, 2021
  5. meshcollider added the label Needs Conceptual Review on Oct 23, 2021
  6. DrahtBot commented at 4:29 am on October 23, 2021: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #24301 (build: header-only Boost by fanquake)
    • #24276 (build, refactor: Improve package version usage by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  7. PastaPastaPasta commented at 10:26 pm on October 25, 2021: contributor
    @laanwj do you have any thoughts about this?
  8. MarcoFalke commented at 9:59 am on October 27, 2021: member
    No opinion on whether to bump or to what version, but if it was bumped to 1.74, we could remove the suppression: Can be removed once upgraded to boost test 1.74 in depends race:validation_chainstatemanager_tests.
  9. PastaPastaPasta commented at 7:45 pm on November 3, 2021: contributor
    Any thoughts on this? If there are no objections, I think it makes sense to move forward with this change
  10. MarcoFalke added the label DrahtBot Guix build requested on Nov 3, 2021
  11. DrahtBot commented at 11:31 pm on November 4, 2021: member

    Guix builds

    File commit 23ae7931be50376fa6bda692c641a3d2538556ee(master) commit c096b28e0ead50cd0037bb1b979e94bb463655f6(master and this pull)
    SHA256SUMS.part cf50f128b602ab65... 06a8575772225725...
    *-aarch64-linux-gnu-debug.tar.gz e10508157a01231e... c9bbee020c74f3af...
    *-aarch64-linux-gnu.tar.gz e2cb56ab0ee32128... c82367925d27b9e8...
    *-arm-linux-gnueabihf-debug.tar.gz d27c96429b5bb4e3... b92a45e50d1863b2...
    *-arm-linux-gnueabihf.tar.gz 47138db881b2ef9f... f85f15be6bb19308...
    *-osx-unsigned.dmg b580489970d37854... 52df0cfba57c26dc...
    *-osx-unsigned.tar.gz 079d976bdd52ce45... a08c037fafdc1704...
    *-osx64.tar.gz ace53bd5937e32f9... c91daef738010f2d...
    *-powerpc64-linux-gnu-debug.tar.gz 3ce5502c3402ba48... 47bad850de785f4d...
    *-powerpc64-linux-gnu.tar.gz 4bffa32c3ba37739... 6a2a7d86cb63874f...
    *-powerpc64le-linux-gnu-debug.tar.gz 149f8b122ebcabce... 5336ebcde7d57164...
    *-powerpc64le-linux-gnu.tar.gz b43c278a29e89f3e... e382df2c1b180925...
    *-riscv64-linux-gnu-debug.tar.gz 7665faab2901d721... 68f220c5c78cc07f...
    *-riscv64-linux-gnu.tar.gz 79894efa0b2611c4... 0b79abc64307aa5f...
    *-win-unsigned.tar.gz 88c990eb9760fa88... 072611d0be30f8d8...
    *-win64-debug.zip ac7181d85479661c... ca9798beb72faa0f...
    *-win64-setup-unsigned.exe ac3f3aab498f9eea... ae7c9af9a495037d...
    *-win64.zip dc357b1942c66795... cbffada5770e575e...
    *-x86_64-linux-gnu-debug.tar.gz a04c0ba3fae5ce5e... a84135f6e2f05ed6...
    *-x86_64-linux-gnu.tar.gz 67221fe2e21042fe... 5fc47ba59b94e088...
    *.tar.gz ec20f2ea6c112877... 71bfffdebfb24eca...
    guix_build.log 279d60922577cc97... d3f82400af44dea0...
    guix_build.log.diff fc87b0a571cd7835...
  12. DrahtBot removed the label DrahtBot Guix build requested on Nov 4, 2021
  13. fanquake commented at 2:45 am on November 8, 2021: member

    If there are no objections, I think it makes sense to move forward with this change

    I think this is an awkward bump, and if we are going to update Boost again, it might as well be to the current latest version, which is 1.77.0. As mentioned, that would mean we can drop a suppression, and we’d avoid some build warnings related to unused variables in the process module. We are also early enough in the release cycle that if there are any serious issues the update could be reverted. Just make sure you update our Boost package to account for the fact that we don’t need the CMake files that will be generated with the newer version.

    Also, please write a better commit message. i.e build: update depends Boost to 1.77.0.

  14. PastaPastaPasta force-pushed on Nov 9, 2021
  15. PastaPastaPasta renamed this:
    build: upgrade to boost 1.73 to fix c++20 compilation
    build: upgrade to boost 1.77 to fix c++20 compilation
    on Nov 9, 2021
  16. PastaPastaPasta commented at 3:48 pm on November 9, 2021: contributor
    Bumped to 1.77 and removed suppression as suggested above, will sqash once we have ACKs / Concept ACKs
  17. hebasto commented at 3:52 pm on November 9, 2021: member

    … will sqash once we have ACKs / Concept ACKs

    The opposite is preferable though…

  18. PastaPastaPasta force-pushed on Nov 9, 2021
  19. PastaPastaPasta commented at 6:36 pm on November 9, 2021: contributor

    … will sqash once we have ACKs / Concept ACKs

    The opposite is preferable though…

    Okay, squashed, I generally prefer having a clean history, but that’s okay :)

  20. MarcoFalke added the label DrahtBot Guix build requested on Nov 9, 2021
  21. MarcoFalke removed the label DrahtBot Guix build requested on Nov 9, 2021
  22. MarcoFalke added the label DrahtBot Guix build requested on Nov 9, 2021
  23. MarcoFalke commented at 7:00 pm on November 9, 2021: member

    �[0;32m node1 stderr ERROR: The syscall “fstatfs” (syscall number 138) is not allowed by the syscall sandbox in thread “httpworker.0”. Please report.

  24. PastaPastaPasta commented at 7:47 pm on November 9, 2021: contributor

    �[0;32m node1 stderr ERROR: The syscall “fstatfs” (syscall number 138) is not allowed by the syscall sandbox in thread “httpworker.0”. Please report.

    Any suggestions? I’d be happy to revert to 1.76 and work it down until ci is happy?

  25. MarcoFalke commented at 7:53 pm on November 9, 2021: member
    Either you add it in the right place, like commit fab360aa0027a274681eff3f00ac1972bcfa126c or you wait for #20744 or you pick a different version. Not opinion on what to do.
  26. PastaPastaPasta commented at 8:43 pm on November 9, 2021: contributor

    Either you add it in the right place, like commit fab360a or you wait for #20744 or you pick a different version. Not opinion on what to do.

    If someone would like to provide a diff similar to what Marco mentions, I’ll be happy to apply it, but I’m not too familiar with syscall sandboxing

    At this point, I’m going to move forward with trying version working back from 1.77 to 1.76 etc until I find one that CI is happy with.

  27. fanquake commented at 3:33 am on November 10, 2021: member

    Bumped to 1.77 and removed suppression as suggested above,

    You didn’t update to account for the Cmake files as mentioned.

    Okay, squashed, I generally prefer having a clean history, but that’s okay :)

    Pull requests are expected to contain changes that are reviewable / ACKable. Don’t push random changes / fixups with the intent to “squash later”; make whatever changes/fixups you need to locally, then squash, fixup commit messages etc, before pushing to GitHub. Separately, rather than crossing out stuff in your PR description, either update it if it’s relevant, or remove it entirely, otherwise it’s just polluting the merge message with garbage. Given the point of this PR is to fix the C++20 build, it would be worthwhile including what is actually failing with Boost 1.71.0, or why 1.73.0 or later is required.

    At this point, I’m going to move forward with trying version working back from 1.77 to 1.76 etc until I find one that CI is happy with.

    I’d still rather we move to 1.77.0, adding any syscall exceptions as needed. Also, please don’t do development via CI. It’s noisy, and is really just abusing CI resources. You can run the CI locally to test you changes, and ensure they are working before pushing them up.

  28. MarcoFalke commented at 7:01 am on November 10, 2021: member 
     0�[0;39;49m�[1;34;49mtest/bip32_tests.cpp(159): Entering test suite "bip32_tests"
 1�[0;39;49m�[1;34;49mtest/bip32_tests.cpp(177): Entering test case "bip32_test5"
 2==78132==WARNING: MemorySanitizer: use-of-uninitialized-value
 3    [#0](/bitcoin-bitcoin/0/) 0x562ff2d626fb in boost::filesystem::detail::status(boost::filesystem::path const&, boost::system::error_code*) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_75_0-25950737f88/libs/filesystem/src/operations.cpp:2603:7
 4    [#1](/bitcoin-bitcoin/1/) 0x562ff2d6f3c0 in boost::filesystem::detail::temp_directory_path(boost::system::error_code*) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_75_0-25950737f88/libs/filesystem/src/operations.cpp:2799:24
 5    [#2](/bitcoin-bitcoin/2/) 0x562ff15276b0 in boost::filesystem::temp_directory_path() /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/filesystem/operations.hpp:517:46
 6    [#3](/bitcoin-bitcoin/3/) 0x562ff151ae48 in BasicTestingSetup::BasicTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&) src/test/util/setup_common.cpp:76:19
 7    [#4](/bitcoin-bitcoin/4/) 0x562ff0697d82 in bip32_tests::bip32_test5::bip32_test5() src/test/bip32_tests.cpp:177:1
 8    [#5](/bitcoin-bitcoin/5/) 0x562ff068abc6 in bip32_tests::bip32_test5_invoker() src/test/bip32_tests.cpp:177:1
 9    [#6](/bitcoin-bitcoin/6/) 0x562ff0592e98 in boost::detail::function::void_function_invoker0<void (*)(), void>::invoke(boost::detail::function::function_buffer&) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/function/function_template.hpp:117:11
10    [#7](/bitcoin-bitcoin/7/) 0x562ff2f4dbac in boost::function0<void>::operator()() const /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_75_0-25950737f88/./boost/function/function_template.hpp:763:14
11    [#8](/bitcoin-bitcoin/8/) 0x562ff2f4dbac in boost::detail::forward::operator()() /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_75_0-25950737f88/./boost/test/impl/execution_monitor.ipp:1388:32
12    [#9](/bitcoin-bitcoin/9/) 0x562ff2f4dbac in boost::detail::function::function_obj_invoker0<boost::detail::forward, int>::invoke(boost::detail::function::function_buffer&) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_75_0-25950737f88/./boost/function/function_template.hpp:137:18
13    [#10](/bitcoin-bitcoin/10/) 0x562ff2f40aba in boost::function0<int>::operator()() const /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_75_0-25950737f88/./boost/function/function_template.hpp:763:14
14    [#11](/bitcoin-bitcoin/11/) 0x562ff2f40aba in int boost::detail::do_invoke<boost::shared_ptr<boost::detail::translator_holder_base>, boost::function<int ()> >(boost::shared_ptr<boost::detail::translator_holder_base> const&, boost::function<int ()> const&) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_75_0-25950737f88/./boost/test/impl/execution_monitor.ipp:301:30
15    [#12](/bitcoin-bitcoin/12/) 0x562ff2f40aba in boost::execution_monitor::catch_signals(boost::function<int ()> const&) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_75_0-25950737f88/./boost/test/impl/execution_monitor.ipp:903:16
16    [#13](/bitcoin-bitcoin/13/) 0x562ff2f4119b in boost::execution_monitor::execute(boost::function<int ()> const&) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_75_0-25950737f88/./boost/test/impl/execution_monitor.ipp:1301:16
17    [#14](/bitcoin-bitcoin/14/) 0x562ff2f45559 in boost::execution_monitor::vexecute(boost::function<void ()> const&) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_75_0-25950737f88/./boost/test/impl/execution_monitor.ipp:1397:5
18    [#15](/bitcoin-bitcoin/15/) 0x562ff2e58393 in boost::unit_test::unit_test_monitor_t::execute_and_translate(boost::function<void ()> const&, unsigned long) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_75_0-25950737f88/./boost/test/impl/unit_test_monitor.ipp:49:9
19    [#16](/bitcoin-bitcoin/16/) 0x562ff2dcc644 in boost::unit_test::framework::state::execute_test_tree(unsigned long, unsigned long, boost::unit_test::framework::state::random_generator_helper const*) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_75_0-25950737f88/./boost/test/impl/framework.ipp:815:44
20    [#17](/bitcoin-bitcoin/17/) 0x562ff2dcd898 in boost::unit_test::framework::state::execute_test_tree(unsigned long, unsigned long, boost::unit_test::framework::state::random_generator_helper const*) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_75_0-25950737f88/./boost/test/impl/framework.ipp:784:58
21    [#18](/bitcoin-bitcoin/18/) 0x562ff2dcd898 in boost::unit_test::framework::state::execute_test_tree(unsigned long, unsigned long, boost::unit_test::framework::state::random_generator_helper const*) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_75_0-25950737f88/./boost/test/impl/framework.ipp:784:58
22    [#19](/bitcoin-bitcoin/19/) 0x562ff2db5595 in boost::unit_test::framework::run(unsigned long, bool) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_75_0-25950737f88/./boost/test/impl/framework.ipp:1721:29
23    [#20](/bitcoin-bitcoin/20/) 0x562ff2e53b36 in boost::unit_test::unit_test_main(boost::unit_test::test_suite* (*)(int, char**), int, char**) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_75_0-25950737f88/./boost/test/impl/unit_test_main.ipp:250:9
24    [#21](/bitcoin-bitcoin/21/) 0x562ff2e55500 in main /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_75_0-25950737f88/./boost/test/impl/unit_test_main.ipp:306:12
25    [#22](/bitcoin-bitcoin/22/) 0x7f39b873b0b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
26    [#23](/bitcoin-bitcoin/23/) 0x562ff03e9c4d in _start (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/test_bitcoin+0x10fc4d)
27
28  Uninitialized value was created by an allocation of 'path_stat' in the stack frame of function '_ZN5boost10filesystem6detail6statusERKNS0_4pathEPNS_6system10error_codeE'
29    [#0](/bitcoin-bitcoin/0/) 0x562ff2d620f0 in boost::filesystem::detail::status(boost::filesystem::path const&, boost::system::error_code*) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_75_0-25950737f88/libs/filesystem/src/operations.cpp:2572
30
31SUMMARY: MemorySanitizer: use-of-uninitialized-value /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_75_0-25950737f88/libs/filesystem/src/operations.cpp:2603:7 in boost::filesystem::detail::status(boost::filesystem::path const&, boost::system::error_code*)
32Exiting
33make[3]: *** [Makefile:18537: test/bip32_tests.cpp.test] Error 1
  29. DrahtBot commented at 12:45 pm on November 11, 2021: member

    Guix builds

    File commit 8ae4ba481ce8f7da173bef24432729c87a36cb70(master) commit c8d22fdea633bf4d9bcd570d0b44ce58da2908ba(master and this pull)
    SHA256SUMS.part 22350bcdf0dc6067... 4cf0c2684cb6879d...
    *-aarch64-linux-gnu-debug.tar.gz 461183bd4b38bb9a... faf0d096ad6beb58...
    *-aarch64-linux-gnu.tar.gz 39f99ecf9adb732e... 847e7d54358e06cb...
    *-arm-linux-gnueabihf-debug.tar.gz 20d40e96bfabfa46... 81d218d0522f1abb...
    *-arm-linux-gnueabihf.tar.gz ad67195f6da31b80... 22d4bbc21b4339c5...
    *-osx-unsigned.dmg 611679c8b829807c... 26ffd178c80bc0b5...
    *-osx-unsigned.tar.gz 3666b90c6a370e84... 92c349d1a14e42db...
    *-osx64.tar.gz d3c307c9882f8e7a... 2d1f9f65336aa775...
    *-powerpc64-linux-gnu-debug.tar.gz c3362cc9872e5b1e... a197fe0f713d1f30...
    *-powerpc64-linux-gnu.tar.gz 9d863b80f72a74d4... ab5f81c8ad62f25c...
    *-powerpc64le-linux-gnu-debug.tar.gz f539074a5b09df14... 5e06290f03540ff3...
    *-powerpc64le-linux-gnu.tar.gz 9189c98698308814... cae24165dcbaf7d1...
    *-riscv64-linux-gnu-debug.tar.gz 31c485818f2dd6fe... 2a913409ed143922...
    *-riscv64-linux-gnu.tar.gz cbc8cc247e1b8fa6... c8258709ae7f28d6...
    *-win-unsigned.tar.gz b8143ffc61cff8f3... 4614e61aa259d1c1...
    *-win64-debug.zip 60a2327a73a9ad9c... 6047ae909bf46c1c...
    *-win64-setup-unsigned.exe 9284b740d172f950... 4fd832fcbfc5242b...
    *-win64.zip 08d0ed07504aa064... 2e1e9f303661b3e3...
    *-x86_64-linux-gnu-debug.tar.gz ac3d18b6f7154ae9... 72dcbbf2ebed9d1c...
    *-x86_64-linux-gnu.tar.gz c91b59140c7c60b1... 603ee840abb16ff9...
    *.tar.gz c545a1b30478a46a... 1491d6239268a5ae...
    guix_build.log 5c539c9184e716b5... 26a652b25fa44b21...
    guix_build.log.diff 7e32126fabc9d880...
  30. DrahtBot removed the label DrahtBot Guix build requested on Nov 11, 2021
  31. MarcoFalke commented at 4:22 pm on November 19, 2021: member
    You can rebase on #23555
  32. PastaPastaPasta commented at 6:46 pm on November 19, 2021: contributor

    You can rebase on #23555

    I presume you want me to revert back to 1.77 and rebase, correct?

    Did that ^

  33. PastaPastaPasta force-pushed on Nov 19, 2021
  34. MarcoFalke commented at 7:54 am on November 20, 2021: member

    Looks like the msan issue is still there. Maybe a miscompilation? (Can’t reproduce in valgrind so far)

    Also, we should watch out for this change in boost 1.76: #23551 (comment)

  35. dougEfresh commented at 8:47 am on December 7, 2021: contributor

    In case this helps, Even if you upgrade to clang13 with llvm13 libc++ and use std::filesystem instead of boost you get a similar error:

     0SUMMARY: MemorySanitizer: use-of-uninitialized-value /tmp/cirrus-ci-build/ci/scratch/msan/llvm-project/libcxx/src/filesystem/operations.cpp:553:7 in std::__1::__fs::filesystem::detail::(anonymous namespace)::create_file_status(std::__1::error_code&, std::__1::__fs::filesystem::path const&, stat const&, std::__1::error_code*)
 1  ORIGIN: invalid (0). Might be a bug in MemorySanitizer origin tracking.
 2    This could still be a bug in your code, too!
 3Exiting
 4
 5==75987==WARNING: MemorySanitizer: use-of-uninitialized-value
 6    [#0](/bitcoin-bitcoin/0/) 0x7fb7ba7c0851 in std::__1::__fs::filesystem::detail::(anonymous namespace)::create_file_status(std::__1::error_code&, std::__1::__fs::filesystem::path const&, stat const&, std::__1::error_code*) /tmp/cirrus-ci-build/ci/scratch/msan/llvm-project/libcxx/src/filesystem/operations.cpp:553:7
 7    [#1](/bitcoin-bitcoin/1/) 0x7fb7ba7b7071 in posix_stat /tmp/cirrus-ci-build/ci/scratch/msan/llvm-project/libcxx/src/filesystem/operations.cpp:578:10
 8    [#2](/bitcoin-bitcoin/2/) 0x7fb7ba7b7071 in posix_stat /tmp/cirrus-ci-build/ci/scratch/msan/llvm-project/libcxx/src/filesystem/operations.cpp:583:10
 9    [#3](/bitcoin-bitcoin/3/) 0x7fb7ba7b7071 in std::__1::__fs::filesystem::__temp_directory_path(std::__1::error_code*) /tmp/cirrus-ci-build/ci/scratch/msan/llvm-project/libcxx/src/filesystem/operations.cpp:1449:20
10    [#4](/bitcoin-bitcoin/4/) 0x557d728af752 in std::__1::__fs::filesystem::temp_directory_path() /tmp/cirrus-ci-build/ci/scratch/msan/build/include/c++/v1/filesystem:2295:10
11    [#5](/bitcoin-bitcoin/5/) 0x557d728af752 in BasicTestingSetup::BasicTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&) src/test/util/setup_common.cpp:76:19
12    [#6](/bitcoin-bitcoin/6/) 0x557d728b1cc1 in ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&) src/test/util/setup_common.cpp:135:7
13    [#7](/bitcoin-bitcoin/7/) 0x557d728b3023 in TestingSetup::TestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&) src/test/util/setup_common.cpp:173:7
14    [#8](/bitcoin-bitcoin/8/) 0x557d715c9c35 in RegTestingSetup::RegTestingSetup() src/./test/util/setup_common.h:107:11
15    [#9](/bitcoin-bitcoin/9/) 0x557d715c9c35 in blockencodings_tests::SimpleRoundTripTest::SimpleRoundTripTest() src/test/blockencodings_tests.cpp:55:1
16    [#10](/bitcoin-bitcoin/10/) 0x557d715c9c35 in blockencodings_tests::SimpleRoundTripTest_invoker() src/test/blockencodings_tests.cpp:55:1
17    [#11](/bitcoin-bitcoin/11/) 0x557d714a7e68 in boost::detail::function::void_function_invoker0<void (*)(), void>::invoke(boost::detail::function::function_buffer&) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/function/function_template.hpp:117:11
18    [#12](/bitcoin-bitcoin/12/) 0x557d7412da09 in boost::function0<void>::operator()() const /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_77_0-7494ab49d6b/./boost/function/function_template.hpp:763:14
19    [#13](/bitcoin-bitcoin/13/) 0x557d7412da09 in boost::detail::forward::operator()() /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_77_0-7494ab49d6b/./boost/test/impl/execution_monitor.ipp:1388:32
20    [#14](/bitcoin-bitcoin/14/) 0x557d7412da09 in boost::detail::function::function_obj_invoker0<boost::detail::forward, int>::invoke(boost::detail::function::function_buffer&) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_77_0-7494ab49d6b/./boost/function/function_template.hpp:137:18
21    [#15](/bitcoin-bitcoin/15/) 0x557d74121952 in boost::function0<int>::operator()() const /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_77_0-7494ab49d6b/./boost/function/function_template.hpp:763:14
22    [#16](/bitcoin-bitcoin/16/) 0x557d74121952 in int boost::detail::do_invoke<boost::shared_ptr<boost::detail::translator_holder_base>, boost::function<int ()> >(boost::shared_ptr<boost::detail::translator_holder_base> const&, boost::function<int ()> const&) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_77_0-7494ab49d6b/./boost/test/impl/execution_monitor.ipp:301:30
23    [#17](/bitcoin-bitcoin/17/) 0x557d74121952 in boost::execution_monitor::catch_signals(boost::function<int ()> const&) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_77_0-7494ab49d6b/./boost/test/impl/execution_monitor.ipp:903:16
24    [#18](/bitcoin-bitcoin/18/) 0x557d74121d1f in boost::execution_monitor::execute(boost::function<int ()> const&) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_77_0-7494ab49d6b/./boost/test/impl/execution_monitor.ipp:1301:16
25    [#19](/bitcoin-bitcoin/19/) 0x557d741257b9 in boost::execution_monitor::vexecute(boost::function<void ()> const&) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_77_0-7494ab49d6b/./boost/test/impl/execution_monitor.ipp:1397:5
26    [#20](/bitcoin-bitcoin/20/) 0x557d7404de12 in boost::unit_test::unit_test_monitor_t::execute_and_translate(boost::function<void ()> const&, unsigned long) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_77_0-7494ab49d6b/./boost/test/impl/unit_test_monitor.ipp:49:9
27    [#21](/bitcoin-bitcoin/21/) 0x557d73fc9bec in boost::unit_test::framework::state::execute_test_tree(unsigned long, unsigned long, boost::unit_test::framework::state::random_generator_helper const*) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_77_0-7494ab49d6b/./boost/test/impl/framework.ipp:815:44
28    [#22](/bitcoin-bitcoin/22/) 0x557d73fcae83 in boost::unit_test::framework::state::execute_test_tree(unsigned long, unsigned long, boost::unit_test::framework::state::random_generator_helper const*) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_77_0-7494ab49d6b/./boost/test/impl/framework.ipp:784:58
29    [#23](/bitcoin-bitcoin/23/) 0x557d73fcae83 in boost::unit_test::framework::state::execute_test_tree(unsigned long, unsigned long, boost::unit_test::framework::state::random_generator_helper const*) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_77_0-7494ab49d6b/./boost/test/impl/framework.ipp:784:58
30    [#24](/bitcoin-bitcoin/24/) 0x557d73fa8649 in boost::unit_test::framework::run(unsigned long, bool) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_77_0-7494ab49d6b/./boost/test/impl/framework.ipp:1721:29
31    [#25](/bitcoin-bitcoin/25/) 0x557d74049d33 in boost::unit_test::unit_test_main(boost::unit_test::test_suite* (*)(int, char**), int, char**) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_77_0-7494ab49d6b/./boost/test/impl/unit_test_main.ipp:250:9
32    [#26](/bitcoin-bitcoin/26/) 0x557d7404ab60 in main /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_77_0-7494ab49d6b/./boost/test/impl/unit_test_main.ipp:306:12
33    [#27](/bitcoin-bitcoin/27/) 0x7fb7ba33efcf  (/lib/x86_64-linux-gnu/libc.so.6+0x2dfcf)
34    [#28](/bitcoin-bitcoin/28/) 0x7fb7ba33f07c in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2e07c)
35    [#29](/bitcoin-bitcoin/29/) 0x557d712f2914 in _start (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/test_bitcoin+0x15d914)

    https://cirrus-ci.com/task/6714264523112448

  37. PastaPastaPasta force-pushed on Feb 12, 2022
  38. PastaPastaPasta commented at 8:06 am on February 12, 2022: contributor
    Done, rebased, and applied suggestion. (am out and about atm, so am not able to build depends locally)
  39. fanquake commented at 8:17 am on February 12, 2022: member
    The second commit needs to be squashed, otherwise depends wont build in ce77c4baed0d0da1f21670a443da6037af4fa7f1. You need to fixup the PR description, remove all the struck-through text etc. You can also remove the portion about a --enable-c++20 flag, as that PR already exists. You should also add why 1.77.0 is actually required to use c++20.
  40. build: upgrade depends Boost to 1.77 
    remove now unneeded suppression

build(depends): drop fix_openbsd_test_lib.patch
    1666e1269e
  41. PastaPastaPasta force-pushed on Feb 12, 2022
  42. PastaPastaPasta commented at 10:49 am on February 12, 2022: contributor
    Squashed, and updated PR description. I don’t really have a desire to re-compile using our current boost / boost 1.72 with c++20 to determine why it failed, but boost 1.73 was the earliest that bitcoin core would compile with when using c++20
  43. fanquake removed the label Needs Conceptual Review on Feb 12, 2022
  44. fanquake added the label DrahtBot Guix build requested on Feb 12, 2022
  45. DrahtBot added the label Needs rebase on Feb 13, 2022
  46. DrahtBot commented at 1:18 pm on February 13, 2022: member

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

  47. fanquake commented at 10:52 am on February 14, 2022: member
    This needs rebasing past #24276 and #24301. Unless there’s a reason not too, this could now also be Boost 1.78.0.
  48. MarcoFalke removed the label DrahtBot Guix build requested on Feb 18, 2022
  49. fanquake commented at 2:40 pm on February 18, 2022: member
    I’ve rebased this in #24383.
  50. fanquake closed this on Feb 18, 2022
  51. laanwj referenced this in commit 0a76bf848c on Feb 23, 2022
  52. sidhujag referenced this in commit 0cd8cb656f on Feb 24, 2022
  53. DrahtBot locked this on Feb 18, 2023


PastaPastaPasta DrahtBot MarcoFalke fanquake hebasto dougEfresh

Labels
Build system Needs rebase

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-06-26 13:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me