build: Drop unneeded dependencies for bitcoin-wallet tool

hebasto commented at 2:25 pm on October 24, 2021: member

bitcoin-wallet is an offline tool, and its code does not depend on networking stuff (ZMQ, UPnP, NAT-PMP, and LIBBITCOIN_SERVER).

Also bitcoin-wallet does not interacts with the chainstate, therefore dependency on LevelDB is not needed.

DrahtBot added the label Build system on Oct 24, 2021

DrahtBot commented at 5:33 am on October 26, 2021: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#10102 (Multiprocess bitcoin by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

theStack commented at 0:12 am on October 29, 2021: member

Concept ACK

luke-jr commented at 4:55 pm on October 29, 2021: member

Doesn’t this also need configure changes to allow building it without unnecessary deps? (Possibly could be a followup PR, but fits here)

hebasto force-pushed on Oct 31, 2021

hebasto commented at 5:44 pm on October 31, 2021: member

Updated 1d96788ce97f3dcfbe326652c0d6204624dbb783 -> 347774b86c8e451300c9487d8c350ebdb0df2f86 (pr23345.01 -> pr23345.02, diff):

addressed @luke-jr’s comment:

Doesn’t this also need configure changes to allow building it without unnecessary deps?

hebasto commented at 10:15 am on November 1, 2021: member

Guix builds:

 0$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 1f3e5d495458d3347503f3446b6810b75bc519c5508986f5225e1ee8e3187aead  guix-build-347774b86c8e/output/aarch64-linux-gnu/SHA256SUMS.part
 26d8dcea67a1295cf04f121697779fb1158e74fed6ec317cd81f0e5a10f82d532  guix-build-347774b86c8e/output/aarch64-linux-gnu/bitcoin-347774b86c8e-aarch64-linux-gnu-debug.tar.gz
 3c18359b4048a113d984d3a1bf67d19c25d9b27513f5b112e8359289f6d3ca907  guix-build-347774b86c8e/output/aarch64-linux-gnu/bitcoin-347774b86c8e-aarch64-linux-gnu.tar.gz
 48cb85a9815cd5046aa38db22bd8593d5e09ffa09935a7008dda722174aa4343b  guix-build-347774b86c8e/output/arm-linux-gnueabihf/SHA256SUMS.part
 5cf549a6d76361be67f40acb227e29c1cd1503bf71c750a80c18cb8f99945085d  guix-build-347774b86c8e/output/arm-linux-gnueabihf/bitcoin-347774b86c8e-arm-linux-gnueabihf-debug.tar.gz
 69b15e710313cefa6e2e9ee7ac7d7945b55399c6ac2ba73a24565393fb1eceded  guix-build-347774b86c8e/output/arm-linux-gnueabihf/bitcoin-347774b86c8e-arm-linux-gnueabihf.tar.gz
 79bd9aecf8c6f47e04812a2604bdbd59b51a4982f2a9665ecae3d8ed4ad174ac2  guix-build-347774b86c8e/output/dist-archive/bitcoin-347774b86c8e.tar.gz
 8d3021be3d52aac1578839361baa657175f2f95a6a29db149b14782ad7321051b  guix-build-347774b86c8e/output/powerpc64-linux-gnu/SHA256SUMS.part
 98087e54dc2123f68ef0be25035a759b32e30bc986c371566636227c500748af2  guix-build-347774b86c8e/output/powerpc64-linux-gnu/bitcoin-347774b86c8e-powerpc64-linux-gnu-debug.tar.gz
104d48a90cd9946d76f3f27ce258f2d693b6e5b9aa35d5027b9f599d8ad6e95245  guix-build-347774b86c8e/output/powerpc64-linux-gnu/bitcoin-347774b86c8e-powerpc64-linux-gnu.tar.gz
11d8bbf33587375528e26ec199242d94a198e59803f496abcf61de0a2ebccbdf02  guix-build-347774b86c8e/output/powerpc64le-linux-gnu/SHA256SUMS.part
122a2eecd98b92f90137cc9f6c309999b369c1bf7de725d91c345b5efe6c46b801  guix-build-347774b86c8e/output/powerpc64le-linux-gnu/bitcoin-347774b86c8e-powerpc64le-linux-gnu-debug.tar.gz
13d7405a053343d63882d3fd67ae216bf90c3f41c09220e4703bf0badd30850863  guix-build-347774b86c8e/output/powerpc64le-linux-gnu/bitcoin-347774b86c8e-powerpc64le-linux-gnu.tar.gz
148514715838bf9564479dc159a7f0c33fa764deb1ff017593554f37af5da3df09  guix-build-347774b86c8e/output/riscv64-linux-gnu/SHA256SUMS.part
15a675d706bec9a78fce3062db293501ac787e05aa606d41c3836dc5bf3a47a8ef  guix-build-347774b86c8e/output/riscv64-linux-gnu/bitcoin-347774b86c8e-riscv64-linux-gnu-debug.tar.gz
16d27910d10af4d0515d5d1568bf289ef0d9aff954d1410d0c695322a36fb3f9a0  guix-build-347774b86c8e/output/riscv64-linux-gnu/bitcoin-347774b86c8e-riscv64-linux-gnu.tar.gz
17a8445bb3a96cb57de9369722092a887843afd58747dca1a2442529bced039a32  guix-build-347774b86c8e/output/x86_64-apple-darwin19/SHA256SUMS.part
18c3cc41b10cbd6caf3faa9ef2a6d537f2401df5daaea40a907315fd7ee4243d6d  guix-build-347774b86c8e/output/x86_64-apple-darwin19/bitcoin-347774b86c8e-osx-unsigned.dmg
1997c94bf214a40f86a71fb5860142ab08e2a8e21dd4278abe8abd4aa6a92664c2  guix-build-347774b86c8e/output/x86_64-apple-darwin19/bitcoin-347774b86c8e-osx-unsigned.tar.gz
20f9d73b98b424b0e4ece233759d19370452dbbe50e635a13ede2c2a93e737c284  guix-build-347774b86c8e/output/x86_64-apple-darwin19/bitcoin-347774b86c8e-osx64.tar.gz
21eebf4699ef0a9971a2f44ccd996a696e163b8536a7f17ee9fa6de7f2dfc434f9  guix-build-347774b86c8e/output/x86_64-linux-gnu/SHA256SUMS.part
2252736eddc2b240d8a666f251264bc83a1c3f73ce6c0de0a353263f3fb8e4baad  guix-build-347774b86c8e/output/x86_64-linux-gnu/bitcoin-347774b86c8e-x86_64-linux-gnu-debug.tar.gz
23fec9b38aad06b47797f458fb97571d49dbce17f2023fee60517600f16ef352fd  guix-build-347774b86c8e/output/x86_64-linux-gnu/bitcoin-347774b86c8e-x86_64-linux-gnu.tar.gz
24120a64e96ff9312212d29b7894e049f734e349d58b4424a40a0dbf1a81ef9f63  guix-build-347774b86c8e/output/x86_64-w64-mingw32/SHA256SUMS.part
2566f22e1abc8278df1a2c31e97adb97567267b7f1df9fe3c54d497e8cadeda620  guix-build-347774b86c8e/output/x86_64-w64-mingw32/bitcoin-347774b86c8e-win-unsigned.tar.gz
2628cd8f5f87bb27811d9d32542c93b3d343f84a39c20fa2cd0fc5f24ccd3bd924  guix-build-347774b86c8e/output/x86_64-w64-mingw32/bitcoin-347774b86c8e-win64-debug.zip
27e9f4fed1b34dc6bec4130a40d62aa9bb1d02bee29a93a92c25a2278ae88d0c14  guix-build-347774b86c8e/output/x86_64-w64-mingw32/bitcoin-347774b86c8e-win64-setup-unsigned.exe
28cef9f80f3a6541b66054068d244e64b49f13106f92099fe78d889e422e5bab21  guix-build-347774b86c8e/output/x86_64-w64-mingw32/bitcoin-347774b86c8e-win64.zip

jarolrod commented at 3:57 pm on November 2, 2021: member

contributing GUIX hashes, mine match @hebasto

 0find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 1
 2f3e5d495458d3347503f3446b6810b75bc519c5508986f5225e1ee8e3187aead  guix-build-347774b86c8e/output/aarch64-linux-gnu/SHA256SUMS.part
 36d8dcea67a1295cf04f121697779fb1158e74fed6ec317cd81f0e5a10f82d532  guix-build-347774b86c8e/output/aarch64-linux-gnu/bitcoin-347774b86c8e-aarch64-linux-gnu-debug.tar.gz
 4c18359b4048a113d984d3a1bf67d19c25d9b27513f5b112e8359289f6d3ca907  guix-build-347774b86c8e/output/aarch64-linux-gnu/bitcoin-347774b86c8e-aarch64-linux-gnu.tar.gz
 58cb85a9815cd5046aa38db22bd8593d5e09ffa09935a7008dda722174aa4343b  guix-build-347774b86c8e/output/arm-linux-gnueabihf/SHA256SUMS.part
 6cf549a6d76361be67f40acb227e29c1cd1503bf71c750a80c18cb8f99945085d  guix-build-347774b86c8e/output/arm-linux-gnueabihf/bitcoin-347774b86c8e-arm-linux-gnueabihf-debug.tar.gz
 79b15e710313cefa6e2e9ee7ac7d7945b55399c6ac2ba73a24565393fb1eceded  guix-build-347774b86c8e/output/arm-linux-gnueabihf/bitcoin-347774b86c8e-arm-linux-gnueabihf.tar.gz
 89bd9aecf8c6f47e04812a2604bdbd59b51a4982f2a9665ecae3d8ed4ad174ac2  guix-build-347774b86c8e/output/dist-archive/bitcoin-347774b86c8e.tar.gz
 9d3021be3d52aac1578839361baa657175f2f95a6a29db149b14782ad7321051b  guix-build-347774b86c8e/output/powerpc64-linux-gnu/SHA256SUMS.part
108087e54dc2123f68ef0be25035a759b32e30bc986c371566636227c500748af2  guix-build-347774b86c8e/output/powerpc64-linux-gnu/bitcoin-347774b86c8e-powerpc64-linux-gnu-debug.tar.gz
114d48a90cd9946d76f3f27ce258f2d693b6e5b9aa35d5027b9f599d8ad6e95245  guix-build-347774b86c8e/output/powerpc64-linux-gnu/bitcoin-347774b86c8e-powerpc64-linux-gnu.tar.gz
12d8bbf33587375528e26ec199242d94a198e59803f496abcf61de0a2ebccbdf02  guix-build-347774b86c8e/output/powerpc64le-linux-gnu/SHA256SUMS.part
132a2eecd98b92f90137cc9f6c309999b369c1bf7de725d91c345b5efe6c46b801  guix-build-347774b86c8e/output/powerpc64le-linux-gnu/bitcoin-347774b86c8e-powerpc64le-linux-gnu-debug.tar.gz
14d7405a053343d63882d3fd67ae216bf90c3f41c09220e4703bf0badd30850863  guix-build-347774b86c8e/output/powerpc64le-linux-gnu/bitcoin-347774b86c8e-powerpc64le-linux-gnu.tar.gz
158514715838bf9564479dc159a7f0c33fa764deb1ff017593554f37af5da3df09  guix-build-347774b86c8e/output/riscv64-linux-gnu/SHA256SUMS.part
16a675d706bec9a78fce3062db293501ac787e05aa606d41c3836dc5bf3a47a8ef  guix-build-347774b86c8e/output/riscv64-linux-gnu/bitcoin-347774b86c8e-riscv64-linux-gnu-debug.tar.gz
17d27910d10af4d0515d5d1568bf289ef0d9aff954d1410d0c695322a36fb3f9a0  guix-build-347774b86c8e/output/riscv64-linux-gnu/bitcoin-347774b86c8e-riscv64-linux-gnu.tar.gz
18a8445bb3a96cb57de9369722092a887843afd58747dca1a2442529bced039a32  guix-build-347774b86c8e/output/x86_64-apple-darwin19/SHA256SUMS.part
19c3cc41b10cbd6caf3faa9ef2a6d537f2401df5daaea40a907315fd7ee4243d6d  guix-build-347774b86c8e/output/x86_64-apple-darwin19/bitcoin-347774b86c8e-osx-unsigned.dmg
2097c94bf214a40f86a71fb5860142ab08e2a8e21dd4278abe8abd4aa6a92664c2  guix-build-347774b86c8e/output/x86_64-apple-darwin19/bitcoin-347774b86c8e-osx-unsigned.tar.gz
21f9d73b98b424b0e4ece233759d19370452dbbe50e635a13ede2c2a93e737c284  guix-build-347774b86c8e/output/x86_64-apple-darwin19/bitcoin-347774b86c8e-osx64.tar.gz
22eebf4699ef0a9971a2f44ccd996a696e163b8536a7f17ee9fa6de7f2dfc434f9  guix-build-347774b86c8e/output/x86_64-linux-gnu/SHA256SUMS.part
2352736eddc2b240d8a666f251264bc83a1c3f73ce6c0de0a353263f3fb8e4baad  guix-build-347774b86c8e/output/x86_64-linux-gnu/bitcoin-347774b86c8e-x86_64-linux-gnu-debug.tar.gz
24fec9b38aad06b47797f458fb97571d49dbce17f2023fee60517600f16ef352fd  guix-build-347774b86c8e/output/x86_64-linux-gnu/bitcoin-347774b86c8e-x86_64-linux-gnu.tar.gz
25120a64e96ff9312212d29b7894e049f734e349d58b4424a40a0dbf1a81ef9f63  guix-build-347774b86c8e/output/x86_64-w64-mingw32/SHA256SUMS.part
2666f22e1abc8278df1a2c31e97adb97567267b7f1df9fe3c54d497e8cadeda620  guix-build-347774b86c8e/output/x86_64-w64-mingw32/bitcoin-347774b86c8e-win-unsigned.tar.gz
2728cd8f5f87bb27811d9d32542c93b3d343f84a39c20fa2cd0fc5f24ccd3bd924  guix-build-347774b86c8e/output/x86_64-w64-mingw32/bitcoin-347774b86c8e-win64-debug.zip
28e9f4fed1b34dc6bec4130a40d62aa9bb1d02bee29a93a92c25a2278ae88d0c14  guix-build-347774b86c8e/output/x86_64-w64-mingw32/bitcoin-347774b86c8e-win64-setup-unsigned.exe
29cef9f80f3a6541b66054068d244e64b49f13106f92099fe78d889e422e5bab21  guix-build-347774b86c8e/output/x86_64-w64-mingw32/bitcoin-347774b86c8e-win64.zip

in configure.ac:1355 in 347774b86c outdated

1335@@ -1336,6 +1336,15 @@ if test x$use_ebpf != xno; then
1336   )
1337 fi
1338 
1339+build_leveldb=yes
1340+if test x$build_bitcoin_cli$build_bitcoin_tx$build_bitcoin_util$build_bitcoind$bitcoin_enable_qt$use_bench$use_tests = xnonononononono; then

luke-jr commented at 5:34 pm on November 2, 2021:

I guess we should only be checking bitcoind/bitcoin-qt here (the other tools don’t need them either?), but perhaps that’s safer left for a later PR…

hebasto commented at 5:38 pm on November 2, 2021:

You read my mind :)

luke-jr commented at 10:21 pm on January 12, 2022:

Followup in #24051

luke-jr referenced this in commit 03560deaac on Nov 4, 2021

in src/Makefile.am:860 in 347774b86c outdated

851@@ -841,8 +852,11 @@ nodist_libbitcoin_ipc_a_SOURCES = $(libbitcoin_ipc_mpgen_output)
852 CLEANFILES += $(libbitcoin_ipc_mpgen_output)
853 endif
854 
855+if BUILD_LEVELDB
856 include Makefile.crc32c.include

laanwj commented at 6:12 pm on November 10, 2021:

I don’t understand why an explicit conditional is needed here. Shouldn’t make be able to figure out for itself whether these libraries need to be built?

hebasto commented at 6:19 pm on November 10, 2021:

Shouldn’t make be able to figure out for itself whether these libraries need to be built?

Yes, it should.

I don’t understand why an explicit conditional is needed here.

It is not needed. It’s an optimization – not processing unused Makefile.*.include files.

hebasto commented at 7:38 pm on November 13, 2021:

Updated.

laanwj commented at 3:25 pm on November 15, 2021:

Thanks. Yes, I don’t think this was worth special-case optimizing, parsing performance of make is hardly an issue on modern systems afaik.

DrahtBot added the label Needs rebase on Nov 12, 2021

build: Drop unneeded dependencies for bitcoin-wallet tool 4fe7cf1677

hebasto force-pushed on Nov 13, 2021

hebasto commented at 7:37 pm on November 13, 2021: member

Updated 347774b86c8e451300c9487d8c350ebdb0df2f86 -> 4fe7cf167796015c0f24e740f81a2452e3996a92 (pr23345.02 -> pr23345.03):

rebased due to the conflict with #23114
addressed @laanwj’s comment

DrahtBot removed the label Needs rebase on Nov 13, 2021

hebasto commented at 8:31 am on November 14, 2021: member

Guix builds:

 0$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 1f752d99d15d59e3a70a54cf73dd0d28c6f602a9c82f5303695618038e9370d77  guix-build-4fe7cf167796/output/aarch64-linux-gnu/SHA256SUMS.part
 25857cc54913ab34737e269c2fd9ad29d32138f28436e11071bacf82f98d6c927  guix-build-4fe7cf167796/output/aarch64-linux-gnu/bitcoin-4fe7cf167796-aarch64-linux-gnu-debug.tar.gz
 35d102280651e764d0f23cae6884813bf4f073ddbd966145a0fe56b2f560fae5d  guix-build-4fe7cf167796/output/aarch64-linux-gnu/bitcoin-4fe7cf167796-aarch64-linux-gnu.tar.gz
 476f5453432a0c5d770034b40253ccbe17aa21e2c5dde30131c181988da21ad00  guix-build-4fe7cf167796/output/arm-linux-gnueabihf/SHA256SUMS.part
 5d8919579f061548f31588d3f519859ca1cfb8e92f7a627444218211be9f51972  guix-build-4fe7cf167796/output/arm-linux-gnueabihf/bitcoin-4fe7cf167796-arm-linux-gnueabihf-debug.tar.gz
 63b30509b9deaff2a4ff63483afcc8b2418fc338ce962176cc4c4ed2cb6329c79  guix-build-4fe7cf167796/output/arm-linux-gnueabihf/bitcoin-4fe7cf167796-arm-linux-gnueabihf.tar.gz
 7244807167e14aff56d411028149afdc5ed052cb1ed4752ef6801158e3914961b  guix-build-4fe7cf167796/output/dist-archive/bitcoin-4fe7cf167796.tar.gz
 84ced3674771be8c6f32d49e97511c6fd41c7f7f36412905f7e39d3e7e102663e  guix-build-4fe7cf167796/output/powerpc64-linux-gnu/SHA256SUMS.part
 9441b7fdcd38af2df3ecb44973b97b5011b09f7a01a69933bba01900073c9290e  guix-build-4fe7cf167796/output/powerpc64-linux-gnu/bitcoin-4fe7cf167796-powerpc64-linux-gnu-debug.tar.gz
10697e0242b199370b6779f287dc38c988fb7e0ac09c89ab918daf7536fcb82d22  guix-build-4fe7cf167796/output/powerpc64-linux-gnu/bitcoin-4fe7cf167796-powerpc64-linux-gnu.tar.gz
11c472ad36c754a8f7b446e687a7c214b411d55518991b25e058740fac3de2955a  guix-build-4fe7cf167796/output/powerpc64le-linux-gnu/SHA256SUMS.part
12ee7eced6de534bd8fc50318436f0c73340ae0351f7e53073798b1999372f7c79  guix-build-4fe7cf167796/output/powerpc64le-linux-gnu/bitcoin-4fe7cf167796-powerpc64le-linux-gnu-debug.tar.gz
1310abd0d49cb679ce49f009dff904f8210473f89b0a3299a9759f9545a40725d8  guix-build-4fe7cf167796/output/powerpc64le-linux-gnu/bitcoin-4fe7cf167796-powerpc64le-linux-gnu.tar.gz
1421ba0c48fd660f7bb053fa09a97a888d764ee40eef26043e15682662f7e98e10  guix-build-4fe7cf167796/output/riscv64-linux-gnu/SHA256SUMS.part
1546ccd9b042fffe532bbe7352c728aade6218444ade11a816d8a8e42ca3ad11eb  guix-build-4fe7cf167796/output/riscv64-linux-gnu/bitcoin-4fe7cf167796-riscv64-linux-gnu-debug.tar.gz
16dd3a4e562f54a97c94c8b9be59aa123479d592cb2a08aa810df11a605a58b7bd  guix-build-4fe7cf167796/output/riscv64-linux-gnu/bitcoin-4fe7cf167796-riscv64-linux-gnu.tar.gz
176babf3b6a30d193f282dedefe94270ee286d9af5553fac3e6eb79391cf4e3cc0  guix-build-4fe7cf167796/output/x86_64-apple-darwin19/SHA256SUMS.part
18eebcb0353d443ebfaea0ae1a78785205f1df57589e53c5d206a4ae8e1362ea76  guix-build-4fe7cf167796/output/x86_64-apple-darwin19/bitcoin-4fe7cf167796-osx-unsigned.dmg
192f8a09f1685bbead1cd26ac1f5037abee7efced27569f0f7c4fa39e852ebafca  guix-build-4fe7cf167796/output/x86_64-apple-darwin19/bitcoin-4fe7cf167796-osx-unsigned.tar.gz
2029c4084fa88cd8bdcb13687f43f36c2ee5cadd672bbdb9a55c051158baa74179  guix-build-4fe7cf167796/output/x86_64-apple-darwin19/bitcoin-4fe7cf167796-osx64.tar.gz
212726aabb3e3ed9abd96da90f926aee9af5ccd4aeb1a27e94f67c55a94a121c08  guix-build-4fe7cf167796/output/x86_64-linux-gnu/SHA256SUMS.part
2221712e64b021ee37621ec275e622999320a295533dc9b28c75702cce0a186ccd  guix-build-4fe7cf167796/output/x86_64-linux-gnu/bitcoin-4fe7cf167796-x86_64-linux-gnu-debug.tar.gz
23f3f12e3fddf40660f2b6552eae1056897c837d4bcaa2e11835eb92055badc320  guix-build-4fe7cf167796/output/x86_64-linux-gnu/bitcoin-4fe7cf167796-x86_64-linux-gnu.tar.gz
2484ad8907b64861c14c9635e93931d1f96c6690fb30ea029739d3107f6e7276c9  guix-build-4fe7cf167796/output/x86_64-w64-mingw32/SHA256SUMS.part
2517c3e66ad6ac39a663121d4cdb6f9e37a098755a1dcaf770569ef018f7d5b796  guix-build-4fe7cf167796/output/x86_64-w64-mingw32/bitcoin-4fe7cf167796-win-unsigned.tar.gz
2669f86bac1aba6742a3840256960feab3c14bd878517e714c7663c2c68c205c5e  guix-build-4fe7cf167796/output/x86_64-w64-mingw32/bitcoin-4fe7cf167796-win64-debug.zip
2787af79229a21d407f68845767d420e8521d73e1103dae6359d846e6c070251ec  guix-build-4fe7cf167796/output/x86_64-w64-mingw32/bitcoin-4fe7cf167796-win64-setup-unsigned.exe
28ee3a184ecbec4983e7bbdff29ab0ec46f7872f60f735df59984be141c516c215  guix-build-4fe7cf167796/output/x86_64-w64-mingw32/bitcoin-4fe7cf167796-win64.zip

laanwj commented at 3:28 pm on November 15, 2021: member

Code review ACK 4fe7cf167796015c0f24e740f81a2452e3996a92

laanwj merged this on Nov 15, 2021

laanwj closed this on Nov 15, 2021

hebasto deleted the branch on Nov 15, 2021

fanquake referenced this in commit 4766cd1981 on Oct 31, 2022

DrahtBot locked this on Jan 12, 2023

build: Drop unneeded dependencies for bitcoin-wallet tool #23345

Conflicts

Guix builds:

Guix builds: