As with #23345, these other tools likewise don't use various deps.
Bugfix: configure: bitcoin-{cli,tx,util} don't need UPnP, NAT-PMP, or ZMQ #24051
pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:config_utils_drop_extra_deps changing 1 files +1 −1-
luke-jr commented at 10:21 PM on January 12, 2022: member
-
Bugfix: configure: bitcoin-{cli,tx,util} don't need UPnP, NAT-PMP, or ZMQ 98868633d1
- DrahtBot added the label Build system on Jan 13, 2022
-
hebasto commented at 7:55 AM on January 13, 2022: member
Concept ACK
Tested 98868633d1d5cd2591b9613545bd2ce2e81af212 with
-without-daemon -without-gui -disable-tests -disable-benchconfigure options.Are UPnP or NAT-PMP required for tests and benchmarks?
-
DrahtBot commented at 12:19 PM on March 31, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
No conflicts as of last run.
-
laanwj commented at 7:47 AM on April 14, 2022: member
Are UPnP or NAT-PMP required for tests and benchmarks?
I don't think there's any tests and benchmarks for UPnP or NATPMP related code right now, but there could potentially be.
- achow101 requested review from fanquake on Oct 12, 2022
-
achow101 commented at 10:38 PM on October 25, 2022: member
ACK 98868633d1d5cd2591b9613545bd2ce2e81af212
- fanquake referenced this in commit 4766cd1981 on Oct 31, 2022
-
DrahtBot commented at 1:06 PM on October 31, 2022: contributor
<!--cf906140f33d8803c4a75a2196329ecb-->
🐙 This pull request conflicts with the target branch and needs rebase.
- DrahtBot added the label Needs rebase on Oct 31, 2022
- fanquake closed this on Oct 31, 2022
-
fanquake commented at 1:06 PM on October 31, 2022: member
This was merged.
- sidhujag referenced this in commit ea7e0fab2a on Oct 31, 2022
- bitcoin locked this on Oct 31, 2023