test: Add ios_base::width tsan suppression #23370

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:211027-tsan-cout changing 1 files +3 −0
  1. hebasto commented at 8:44 am on October 27, 2021: member

    This PR:

    • adds tsan suppression for intermittent failures in CI
    0SUMMARY: ThreadSanitizer: data race /usr/lib/llvm-12/bin/../include/c++/v1/ios:523:12 in std::__1::ios_base::width() const
    
  2. test: Add ios_base::width tsan suppression 96c7db9373
  3. hebasto added the label Tests on Oct 27, 2021
  4. shaavan commented at 12:26 pm on October 27, 2021: contributor

    Concept ACK

    TSan suppression looks like the right thing to do for now. But as @ryanofsky mentioned here, we have to take a look into the source of this error and make sure that suppressing this error might not cause a significant problem in the future.

  5. laanwj commented at 12:18 pm on November 10, 2021: member
    Concept and code review ACK 96c7db9373014ce232ab01d11333650c9ddf9ee5 (I think adding a surpression deep inside the C++ library is somewhat scary, but the explanation in @ryanofsky ’s comment makes it clearer)
  6. laanwj merged this on Nov 10, 2021
  7. laanwj closed this on Nov 10, 2021

  8. hebasto deleted the branch on Nov 10, 2021
  9. sidhujag referenced this in commit 6d02f3b61f on Nov 10, 2021
  10. DrahtBot locked this on Nov 10, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-03 13:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me