This PR:
- adds tsan suppression for intermittent failures in CI
SUMMARY: ThreadSanitizer: data race /usr/lib/llvm-12/bin/../include/c++/v1/ios:523:12 in std::__1::ios_base::width() const
- fixes #23366
test: Add ios_base::width tsan suppression #23370
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:211027-tsan-cout changing 1 files +3 −0-
hebasto commented at 8:44 AM on October 27, 2021: member
-
test: Add ios_base::width tsan suppression 96c7db9373
- hebasto added the label Tests on Oct 27, 2021
-
shaavan commented at 12:26 PM on October 27, 2021: contributor
Concept ACK
TSan suppression looks like the right thing to do for now. But as @ryanofsky mentioned here, we have to take a look into the source of this error and make sure that suppressing this error might not cause a significant problem in the future.
-
laanwj commented at 12:18 PM on November 10, 2021: member
Concept and code review ACK 96c7db9373014ce232ab01d11333650c9ddf9ee5 (I think adding a surpression deep inside the C++ library is somewhat scary, but the explanation in @ryanofsky 's comment makes it clearer)
- laanwj merged this on Nov 10, 2021
- laanwj closed this on Nov 10, 2021
- hebasto deleted the branch on Nov 10, 2021
- sidhujag referenced this in commit 6d02f3b61f on Nov 10, 2021
- DrahtBot locked this on Nov 10, 2022
