p2p: fix regression in AddrManImpl::AddSingle() #23434

pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:fix-regression-in-AddrManImpl-AddSingle changing 1 files +3 −1

jonatack commented at 7:47 PM on November 3, 2021: member

Hopefully fixes the addrman unit test failures that appear to have been introduced in commit 2095df7b "Add Add_() inner function, fix Add() return semantics" of PR #23380, which was merged in 994aaaa8.

That commit removed the bool fNew logic from AddSingle() and replaced it with returning fInsert. This patch brings back the fNew logic and combines it with fInsert, so AddSingle() returns whether or not fNew and fInsert are both true.

Labelling this as a draft while I catch up on review of the recent changes.

Tentatively closes #23433.

p2p: fix regression in AddrManImpl::AddSingle()

Hopefully fixes new addrman unit test failures that
appear to have been introduced in commit 2095df7b
"Add Add_() inner function, fix Add() return semantics"
of PR #23380, which was merged in 994aaaa8.

That commit removed the bool fNew logic from AddSingle()
and replaced it with returning fInsert. This patch brings back
the fNew logic and combines it with fInsert, so AddSingle()
returns whether or not fNew and fInsert are both true.

cb8959af71

jonatack marked this as a draft on Nov 3, 2021
jonatack closed this on Nov 3, 2021
DrahtBot locked this on Nov 3, 2022

Contributors

jonatack

Linked (view graph)

#23380 addrman: Fix AddrMan::Add() return semantics and logging #23433 Addrman unit test failures