fuzz: Add regression test for wallet crash #23444

1. 
   maflcko commented at 4:36 pm on November 5, 2021: member

   This adds a regression fuzz test for the bug fixed in commit 24abd8312ec1caa04f9b3bd92cd960e28ca91e17.

   Steps to test:

   0git show 0fbaef9676a1dcb84bcf95afd8d994831ab327b6 ./src/policy/feerate.cpp | git apply --reverse
   1# compile fuzz test ...
   2FUZZ=wallet_notifications ./src/test/fuzz/fuzz
   3# wait and observe crash ...
   

2. 
   maflcko commented at 4:37 pm on November 5, 2021: member

   Example crash: crash-6cd0f86f18ce0ec5b48beb59c602c8f807fe197a.bin.txt
3. 
   maflcko commented at 4:46 pm on November 5, 2021: member

   Be aware that the crash is currently non-deterministic. I presume because the wallet’s keys are non-deterministic (random). It might be a good idea to make the wallet generation deterministic for this fuzz test.
4. DrahtBot added the label Wallet on Nov 5, 2021
5. fuzz: Add regression test for wallet crash fa7cc0350c
6. maflcko force-pushed on Nov 10, 2021
7. maflcko removed the label Wallet on Nov 10, 2021
8. maflcko added the label Tests on Nov 10, 2021
9. maflcko added the label Wallet on Nov 10, 2021
10. 
    maflcko commented at 12:18 pm on November 10, 2021: member

    It might be a good idea to make the wallet generation deterministic for this fuzz test.

    Done

11. maflcko force-pushed on Nov 10, 2021
12. 
    jamesob commented at 1:09 pm on November 10, 2021: member

    Concept ACK - will review soon
13. fuzz: Make descriptor wallet test deterministic fa032325a7
14. maflcko force-pushed on Nov 10, 2021
15. 
    maflcko commented at 1:33 pm on November 10, 2021: member

    Ok, it is still not deterministic :disappointed: . Maybe the coin selection is too random?
16. 
    DrahtBot commented at 11:35 am on December 19, 2021: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #25218 (refactor: introduce generic ‘Result’ class and connect it to CreateTransaction and GetNewDestination by furszy)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

17. 
    achow101 commented at 10:09 pm on January 11, 2022: member

    Ok, it is still not deterministic disappointed . Maybe the coin selection is too random?

    It’s probably the random selection algorithm.

18. 
    fanquake commented at 2:48 pm on March 24, 2022: member

    Ok, it is still not deterministic 😞 . Maybe the coin selection is too random?

    Has this situation improved at all with recent coin selection changes?

19. DrahtBot added the label Needs rebase on Jul 12, 2022
20. 
    DrahtBot commented at 1:17 pm on July 12, 2022: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

21. 
    achow101 commented at 6:46 pm on October 12, 2022: member

    Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.
22. achow101 closed this on Oct 12, 2022

    ---

23. bitcoin locked this on Oct 12, 2023
24. maflcko deleted the branch on Nov 16, 2023

Contributors
maflcko jamesob DrahtBot achow101 fanquake

Labels
Wallet Tests Needs rebase