doc: Remove Boost build note from build-unix.md #23469

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:remove_boost_note changing 1 files +5 −14

fanquake commented at 11:55 PM on November 8, 2021: member

We don't have build instructions for any other dependency, and in any case, this isn't something we should maintain in our docs. If someone wants to know how to build Boost, or any other dependency, they can look at the relevant website / external build documentation.

doc: remove Boost build note from build-unix.md

We don't do this for any other dependency, and users are better looking
at the actual Boost site/docs. This isn't something we should need to
have in our build docs.

b97185812e

doc: remove redundant optionals from build-unix.md

Calling dependencies optional in a list of already optional dependencies
is redundant.

ea360d69e5

fanquake added the label Docs on Nov 8, 2021
shaavan commented at 4:16 AM on November 9, 2021: contributor
Concept ACK

It makes sense to remove Boost build notes, as:
1. As mentioned by @fanquake, build notes are not maintained for other libraries.
2. Building Boost yourself is not an immediate necessity to compiling bitcoin.
3. The official documentation of building boost is quite good and easy to follow through, so we don’t need to explain it on our docs.
However, removing Boost build notes intuitively kind of seems off to me. I would like to listen to other reviewers’ opinions before making a final decision.

As for removing unnecessary “optional,” I am ACK on that. Cheers!
jarolrod commented at 4:27 AM on November 9, 2021: member
ACK ea360d69e5fec8f96630354c4adc9df9dbab8329
- b97185812e6fa21461d1114c7e62a247cfa74ff9
  
  ACK because it's not something we need in our build notes
- ea360d69e5fec8f96630354c4adc9df9dbab8329
  
  Yep, this is redundant given the table title
DrahtBot commented at 5:25 AM on November 9, 2021: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #23470 (doc: consolidate legacy wallet documentation by fanquake)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
instagibbs commented at 7:04 AM on November 9, 2021: member

@shaavan no informed opinion myself but I'd flip the question: would you ACK the addition of these docs?
MarcoFalke commented at 8:22 AM on November 9, 2021: member

I think our recommended way to use dependencies is system packages or depends. I wasn't aware there is even a doc on how to build boost separately. And I am still not entirely sure why we have the build_bdb script, given that there is depends.

cr ACK
MarcoFalke commented at 8:24 AM on November 9, 2021: member

It looks like the note on building boost was added before the depends system.
MarcoFalke merged this on Nov 9, 2021
MarcoFalke closed this on Nov 9, 2021
fanquake deleted the branch on Nov 9, 2021
katesalazar commented at 10:16 AM on November 9, 2021: contributor

So QR is now required, right?
fanquake commented at 10:17 AM on November 9, 2021: member

So QR is now required, right?

No.
katesalazar commented at 12:35 PM on November 9, 2021: contributor

ACK.
katesalazar commented at 12:37 PM on November 9, 2021: contributor

Unless it's a recent thing, there's no need to bootstrap Boost as root.
sidhujag referenced this in commit a1048f3e3f on Nov 9, 2021
DrahtBot locked this on Nov 9, 2022

Contributors

Labels

doc: Remove Boost build note from build-unix.md #23469

Conflicts