scripted-diff: Move minisketchwrapper to src/node #23491

1. 
   MarcoFalke commented at 10:02 am on November 12, 2021: member

   The newly added wrapper is currently in the node library, but not placed in the node directory. While it is possible to use the wrapper outside of a node context (for example in a utility), it seems unlikely. Either way, I think the wrapper should either be moved to the util lib+dir or the node lib+dir, not something in-between.

   Also, fix incorrect comment BITCOIN_DBWRAPPER_H.

2. scripted-diff: Move minisketchwrapper to src/node

   -BEGIN VERIFY SCRIPT-
    # Move module
    git mv src/minisketchwrapper.cpp src/node/
    git mv src/minisketchwrapper.h   src/node/
    # Replacements
    sed -i 's:minisketchwrapper:node/minisketchwrapper:g'     $(git grep -l minisketchwrapper)
    sed -i 's:MINISKETCHWRAPPER_H:NODE_MINISKETCHWRAPPER_H:g' $(git grep -l MINISKETCHWRAPPER_H)
    sed -i 's:DBWRAPPER_H:NODE_MINISKETCHWRAPPER_H:g'         ./src/node/minisketchwrapper.h
   -END VERIFY SCRIPT-

   fa8f60e311
3. Sort file list after rename faba1abe46
4. MarcoFalke added the label Refactoring on Nov 12, 2021
5. 
   jnewbery commented at 12:44 pm on November 12, 2021: member

   Concept ACK. Code tree organization should reflect library organization.
6. 
   DrahtBot commented at 1:58 am on November 13, 2021: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #23517 (scripted-diff: Move miner to src/node by MarcoFalke)
   • #22362 (Drop only invalid entries when reading banlist.json by MarcoFalke)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. fanquake approved
8. 
   fanquake commented at 8:09 am on November 16, 2021: member

   ACK faba1abe469833b2dad01bac4e4d8a4ebb4bc97a. I saw the comment in #21515, however given there hasn’t been any new activity there, I’m going to merge this now.
9. fanquake merged this on Nov 16, 2021
10. fanquake closed this on Nov 16, 2021

    ---

11. MarcoFalke deleted the branch on Nov 16, 2021
12. sidhujag referenced this in commit d8e874af5d on Nov 16, 2021
13. DrahtBot locked this on Nov 17, 2022

Contributors
MarcoFalke jnewbery DrahtBot fanquake

Labels
Refactoring