The two options are mutually exclusive and will result in a test failure. Fix that.
Can be tested with:
$ ./test/functional/wallet_disable.py --valgrind
test: Force --nosandbox when --valgrind #23516
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2111-testValgrindNoSandbox changing 1 files +2 −2-
MarcoFalke commented at 12:29 PM on November 15, 2021: member
-
test: Force --nosandbox when --valgrind fa9c26ab3a
- DrahtBot added the label Tests on Nov 15, 2021
-
katesalazar commented at 9:02 PM on November 15, 2021: contributor
Let developers shoot themselves in their foot. It's part of the journey. NAK.
- fanquake approved
-
fanquake commented at 11:29 PM on November 15, 2021: member
ACK fa9c26ab3a09c843cb598d188162403bbf8c9b36
- fanquake merged this on Nov 15, 2021
- fanquake closed this on Nov 15, 2021
- sidhujag referenced this in commit ee9d4edeb8 on Nov 16, 2021
-
MarcoFalke commented at 7:49 AM on November 16, 2021: member
Let developers shoot themselves in their foot.
This pull request is not about footgunning. The goal is to avoid frustration when running the tests under valgrind.
If you want to shoot yourself into the foot, you can still do that after this pull request.
- MarcoFalke deleted the branch on Nov 16, 2021
- DrahtBot locked this on Nov 17, 2022
Contributors
Labels