ci: Rework ci task names (take 3) #23520

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2111-ciTaskNames changing 1 files +4 −4

MarcoFalke commented at 4:45 PM on November 15, 2021: member
It is hard to find a specific sanitizer task in less than a second. Fix that by mentioning the sanitizer first in the task name. Less useful information (with or without depends) follows the sanitizer.

Follow up to:
- #20545
- https://github.com/bitcoin/bitcoin/pull/20572
MarcoFalke force-pushed on Nov 15, 2021
DrahtBot added the label Tests on Nov 15, 2021
katesalazar commented at 9:09 PM on November 15, 2021: contributor

I understood 'sanitizers' when I had to. I would not have understood these 'Xsan' abbrevs. NAK.
in .cirrus.yml:223 in fa3af3be6c outdated
```
 219 | @@ -220,7 +220,7 @@ task:
 220 |      FILE_ENV: "./ci/test/00_setup_env_native_tsan.sh"
 221 |  
 222 |  task:
 223 | -  name: '[depends, sanitizers: memory (MSan)] [focal]'
```
fanquake commented at 2:36 AM on November 16, 2021:

Did you mean to drop depends here?

MarcoFalke commented at 7:28 AM on November 16, 2021:

Yes. It is not possible to compile with MSan, but without depends, so this adds no information.

laanwj commented at 9:10 AM on November 16, 2021:

Yes. It is not possible to compile with MSan, but without depends, so this adds no information.

Sure, however, not everyone has this contextual information. For some it might change the problem from it being hard to find "which one does MSan" to "which one builds depends".

MarcoFalke commented at 12:30 PM on November 16, 2021:

Thanks, restored.
DrahtBot commented at 5:35 AM on November 16, 2021: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #23504 (ci: Replace soon EOL hirsute with jammy by MarcoFalke)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
MarcoFalke commented at 7:31 AM on November 16, 2021: member

I would not have understood these 'Xsan' abbrevs.

The goal of the task names is not to be a wikipedia. If you want to explore the details of the ci system further, you can read the scripts in the ./ci/ folder or refer to other resources.
DrahtBot added the label Needs rebase on Nov 16, 2021
MarcoFalke force-pushed on Nov 16, 2021
DrahtBot removed the label Needs rebase on Nov 16, 2021
ci: Rework ci task names fa459220c7
MarcoFalke force-pushed on Nov 16, 2021
fanquake approved
fanquake commented at 12:45 AM on November 17, 2021: member

ACK fa459220c7b7a56bcd5426f977cbca17c7af1a5e
fanquake merged this on Nov 17, 2021
fanquake closed this on Nov 17, 2021
MarcoFalke deleted the branch on Nov 17, 2021
sidhujag referenced this in commit 82c932bbde on Nov 17, 2021
DrahtBot locked this on Nov 17, 2022

Contributors

Labels

Linked (view graph)

#20545 ci: Adjust cirrus ci task names #20572 ci: Adjust Cirrus CI task names (follow up)

ci: Rework ci task names (take 3) #23520

Conflicts