build: don't use deprecated brew package names #23564

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:dont_use_deprecated_bdb changing 2 files +5 −5

fanquake commented at 10:01 AM on November 21, 2021: member

Fixes:

checking for brew... brew
Warning: Use berkeley-db@4 instead of deprecated berkeley-db4

on macOS.

fanquake added the label Build system on Nov 21, 2021
hebasto commented at 10:04 AM on November 21, 2021: member

Concept ACK.

Maybe also s/qt5/qt@5/ a few lines below?
katesalazar commented at 11:21 AM on November 21, 2021: contributor

Concept ACK.

https://github.com/bitcoin/bitcoin/blob/368831371d97a642beb54b5c4eb6eb0fedaa16b4/.cirrus.yml#L287

build: don't check for deprecated berkeley-db4 package

Fixes:
```bash
checking for brew... brew
Warning: Use berkeley-db@4 instead of deprecated berkeley-db4
```

d0fe9c2180

build: don't check for deprecated qt5 package
Use qt@5 instead.
4d83038714
fanquake force-pushed on Nov 21, 2021
fanquake renamed this:
~~build: don't check for deprecated `berkeley-db4` package~~
build: don't use deprecated brew package names
on Nov 21, 2021
fanquake commented at 11:36 AM on November 21, 2021: member

Maybe also s/qt5/qt@5/ a few lines below?

Done.

Concept ACK.

https://github.com/bitcoin/bitcoin/blob/368831371d97a642beb54b5c4eb6eb0fedaa16b4/.cirrus.yml#L287

Added.
hebasto approved
hebasto commented at 11:42 AM on November 21, 2021: member

ACK 4d83038714e4f099529e4372ef04f8f947c3a421, I have reviewed the code and it looks OK, I agree it can be merged.

katesalazar commented at 12:13 PM on November 21, 2021: contributor

Suggest replacing:

build: don't check for deprecated berkeley-db4 package

Fixes:
```bash
checking for brew... brew
Warning: Use berkeley-db@4 instead of deprecated berkeley-db4
```

For:

build: don't check for deprecated berkeley-db4 package

Fixes:

    checking for brew... brew
    Warning: Use berkeley-db@4 instead of deprecated berkeley-db4

Console output is not source code.

mjdietzx commented at 3:19 PM on November 21, 2021: contributor

Tested ACK 4d83038714e4f099529e4372ef04f8f947c3a421 on macOS Big Sur
fanquake merged this on Nov 22, 2021
fanquake closed this on Nov 22, 2021
fanquake deleted the branch on Nov 22, 2021
sidhujag referenced this in commit 451f96fb64 on Nov 22, 2021
sidhujag referenced this in commit 8d459942a6 on Nov 23, 2021
DrahtBot locked this on Nov 22, 2022

Contributors

Labels