build: Propagate user-defined tools to native packages #23571

pull hebasto wants to merge 3 commits into bitcoin:master from hebasto:211122-tools changing 4 files +39 −2
  1. hebasto commented at 11:13 am on November 22, 2021: member

    On master (66636ca438cb65fb18bcaa4540856cef0cee2029) build tools for native packages are set to defaults, even when such a tool is not available in the system by its default name:

    0$ cd depends
1$ make print-native_capnp_cxx MULTIPROCESS=1 CC=clang CXX=clang++
2native_capnp_cxx=g++

    On system without GCC installed, this causes an error:

    0$ make native_capnp_configured MULTIPROCESS=1 CC=clang CXX=clang++
1Configuring native_capnp...
2...
3configure: error: *** A compiler with support for C++14 language features is required.
4make: *** [funcs.mk:283: /home/hebasto/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/native_capnp/0.7.0-4f60a88ce07/./.stamp_configured] Error 1

    This PR fixes this issue with introducing support of {CC,CXX}_FOR_BUILD variables.

    With this PR:

    0$ make print-native_capnp_cxx MULTIPROCESS=1 CC_FOR_BUILD=clang CXX_FOR_BUILD=clang++
1native_capnp_cxx=clang++
2$ make native_capnp_configured MULTIPROCESS=1 CC_FOR_BUILD=clang CXX_FOR_BUILD=clang++
3# no errors
  2. hebasto added the label Build system on Nov 22, 2021
  3. dongcarl commented at 5:50 pm on November 22, 2021: contributor
    Concept ACK, perhaps we can use variable names like CC_FOR_BUILD to distinguish? This is what autoconf uses, and is used in secp256k1: https://github.com/bitcoin-core/secp256k1/blob/793ad9016a09c3bf5a5f280c812c46526250d839/configure.ac#L342
  4. hebasto commented at 7:01 pm on November 22, 2021: member

    Concept ACK, perhaps we can use variable names like CC_FOR_BUILD to distinguish? This is what autoconf uses, and is used in secp256k1: https://github.com/bitcoin-core/secp256k1/blob/793ad9016a09c3bf5a5f280c812c46526250d839/configure.ac#L342

    It makes sense within a build system which is based on Autotools. Is there any benefit in pure Makefile’s (our depends build system)?

  5. dongcarl commented at 7:11 pm on November 22, 2021: contributor

    The benefit is just that the user can specify a different CC for build vs target, e.g.:

    0$ make -C depends CC_FOR_BUILD=clang CC=x86_64-w64-mingw32-gcc
  6. hebasto commented at 7:15 pm on November 22, 2021: member

    The benefit is just that the user can specify a different CC for build vs target, e.g.:

    0$ make -C depends CC_FOR_BUILD=clang CC=x86_64-w64-mingw32-gcc

    Should new variables be limited to compilers only, i.e, CC_FOR_BUILD and CXX_FOR_BUILD, or cover the whole tool set?

  7. dongcarl commented at 7:32 pm on November 22, 2021: contributor

    Should new variables be limited to compilers only, i.e, CC_FOR_BUILD and CXX_FOR_BUILD, or cover the whole tool set?

    Up to you! It seems like CC and CXX would be useful enough, so whatever’s easy to do I guess

  8. shaavan commented at 12:29 pm on November 23, 2021: contributor

    Concept ACK

    This PR allows users to provide their values for CC and CXX flags. If the user does not give those values, the earlier method of assigning the build_$(build_os)$1, and build$(build_arch)$(build_os)$1. Otherwise, these variables are assigned the value the user has provided. If that is empty, the earlier set value of these variables is used. If that’s also empty, the default value is used.

    As discussed in the PR description, this change will prevent unnecessary problems where the default tools are not available (by the same name) in the system.

    P.s.: (As it’s my first time reviewing PR involving makefiles, if some of my observations are erroneous, please do correct me.)

  9. hebasto force-pushed on Nov 28, 2021
  10. hebasto commented at 4:06 pm on November 28, 2021: member

    Updated 557d4d5d74219b38d0c1a37b7e30122db3e575a8 -> 0ac8f23a040a997aa545c054b7806a2a98aaca45 (pr23571.01 -> pr23571.02).

    Added a commit which addresses @dongcarl’s comment:

    Concept ACK, perhaps we can use variable names like CC_FOR_BUILD to distinguish? This is what autoconf uses, and is used in secp256k1: https://github.com/bitcoin-core/secp256k1/blob/793ad9016a09c3bf5a5f280c812c46526250d839/configure.ac#L342

    The benefit is just that the user can specify a different CC for build vs target, e.g.:

    0$ make -C depends CC_FOR_BUILD=clang CC=x86_64-w64-mingw32-gcc
  11. DrahtBot commented at 2:28 am on November 29, 2021: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Concept ACK shaavan
    Stale ACK dongcarl, laanwj, TheCharlatan

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    Conflicts

    No conflicts as of last run.

  12. in depends/builders/default.mk:13 in 0ac8f23a04 outdated 
     7@@ -8,9 +8,9 @@ default_build_OTOOL = otool
 8 default_build_INSTALL_NAME_TOOL = install_name_tool
 9 
10 define add_build_tool_func
11-ifeq ($(filter $(origin $1),undefined default),)
12-build_$(build_os)_$1 = $(or $($1),$(build_$(build_os)_$1),$(default_build_$1))
13-build_$(build_arch)_$(build_os)_$1 = $(or $($1),$(build_$(build_arch)_$(build_os)_$1),$$(build_$(build_os)_$1))
14+ifneq ($(origin $1_FOR_BUILD),undefined)
15+build_$(build_os)_$1 = $(or $($1_FOR_BUILD),$(build_$(build_os)_$1),$(default_build_$1))
16+build_$(build_arch)_$(build_os)_$1 = $(or $($1_FOR_BUILD),$(build_$(build_arch)_$(build_os)_$1),$$(build_$(build_os)_$1))
    dongcarl commented at 5:42 pm on November 30, 2021:
    Perhaps we should establish a style for Makefiles… But I find it more explicit to say $($(1)_FOR_BUILD) like we do for $($(1)_postprocessed) etc.
    hebasto commented at 7:25 pm on November 30, 2021:

    Sorry Carl, but I’m not sure if I understand you correctly…

    ~If you mean s/$($1_FOR_BUILD)/$($(1)_FOR_BUILD)/, both are not equivalent though.~

    dongcarl commented at 8:30 pm on November 30, 2021:
    Oh, then in that case shouldn’t we be using $($(1)_FOR_BUILD) in these cases for correctness’ sake?
    hebasto commented at 9:11 am on December 1, 2021:

    Oh, then in that case shouldn’t we be using $($(1)_FOR_BUILD) in these cases for correctness’ sake?

    We are interested in $(CXX_FOR_BUILD) rather $(g++_FOR_BUILD), no?

    hebasto commented at 0:08 am on December 21, 2021:

    I was definitely wrong. Sorry for noise.

    Updated.

  13. laanwj commented at 3:28 pm on December 9, 2021: member
    Concept ACK, I’ve run into this problem in the past too.
  14. hebasto commented at 9:24 pm on December 12, 2021: member

    Guix builds:

     0$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 1eeef2f1cf459b1ed2901b8aad5037f1af535de30b75a37e3bc8ce4b1b630c49e  guix-build-0ac8f23a040a/output/aarch64-linux-gnu/SHA256SUMS.part
 25d8fd9e11874269c6e3a90cd644c76d6bc9723e3dc9d42ed10ec5d97eaac5fb1  guix-build-0ac8f23a040a/output/aarch64-linux-gnu/bitcoin-0ac8f23a040a-aarch64-linux-gnu-debug.tar.gz
 35734ea5f9a29e0e67d97a457495e3ebb882688c5922e4f00bb0b87e0d1d3f3e8  guix-build-0ac8f23a040a/output/aarch64-linux-gnu/bitcoin-0ac8f23a040a-aarch64-linux-gnu.tar.gz
 45be326c09d7ccf61381b546671952e5ec1f3d023ecfb72c8faa2d045b66446fe  guix-build-0ac8f23a040a/output/arm-linux-gnueabihf/SHA256SUMS.part
 52d98bf2d15aa686978023522fb67cbb5afc773070e774e54ada7d4849ea469d3  guix-build-0ac8f23a040a/output/arm-linux-gnueabihf/bitcoin-0ac8f23a040a-arm-linux-gnueabihf-debug.tar.gz
 65dacf0c4e62b685140d9d0aae5ffaa696917c5fb520f1d9204b0b8bd8cea6f3d  guix-build-0ac8f23a040a/output/arm-linux-gnueabihf/bitcoin-0ac8f23a040a-arm-linux-gnueabihf.tar.gz
 78a308b43c16af5847dc50d8234abb80063e0a3cc5f1556f8b5e53f05316de474  guix-build-0ac8f23a040a/output/dist-archive/bitcoin-0ac8f23a040a.tar.gz
 89bb864663c3f786ad5ff7ad99c258938a68e46d814134644c8c1bf2703dd9abf  guix-build-0ac8f23a040a/output/powerpc64-linux-gnu/SHA256SUMS.part
 9b7bd2a8d3d33ff330da075792389712db2743f0661b2d4870534b03b2fa21ec6  guix-build-0ac8f23a040a/output/powerpc64-linux-gnu/bitcoin-0ac8f23a040a-powerpc64-linux-gnu-debug.tar.gz
1008cbd743f83dbcff02b8324eeb743619f8e7dc4eef61daf0f42ab0fba686ed19  guix-build-0ac8f23a040a/output/powerpc64-linux-gnu/bitcoin-0ac8f23a040a-powerpc64-linux-gnu.tar.gz
115b4ce19be8690cb9b8d9d675aa76d8bd540b2f712d01d7d1e661988c01fc4857  guix-build-0ac8f23a040a/output/powerpc64le-linux-gnu/SHA256SUMS.part
1285f2ea989a6223f5f20a548b432bd3fd218f651bc3707f7a30d7310147d89fee  guix-build-0ac8f23a040a/output/powerpc64le-linux-gnu/bitcoin-0ac8f23a040a-powerpc64le-linux-gnu-debug.tar.gz
138e1ad04f2437f739f3243f17c975846b682ccfd33be13e442654f89fff7c2faa  guix-build-0ac8f23a040a/output/powerpc64le-linux-gnu/bitcoin-0ac8f23a040a-powerpc64le-linux-gnu.tar.gz
14baba8b47ae464659805fe8f799b90ad921b74114db81c68ab16f0c59cc2528e1  guix-build-0ac8f23a040a/output/riscv64-linux-gnu/SHA256SUMS.part
1500f500e08094e773347b38faba5147265b7bc106a90bfb47a02e870b48c66a1d  guix-build-0ac8f23a040a/output/riscv64-linux-gnu/bitcoin-0ac8f23a040a-riscv64-linux-gnu-debug.tar.gz
16e5e6d2cb2f7eb96aff42ab471f936e241be83d2442a1ea6e31b3a276e67f3edc  guix-build-0ac8f23a040a/output/riscv64-linux-gnu/bitcoin-0ac8f23a040a-riscv64-linux-gnu.tar.gz
1749792292ae4adca028f4d1acaf25c614687740cb03dd58b4b9c41d4b47bcf10a  guix-build-0ac8f23a040a/output/x86_64-apple-darwin19/SHA256SUMS.part
18af95ed0b8ebd5f8879637a52848bd3ac57a44deee3bf15c258fedeb548dcc105  guix-build-0ac8f23a040a/output/x86_64-apple-darwin19/bitcoin-0ac8f23a040a-osx-unsigned.dmg
1940287d1e76212247df6b365120ef97662c5f93c043a8348b2e854dd783a99e0b  guix-build-0ac8f23a040a/output/x86_64-apple-darwin19/bitcoin-0ac8f23a040a-osx-unsigned.tar.gz
2097bc510a7dcc29fc6b43331f23e41f41ae5a4ee3faf25240af3da62ab5b74fee  guix-build-0ac8f23a040a/output/x86_64-apple-darwin19/bitcoin-0ac8f23a040a-osx64.tar.gz
21631c5de077daa48b96ef75c5f85d116e9a6f3cb49dd1de25bf0a1c75098f347f  guix-build-0ac8f23a040a/output/x86_64-linux-gnu/SHA256SUMS.part
22df87812daa747f878238ddc2b6580821dafc417b5889ed5d54d04ab11a6bab89  guix-build-0ac8f23a040a/output/x86_64-linux-gnu/bitcoin-0ac8f23a040a-x86_64-linux-gnu-debug.tar.gz
232c9e5ede94a7faa44f7df0c139a82a21d77788d6e3b097cf1888c45e262b67c1  guix-build-0ac8f23a040a/output/x86_64-linux-gnu/bitcoin-0ac8f23a040a-x86_64-linux-gnu.tar.gz
2493dfd01edc575d559a111d2b91d49d96c6fee8433780a8deeee774d76a8d5622  guix-build-0ac8f23a040a/output/x86_64-w64-mingw32/SHA256SUMS.part
25ea2347512b6e1d1b52135df27501f14f453c9a3fe2b8efb60e36e0bfe1628012  guix-build-0ac8f23a040a/output/x86_64-w64-mingw32/bitcoin-0ac8f23a040a-win-unsigned.tar.gz
2630e143700f30eb12946d8c28b33c2886f7c2659fbeaafa19d195346dbf8a2f99  guix-build-0ac8f23a040a/output/x86_64-w64-mingw32/bitcoin-0ac8f23a040a-win64-debug.zip
279c4d57f2e9f1eee37cb6aff2c5f2903bb6ee08a03956e3dc68cc1b122546313a  guix-build-0ac8f23a040a/output/x86_64-w64-mingw32/bitcoin-0ac8f23a040a-win64-setup-unsigned.exe
28cc7883e5cb48b5d30d027e2b007e983744874b6c6951a9b3a3fade8176d6a04a  guix-build-0ac8f23a040a/output/x86_64-w64-mingw32/bitcoin-0ac8f23a040a-win64.zip
  15. hebasto force-pushed on Dec 21, 2021
  16. hebasto commented at 0:06 am on December 21, 2021: member

    Updated 0ac8f23a040a997aa545c054b7806a2a98aaca45 -> 28725337e6011789a6b4e80c0cb127979bf34221 (pr23571.02 -> pr23571.03).

    Addressed @dongcarl’s comment.

  17. hebasto commented at 9:47 am on December 21, 2021: member

    Guix builds:

     0$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 1a33d7a344036242596b631a5601cfce1c1dee5e76581d97cce351a2a772f5c66  guix-build-28725337e601/output/aarch64-linux-gnu/SHA256SUMS.part
 23d88200cb088296a52fcb40a167aa483de2012d9021eddc8e754d1d14f5a1b50  guix-build-28725337e601/output/aarch64-linux-gnu/bitcoin-28725337e601-aarch64-linux-gnu-debug.tar.gz
 365fac30ac6f5e495484c35d8d2d531806a0ccb432bf59f0e08f3d5c954434b64  guix-build-28725337e601/output/aarch64-linux-gnu/bitcoin-28725337e601-aarch64-linux-gnu.tar.gz
 4ff89320d0db9be6b55b7ddf611964fa9adb81311460c754c934d7141984b5575  guix-build-28725337e601/output/arm-linux-gnueabihf/SHA256SUMS.part
 5b29142d2ff4ebd0897a54a47568b470f0e5b39dd634b643325483eabc6624972  guix-build-28725337e601/output/arm-linux-gnueabihf/bitcoin-28725337e601-arm-linux-gnueabihf-debug.tar.gz
 670d98875fefa2ed41dd2d29b44bccc807ec6f8bc9fb74e3a2a6a6f50f236d99e  guix-build-28725337e601/output/arm-linux-gnueabihf/bitcoin-28725337e601-arm-linux-gnueabihf.tar.gz
 75e910973159116c6beb5f1dbb86990baaa6a6b8da8e3f621462b17d3ab1dcdc9  guix-build-28725337e601/output/dist-archive/bitcoin-28725337e601.tar.gz
 8fdb11bd1f5a99f4fdadd35ce34f84884a2c31be030ca3c441d82feb1ec277c8b  guix-build-28725337e601/output/powerpc64-linux-gnu/SHA256SUMS.part
 92121b104948e0f4a9677ccd58dcb05cc4f4f9adbd080fea8072714899763b639  guix-build-28725337e601/output/powerpc64-linux-gnu/bitcoin-28725337e601-powerpc64-linux-gnu-debug.tar.gz
108bf13d1a32bc15b2e92b86103c63fb02ad7c65b69065b8ce3963756eda72ce6d  guix-build-28725337e601/output/powerpc64-linux-gnu/bitcoin-28725337e601-powerpc64-linux-gnu.tar.gz
1118910b8da72c9aab0a5642923826b7dba6c89a5f1d60aa84524a5f38e118bdd1  guix-build-28725337e601/output/powerpc64le-linux-gnu/SHA256SUMS.part
12289be1f144ccfa1d6e4f65a835d1bc759bd5e8b0c47d8a38e970fbccfd8a7e48  guix-build-28725337e601/output/powerpc64le-linux-gnu/bitcoin-28725337e601-powerpc64le-linux-gnu-debug.tar.gz
13ae8055a3564fab10f88de7f7b51a0317da1424e6b52d0d6ac43ca7ddbfbfceb5  guix-build-28725337e601/output/powerpc64le-linux-gnu/bitcoin-28725337e601-powerpc64le-linux-gnu.tar.gz
14ef5e268e26d50776f815a8d915cafb0318947eb14880ca5d17d6e1d2fd820216  guix-build-28725337e601/output/riscv64-linux-gnu/SHA256SUMS.part
15dbd0bdc40fd1ce847d9d1d8411303b37b914c10837d3308186f86facc6f0bd3b  guix-build-28725337e601/output/riscv64-linux-gnu/bitcoin-28725337e601-riscv64-linux-gnu-debug.tar.gz
16efa2858f9e04c9575309d9b34fdcd68fa0ea2fbdaad5293754b4d5ac2bc1f25e  guix-build-28725337e601/output/riscv64-linux-gnu/bitcoin-28725337e601-riscv64-linux-gnu.tar.gz
17fd6c6de0b9ca56595ce6e511cd69780f76d7b1e7f4c2405e47aa44ee73fdc7f4  guix-build-28725337e601/output/x86_64-apple-darwin/SHA256SUMS.part
1817f098049726196847752c6d2bbc1e9c1cf8122f6631b3df52e5588c1895b4fc  guix-build-28725337e601/output/x86_64-apple-darwin/bitcoin-28725337e601-osx-unsigned.dmg
190740bfb2753e7a8aad4c953fb638be4f96db9194dac94158ccd08a657a22099b  guix-build-28725337e601/output/x86_64-apple-darwin/bitcoin-28725337e601-osx-unsigned.tar.gz
2095dd7a6370486906c26564eeafd1ae08ce05e287a1ec86d5e3c61a392257fce3  guix-build-28725337e601/output/x86_64-apple-darwin/bitcoin-28725337e601-osx64.tar.gz
21f3516a46d7019f8b473901b0599af3f494f0a1b487a33ee21d4fd1742767894d  guix-build-28725337e601/output/x86_64-linux-gnu/SHA256SUMS.part
228c30a6e0fa7317ff5e84def04a39ac09e062e19010c613c17c05ef1cf1312660  guix-build-28725337e601/output/x86_64-linux-gnu/bitcoin-28725337e601-x86_64-linux-gnu-debug.tar.gz
23ed9c1d4872478ac59a3f49ebe2640d51cf1882335bb94aac5261f15e3f2e3a27  guix-build-28725337e601/output/x86_64-linux-gnu/bitcoin-28725337e601-x86_64-linux-gnu.tar.gz
244d4c2adae87d52b99880ff9b1adbf08abddef7060432e1da800278e009c1cd13  guix-build-28725337e601/output/x86_64-w64-mingw32/SHA256SUMS.part
25de6268e155e04f73226f9513dd3a44322c96abdf06792538bccf2f7a7d1f453b  guix-build-28725337e601/output/x86_64-w64-mingw32/bitcoin-28725337e601-win-unsigned.tar.gz
26e2732734e018100e513653bc22f113402a8a5b0aea79c0f39728e8ff4a234152  guix-build-28725337e601/output/x86_64-w64-mingw32/bitcoin-28725337e601-win64-debug.zip
27008755bbb1ec6076b6fd27ebf9fe53edc49458918773429a7a2f440b6ed44cfd  guix-build-28725337e601/output/x86_64-w64-mingw32/bitcoin-28725337e601-win64-setup-unsigned.exe
28d2ef854bdb2603a477d0e98049394342966c01713c231e93b55abe3dcac9a503  guix-build-28725337e601/output/x86_64-w64-mingw32/bitcoin-28725337e601-win64.zip
  18. in depends/builders/default.mk:16 in 28725337e6 outdated 
    13+build_$(build_arch)_$(build_os)_$1 = $(or $($(1)_FOR_BUILD),$(build_$(build_arch)_$(build_os)_$1),$$(build_$(build_os)_$1))
14+else
15 build_$(build_os)_$1 ?= $$(default_build_$1)
16 build_$(build_arch)_$(build_os)_$1 ?= $$(build_$(build_os)_$1)
17-build_$1=$$(build_$(build_arch)_$(build_os)_$1)
18+endif
    dongcarl commented at 8:58 pm on December 21, 2021:
    For readability’s sake, perhaps we can make the if branch ordering the same as the one in https://github.com/bitcoin/bitcoin/blob/887796a5ffcbafcd281b920f8d55fcb6e8347584/depends/hosts/default.mk#L16-L27
    hebasto commented at 9:50 pm on December 21, 2021:

    Thanks!

    Updated.

  19. dongcarl commented at 9:02 pm on December 21, 2021: contributor
    Looking good so far, would be great if we pass these along to bitcoin core’s configure via config.site!
  20. hebasto force-pushed on Dec 21, 2021
  21. hebasto commented at 9:49 pm on December 21, 2021: member

    Updated 28725337e6011789a6b4e80c0cb127979bf34221 -> bcfe469576156aaf2f9a33fa8f083910c3266143 (pr23571.03 -> pr23571.04).

    Addressed the recent @dongcarl’s comments.

  22. dongcarl commented at 9:04 pm on December 22, 2021: contributor
    Code Review ACK bcfe469576156aaf2f9a33fa8f083910c3266143 🚀
  23. hebasto commented at 12:17 pm on December 23, 2021: member

    Guix builds:

     0$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 15c4db77a31bd8b696fae815a357ce06152a75cea4706f0acb36904b4521cc64b  guix-build-bcfe46957615/output/aarch64-linux-gnu/SHA256SUMS.part
 2a835c59f6aa02754a2bed6ad6b995adef9b672f6bf76806a09dcd45fecdf28a9  guix-build-bcfe46957615/output/aarch64-linux-gnu/bitcoin-bcfe46957615-aarch64-linux-gnu-debug.tar.gz
 3949d274c83b09c9eced8a0f45561fb126a1a3a4fb23163d3080193707c7164ee  guix-build-bcfe46957615/output/aarch64-linux-gnu/bitcoin-bcfe46957615-aarch64-linux-gnu.tar.gz
 4902ddca13a5358271376e23f1d65adad1b2b8f0aa775be0ab17196b78f050ed7  guix-build-bcfe46957615/output/arm-linux-gnueabihf/SHA256SUMS.part
 56bcf0380c54dd0f3c7742a5965ccdfcf85a0a3a2c3e5aa39fafd24a9b3cdec8b  guix-build-bcfe46957615/output/arm-linux-gnueabihf/bitcoin-bcfe46957615-arm-linux-gnueabihf-debug.tar.gz
 6d22ee005fea1912a8fd5db7e6bf2d5f0a9a57fee7ef50355b580e167364dcdb4  guix-build-bcfe46957615/output/arm-linux-gnueabihf/bitcoin-bcfe46957615-arm-linux-gnueabihf.tar.gz
 7842134d949c14e178376472b1a607fadf01d54969871804557bb356469bf527f  guix-build-bcfe46957615/output/dist-archive/bitcoin-bcfe46957615.tar.gz
 8aa3531ed9347a7b3153bd42b89a079ee5b58655f87bbc8eb379ae94fd4eb76b4  guix-build-bcfe46957615/output/powerpc64-linux-gnu/SHA256SUMS.part
 999836c8e17fd3c82b9b66d47d43aef21a03b0cbac753abc1d05467de463fa89d  guix-build-bcfe46957615/output/powerpc64-linux-gnu/bitcoin-bcfe46957615-powerpc64-linux-gnu-debug.tar.gz
10f9348f571e58a15bfcdb5a75f8b161f0e9b100a785a3b9a0a824b076da24f363  guix-build-bcfe46957615/output/powerpc64-linux-gnu/bitcoin-bcfe46957615-powerpc64-linux-gnu.tar.gz
113095f92ac9cd336edd4468386a11ee7b3281c9aef699475f11c5999cce74f1df  guix-build-bcfe46957615/output/powerpc64le-linux-gnu/SHA256SUMS.part
12060bd1a58748125b018827d65e2d5062e52f7d641ed88ccede9bb856365c068a  guix-build-bcfe46957615/output/powerpc64le-linux-gnu/bitcoin-bcfe46957615-powerpc64le-linux-gnu-debug.tar.gz
13f9de2f5cbe14f4a5f567b590790f6878447a0b7e6fe95ca0d6139ab3de4d8bac  guix-build-bcfe46957615/output/powerpc64le-linux-gnu/bitcoin-bcfe46957615-powerpc64le-linux-gnu.tar.gz
148d5234a947ff9350f8b375b4d13c5a54f8b7060301db359c828c4620135a98cb  guix-build-bcfe46957615/output/riscv64-linux-gnu/SHA256SUMS.part
1530e0b5d614c90c95fa5c3280c16009535dd77e37c82aca489d454e87957e43e5  guix-build-bcfe46957615/output/riscv64-linux-gnu/bitcoin-bcfe46957615-riscv64-linux-gnu-debug.tar.gz
164ceb917473ace0b05d582f269c1801c026532310a22ef3cedf299cd42613ff77  guix-build-bcfe46957615/output/riscv64-linux-gnu/bitcoin-bcfe46957615-riscv64-linux-gnu.tar.gz
1724de692eeb2fcad2938339fc2dbeca08f1763c3aab15b4c2c3791fd96a6055f7  guix-build-bcfe46957615/output/x86_64-apple-darwin/SHA256SUMS.part
18dd073eddaeaa98e279758b8524e71ac96fab1f6805b7f3a96297189dfb8b06bf  guix-build-bcfe46957615/output/x86_64-apple-darwin/bitcoin-bcfe46957615-osx-unsigned.dmg
19db5e6d0106a0a61594d82f2d9411bbd905a0b36af5c425bc147ba174c7ad264a  guix-build-bcfe46957615/output/x86_64-apple-darwin/bitcoin-bcfe46957615-osx-unsigned.tar.gz
20304dc2bbe88fee8449b65552857adaa3ebeb3fecd975dbb077384fad20cd0ad5  guix-build-bcfe46957615/output/x86_64-apple-darwin/bitcoin-bcfe46957615-osx64.tar.gz
213d7c67322e1135d033d8bd811fa33df1c52a53c88ccd81e060efb5eb7915f959  guix-build-bcfe46957615/output/x86_64-linux-gnu/SHA256SUMS.part
22ccae1dd7d6b4edaa45c999340b50031e5b88259b16e76edf49721cc75a19dc07  guix-build-bcfe46957615/output/x86_64-linux-gnu/bitcoin-bcfe46957615-x86_64-linux-gnu-debug.tar.gz
23175a70d6275b6c108a6bcc4623c6af35cf6587fa3afc086e141e3b7b5c09f989  guix-build-bcfe46957615/output/x86_64-linux-gnu/bitcoin-bcfe46957615-x86_64-linux-gnu.tar.gz
248bba3659687987954588f9d3dd6899080db92e2b4e694772724abb3e13b0141c  guix-build-bcfe46957615/output/x86_64-w64-mingw32/SHA256SUMS.part
2543ae47c0479aa0de6062a61daae1f06fa629e91e362caf5458113d85de6dccb2  guix-build-bcfe46957615/output/x86_64-w64-mingw32/bitcoin-bcfe46957615-win-unsigned.tar.gz
265f9b865cb5875d9628ec085a5b66af859c88db651dadc325ac385b1a733c76ce  guix-build-bcfe46957615/output/x86_64-w64-mingw32/bitcoin-bcfe46957615-win64-debug.zip
27e3629bf7e9e975566f780d533ada4d0a9557fa541d53dcd4e4d044173d377642  guix-build-bcfe46957615/output/x86_64-w64-mingw32/bitcoin-bcfe46957615-win64-setup-unsigned.exe
28ff1dda1c43449db52bcd93525e59b5459897c5742d030314110f4efa052a69c7  guix-build-bcfe46957615/output/x86_64-w64-mingw32/bitcoin-bcfe46957615-win64.zip
  24. DrahtBot added the label Needs rebase on Feb 11, 2022
  25. hebasto force-pushed on Feb 18, 2022
  26. hebasto force-pushed on Feb 18, 2022
  27. hebasto commented at 12:26 pm on February 18, 2022: member
    Rebased bcfe469576156aaf2f9a33fa8f083910c3266143 -> 5f7b00416e291f11b93222c896e4963fc50528a9 (pr23571.04 -> pr23571.05).
  28. hebasto commented at 12:46 pm on February 18, 2022: member
    The PR description has been updated.
  29. DrahtBot removed the label Needs rebase on Feb 18, 2022
  30. hebasto commented at 2:58 pm on February 18, 2022: member

    Guix builds:

     0$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 1c8fa190ed056c1824cfd68867b216ca88428ccb8e3f1f9bd54585003d7618c1d  guix-build-5f7b00416e29/output/aarch64-linux-gnu/SHA256SUMS.part
 26895a614bf81880baf1c90f44ebf5caf6dc306d9a4a15b22fdde9460ac5d8a63  guix-build-5f7b00416e29/output/aarch64-linux-gnu/bitcoin-5f7b00416e29-aarch64-linux-gnu-debug.tar.gz
 3422ceb28dd9c3bf0b8c7e3796b7a87e5b4dc7f387f3f0a57c2eccb049ca9456a  guix-build-5f7b00416e29/output/aarch64-linux-gnu/bitcoin-5f7b00416e29-aarch64-linux-gnu.tar.gz
 4ab2a9987cb9d55e8404de6dc36c14dc6ea31f44f862dfc95f378a720bf767bbb  guix-build-5f7b00416e29/output/arm-linux-gnueabihf/SHA256SUMS.part
 506a0e12a6c85c9f25a3b7c0de7490ae1588eb5e0a1792b1807bd9fb0a52c6f10  guix-build-5f7b00416e29/output/arm-linux-gnueabihf/bitcoin-5f7b00416e29-arm-linux-gnueabihf-debug.tar.gz
 67b892a9e2517ac0730683e547ccceb4679659989687373d0252e06418f1e3e6c  guix-build-5f7b00416e29/output/arm-linux-gnueabihf/bitcoin-5f7b00416e29-arm-linux-gnueabihf.tar.gz
 7bba9e837f697ea76ce3e78e3dcbe0371cf936cf26048533f996a118c724aac78  guix-build-5f7b00416e29/output/arm64-apple-darwin/SHA256SUMS.part
 8a437e945afb4935e5eb6f20ff5db6ece592039418ccad36c03e6dec39ee6a33e  guix-build-5f7b00416e29/output/arm64-apple-darwin/bitcoin-5f7b00416e29-arm64-apple-darwin.tar.gz
 9e847b86d128a40253aaba2fa549d0eb5acbacc11f45bb58a7ec67bd9d93bb05b  guix-build-5f7b00416e29/output/arm64-apple-darwin/bitcoin-5f7b00416e29-osx-unsigned.dmg
1092f0eb998616c141b853a5c8c6cf5140f7d42193037833c1c84e22d349d6724e  guix-build-5f7b00416e29/output/arm64-apple-darwin/bitcoin-5f7b00416e29-osx-unsigned.tar.gz
1100aa5db584a551abc645040d6577fadddd43a3d6041f8789e46f254a2231ff2d  guix-build-5f7b00416e29/output/dist-archive/bitcoin-5f7b00416e29.tar.gz
125123f83f0f5f18fab1e163ae64e8f0191addcdf0f8501783bee638f246079e98  guix-build-5f7b00416e29/output/powerpc64-linux-gnu/SHA256SUMS.part
13c29a083fd3663b5162051f83b7a8ac5fec1743ebdba2e6f5513d6b5ca0420ac8  guix-build-5f7b00416e29/output/powerpc64-linux-gnu/bitcoin-5f7b00416e29-powerpc64-linux-gnu-debug.tar.gz
14ffdf905891296f325c9acf6633a743a8563ed53cf1406a7dadf9f17d8dfbe8bf  guix-build-5f7b00416e29/output/powerpc64-linux-gnu/bitcoin-5f7b00416e29-powerpc64-linux-gnu.tar.gz
15d055d8500392fe175b139dc8baa31a675e184be49edd0beba64d004a93f693c6  guix-build-5f7b00416e29/output/powerpc64le-linux-gnu/SHA256SUMS.part
16b55cad00128ad6e1f5767b5550bbd310f40d6ba73d52c8bb42f384ba86d78444  guix-build-5f7b00416e29/output/powerpc64le-linux-gnu/bitcoin-5f7b00416e29-powerpc64le-linux-gnu-debug.tar.gz
171ea485319e18abfcd4401832e7f690172254310c36015c96955524000c171812  guix-build-5f7b00416e29/output/powerpc64le-linux-gnu/bitcoin-5f7b00416e29-powerpc64le-linux-gnu.tar.gz
18a397c827d96cb2ed3446e218feb0d4b6b284b55b76fa89aee1656376ec68d40f  guix-build-5f7b00416e29/output/riscv64-linux-gnu/SHA256SUMS.part
19d77126f5d6287f26baa741b69f05737247b9c77b1d97fe75c47bc7ebca093197  guix-build-5f7b00416e29/output/riscv64-linux-gnu/bitcoin-5f7b00416e29-riscv64-linux-gnu-debug.tar.gz
2046a4ee280a075e270a00cc5f6a7bed77df4f4c17b935b6a3d6afd0dc683c5eb2  guix-build-5f7b00416e29/output/riscv64-linux-gnu/bitcoin-5f7b00416e29-riscv64-linux-gnu.tar.gz
21036043d05c8a828d0175c5bbd3c1573ad6f990948e7281057fcc054b15fdc70d  guix-build-5f7b00416e29/output/x86_64-apple-darwin/SHA256SUMS.part
22586bb65140419b4566c4c532952af001034e6598417c6010e251cfba1547cb73  guix-build-5f7b00416e29/output/x86_64-apple-darwin/bitcoin-5f7b00416e29-osx-unsigned.dmg
23cf33d62303766308909c91cc626d393847d4dd35a7a9a1dd6834e98b0e37d921  guix-build-5f7b00416e29/output/x86_64-apple-darwin/bitcoin-5f7b00416e29-osx-unsigned.tar.gz
24ee216be0cfcd1d3894b9f4c5393ede2277043a40464fd47e59a0377d98a56859  guix-build-5f7b00416e29/output/x86_64-apple-darwin/bitcoin-5f7b00416e29-osx64.tar.gz
2582d1d56286663860cd24dcafaf884214dfaf4ba4661997bb3c4ba12a9e1c0ecc  guix-build-5f7b00416e29/output/x86_64-linux-gnu/SHA256SUMS.part
26de469d0d8601e56712c45d7f845623325f4af26cda689f86e53e1ed417907155  guix-build-5f7b00416e29/output/x86_64-linux-gnu/bitcoin-5f7b00416e29-x86_64-linux-gnu-debug.tar.gz
27837d10b7e088967b9fb7d098d1e24d5df72aeebe3534d86616556edcc605eb39  guix-build-5f7b00416e29/output/x86_64-linux-gnu/bitcoin-5f7b00416e29-x86_64-linux-gnu.tar.gz
289f745963afb3f4436ab49bec0ec428702606c40a6d18d6878b4c663e045e6d19  guix-build-5f7b00416e29/output/x86_64-w64-mingw32/SHA256SUMS.part
29fffc1c97713f8d516b0480f39a122fc96f9525cd1568851e53ac93974b52e7f7  guix-build-5f7b00416e29/output/x86_64-w64-mingw32/bitcoin-5f7b00416e29-win-unsigned.tar.gz
30c7b24fbb8401c3dfe2de749d669ceaa53f8932b56ad7eee55e6bf9f90fb59fbc  guix-build-5f7b00416e29/output/x86_64-w64-mingw32/bitcoin-5f7b00416e29-win64-debug.zip
3109992f65261f5301be708244a09d2a1cf5356e0f96412b42bb53e1cb2ac2f306  guix-build-5f7b00416e29/output/x86_64-w64-mingw32/bitcoin-5f7b00416e29-win64-setup-unsigned.exe
320a5988cfe89174c7e2155d248ec0640605ff13966ca0c69ee6b3f2d30d332cb3  guix-build-5f7b00416e29/output/x86_64-w64-mingw32/bitcoin-5f7b00416e29-win64.zip
  31. laanwj commented at 12:21 pm on April 6, 2022: member
    Light code-review ACK 5f7b00416e291f11b93222c896e4963fc50528a9 (Looks sane, but I can’t say I know enough details of the depends system to know if the flow of information is entirely correct in every case)
  32. DrahtBot added the label Needs rebase on Apr 14, 2022
  33. hebasto force-pushed on Apr 16, 2022
  34. hebasto commented at 6:52 am on April 16, 2022: member
    Rebased 5f7b00416e291f11b93222c896e4963fc50528a9 -> 76d4d3bb407325bb0350de45ece982e286a1087f (pr23571.05 -> pr23571.06) due to the conflict with #19952.
  35. DrahtBot removed the label Needs rebase on Apr 16, 2022
  36. hebasto commented at 12:25 pm on April 16, 2022: member

    Guix builds on x86_64:

     0$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 1d2192fb917e24c840dfac5e85636cbe533bae891cd9affdd9f88b346fc524411  guix-build-76d4d3bb4073/output/aarch64-linux-gnu/SHA256SUMS.part
 2e2a46151d0a176026d51849ada443baa0d13001621ef353bbfcd2fbca884df6d  guix-build-76d4d3bb4073/output/aarch64-linux-gnu/bitcoin-76d4d3bb4073-aarch64-linux-gnu-debug.tar.gz
 3a6944abf7590f39b19f23f79f372fed020ed8af39003a956ab205038de75b4a0  guix-build-76d4d3bb4073/output/aarch64-linux-gnu/bitcoin-76d4d3bb4073-aarch64-linux-gnu.tar.gz
 41b282042bdbc3d5418f90c6eb26f5ef199b632149ead0688d4b4607a7373f7ea  guix-build-76d4d3bb4073/output/arm-linux-gnueabihf/SHA256SUMS.part
 5342b92c8366b6d99508f5ebe678870feb3a1b117c485606ca5966c2751c2a588  guix-build-76d4d3bb4073/output/arm-linux-gnueabihf/bitcoin-76d4d3bb4073-arm-linux-gnueabihf-debug.tar.gz
 6006d00b8ce4b2b3a1ca793976b971274a2ad0af3e126dd7573f8ae6f62fabd70  guix-build-76d4d3bb4073/output/arm-linux-gnueabihf/bitcoin-76d4d3bb4073-arm-linux-gnueabihf.tar.gz
 7bccd8bb8fdb49808f9170884a637f7f7d32bdc98c8b842994e9df5666fe7213a  guix-build-76d4d3bb4073/output/arm64-apple-darwin/SHA256SUMS.part
 8c048ee3527c46d85b69ff10e15d92f6900a5763ed85446731306009494d76515  guix-build-76d4d3bb4073/output/arm64-apple-darwin/bitcoin-76d4d3bb4073-arm64-apple-darwin-unsigned.dmg
 904ca03d1e9df281bd6b0ce5a581e2628efb40b129b92423f42e3183fc3bad5f9  guix-build-76d4d3bb4073/output/arm64-apple-darwin/bitcoin-76d4d3bb4073-arm64-apple-darwin-unsigned.tar.gz
10d9d6f171bae71f429e269525cdceebbafd3caae161a3f996d9b06714229b8c2a  guix-build-76d4d3bb4073/output/arm64-apple-darwin/bitcoin-76d4d3bb4073-arm64-apple-darwin.tar.gz
119e77ef269d8c444e3db88d47e9edc8f1bf07b51de10e7ee50db85b568b421835  guix-build-76d4d3bb4073/output/dist-archive/bitcoin-76d4d3bb4073.tar.gz
12734a697b081eacb02af84c306b496145f16a1a2c437dd1cf2c89516546f30e49  guix-build-76d4d3bb4073/output/powerpc64-linux-gnu/SHA256SUMS.part
13683696b5199e42239136fdce4b376f7d61908e0333f7179a4e7845870b39200f  guix-build-76d4d3bb4073/output/powerpc64-linux-gnu/bitcoin-76d4d3bb4073-powerpc64-linux-gnu-debug.tar.gz
1422ca1f7e04a79a3cb7d938ef7e7a5446c30bca00d07e289fcd5c5674b1cd41c9  guix-build-76d4d3bb4073/output/powerpc64-linux-gnu/bitcoin-76d4d3bb4073-powerpc64-linux-gnu.tar.gz
1503b1f5baaf90b9bb8fcf13b2ceecf7aab500087c1e60272be372b04e0f79a597  guix-build-76d4d3bb4073/output/powerpc64le-linux-gnu/SHA256SUMS.part
16ae248964c7dd3043ab3f36aa1f1b7012ce19c7b6629616688ca18b62ee738ab2  guix-build-76d4d3bb4073/output/powerpc64le-linux-gnu/bitcoin-76d4d3bb4073-powerpc64le-linux-gnu-debug.tar.gz
17aab70af704c73443c2669e44cf9e9ae03a82ce5cc499b1e0fb92ec887b1ef664  guix-build-76d4d3bb4073/output/powerpc64le-linux-gnu/bitcoin-76d4d3bb4073-powerpc64le-linux-gnu.tar.gz
18b145ec41f4a93c776c86b315a1d72205fae90ad14b9011db5ed32c08a1f775c8  guix-build-76d4d3bb4073/output/riscv64-linux-gnu/SHA256SUMS.part
193fbeaed5ff8af6c99dfc0d8bdddb9e3e9d10cf9b3213a06ac07aa73ac437979d  guix-build-76d4d3bb4073/output/riscv64-linux-gnu/bitcoin-76d4d3bb4073-riscv64-linux-gnu-debug.tar.gz
20cb9e23c2dc5bc9d4b463cf93cb7d458252f7329ba84ca0149f48b9a227e35eb7  guix-build-76d4d3bb4073/output/riscv64-linux-gnu/bitcoin-76d4d3bb4073-riscv64-linux-gnu.tar.gz
21945ac368b3ba5199ce886b3d29756612a2178c994aac0f8fc1257d76e4a12178  guix-build-76d4d3bb4073/output/x86_64-apple-darwin/SHA256SUMS.part
22bd958cbae71999233e75e84ed5245e55058bb9477aa984081dc188c2aeb7baa3  guix-build-76d4d3bb4073/output/x86_64-apple-darwin/bitcoin-76d4d3bb4073-x86_64-apple-darwin-unsigned.dmg
2322823fe2571ba1ed96337d07929b239eec9dbca2c2bc57ee547477426f0ab573  guix-build-76d4d3bb4073/output/x86_64-apple-darwin/bitcoin-76d4d3bb4073-x86_64-apple-darwin-unsigned.tar.gz
2440950a2635f94ba12aab03a15044ff6adcac5dac62328c6f650e1b0a48d2bfd3  guix-build-76d4d3bb4073/output/x86_64-apple-darwin/bitcoin-76d4d3bb4073-x86_64-apple-darwin.tar.gz
256845e0499d8eb600e21e5676e833bd6fa3fdb1f40b6bdaf23d90ccd247cccd54  guix-build-76d4d3bb4073/output/x86_64-linux-gnu/SHA256SUMS.part
26dc874a0c577aaf1da46f6f71820352dcb7bb6aadceed68f8d1f77c00a2da72c5  guix-build-76d4d3bb4073/output/x86_64-linux-gnu/bitcoin-76d4d3bb4073-x86_64-linux-gnu-debug.tar.gz
272367af4b41e3c031ed8e14d741ce046d454f9973d99f829eed6811c47937d695  guix-build-76d4d3bb4073/output/x86_64-linux-gnu/bitcoin-76d4d3bb4073-x86_64-linux-gnu.tar.gz
28fc8e97f171049736b0e4a5e5a854dc9442de3ba4f640981b0eccb5f29734d034  guix-build-76d4d3bb4073/output/x86_64-w64-mingw32/SHA256SUMS.part
2928577d84cad6404cfc5224b68285496c7be975458156f14f7d971dc3cb6dabf4  guix-build-76d4d3bb4073/output/x86_64-w64-mingw32/bitcoin-76d4d3bb4073-win64-debug.zip
308f0bf22fec30f8eeeb702d451a06d478eddf45724126e9c9f3741587e31ca0cd  guix-build-76d4d3bb4073/output/x86_64-w64-mingw32/bitcoin-76d4d3bb4073-win64-setup-unsigned.exe
314c891a7a4a679a02a208b5e8f31f2ac319e8c109501165e5025e3c988cf3e5cd  guix-build-76d4d3bb4073/output/x86_64-w64-mingw32/bitcoin-76d4d3bb4073-win64-unsigned.tar.gz
32f511049e13c44282d4d744d0dba996eb051b67d79d624fea81b68e6a3c9fd820  guix-build-76d4d3bb4073/output/x86_64-w64-mingw32/bitcoin-76d4d3bb4073-win64.zip
  37. DrahtBot added the label Needs rebase on May 5, 2022
  38. hebasto force-pushed on Jul 21, 2022
  39. hebasto commented at 3:41 pm on July 21, 2022: member
    Rebased 76d4d3bb407325bb0350de45ece982e286a1087f -> ef802d0a714b0d6d149c950e323c56d82916d690 (pr23571.06 -> pr23571.07).
  40. hebasto requested review from fanquake on Jul 21, 2022
  41. hebasto requested review from dongcarl on Jul 21, 2022
  42. DrahtBot removed the label Needs rebase on Jul 21, 2022
  43. achow101 commented at 6:49 pm on October 12, 2022: member
    Are you still working on this?
  44. hebasto commented at 6:55 pm on October 12, 2022: member

    Are you still working on this?

    I am. This PR fixes a bug in our depends build system, and it’s ready for further reviewing.

  45. TheCharlatan approved
  46. TheCharlatan commented at 11:03 pm on January 29, 2023: contributor
    ACK ef802d0a714b0d6d149c950e323c56d82916d690
  47. fanquake commented at 5:02 pm on January 30, 2023: member
    Can probably be rebased for #23619. I’m not super convinced at adding all the _FOR_BUILD infra given there is currently little use for it outside of a single optional experimental package.
  48. build: Propagate user-defined tools to native packages 3e1442ce49
  49. build: Use `_FOR_BUILD` suffix for tools to build native packages 17c81db791
  50. build: Propagate TOOL_FOR_BUILD variables to the configure script ac1f4f0233
  51. hebasto force-pushed on Feb 6, 2023
  52. hebasto commented at 11:55 am on February 6, 2023: member

    @fanquake

    Can probably be rebased for #23619.

    Done.

    I’m not super convinced at adding all the _FOR_BUILD infra given there is currently little use for it outside of a single optional experimental package.

    Are you suggesting to drop last two commits or to close this PR altogether?

  53. fanquake commented at 4:22 pm on February 6, 2023: member

    Are you suggesting to drop last two commits

    I think it would be better if this was scoped to just the actual bug fix.

  54. hebasto commented at 11:43 am on February 17, 2023: member
    Closing. Up for grabs.
  55. hebasto closed this on Feb 17, 2023
  56. hebasto added the label Up for grabs on Feb 17, 2023
  57. bitcoin locked this on Feb 17, 2024


hebasto dongcarl shaavan DrahtBot laanwj achow101 TheCharlatan fanquake


fanquake dongcarl

Labels
Build system Up for grabs

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-04 22:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me