test: fix `wallet_transactiontime_rescan.py --descriptors` and add to test runner #23596

1. 
   theStack commented at 4:51 PM on November 25, 2021: member

   The functional test wallet_transactiontime_rescan.py currently fails on master branch, if descriptor wallets are used (argument --descriptors). This is due to the fact that in this case, the test framework maps the importaddress RPC calls to the importdescriptors RPC (rescan=False -> timestamp='now'), which always rescans blocks of the past 2 hours, based on the current MTP timestamp. In order to avoid importing the last address (wo3), we generate 10 more blocks with advanced time, to ensure that the balance after importing is zero: https://github.com/bitcoin/bitcoin/blob/681b25e3cd7d084f642693152322ed9a40f33ba0/test/functional/wallet_transactiontime_rescan.py#L125-L134

   Calling this test with descriptor wallets is also added to test runner. Fixes #23562.

2. test: refactor: use `set_node_times` helper in wallet_transactiontime_rescan.py a905ed1a61
3. test: fix test wallet_transactiontime_rescan.py for descriptor wallets b60e02e993
4. test: add wallet_transactiontime_rescan.py --descriptors to test_runner.py e4a54af6b8
5. DrahtBot added the label Tests on Nov 25, 2021
6. brunoerg approved
7. 
   brunoerg commented at 12:19 PM on November 26, 2021: member

   tACK e4a54af6b851b9f884500087c44f75815d40c559

8. MarcoFalke requested review from achow101 on Nov 26, 2021
9. MarcoFalke requested review from ryanofsky on Nov 26, 2021
10. 
    Sjors commented at 8:22 AM on November 28, 2021: member

    On macOS I was getting this failure consistency when compiling without BDB. Thanks for fixing.

    tACK e4a54af

    Though another could be to fix the wrapper in test_node.py to use a timestamp slightly in the future when rescan is false, or to use importdescriptors directly.

11. MarcoFalke merged this on Dec 6, 2021
12. MarcoFalke closed this on Dec 6, 2021

    ---

13. theStack deleted the branch on Dec 6, 2021
14. sidhujag referenced this in commit 24fd1ed0fe on Dec 7, 2021
15. RandyMcMillan referenced this in commit 9d13e87601 on Dec 23, 2021
16. DrahtBot locked this on Dec 6, 2022

Review Requested
achow101ryanofsky