test: fix `feature_rbf.py --descriptors` and add to test runner #23608

1. 
   theStack commented at 4:30 PM on November 26, 2021: member

   The functional test feature_rbf.py currently fails on master branch, if descriptor wallets are used (argument --descriptors). This is due to the fact that in this case, a call to the helper init_wallet

   https://github.com/bitcoin/bitcoin/blob/111c3e06b35b7867f2e0f740e988f648ac6c325d/test/functional/test_framework/test_framework.py#L428-L434

   creates a wallet without rescanning the blockchain; the test framework maps the importprivkey RPC calls to the importdescriptors RPC without rescanning by default (timestamp='now'). Fix this by always calling with rescan=True, which calls importdescriptors with timestamp=0. Also add feature_rbf.py --descriptors to the list of the test runner's calls.

   Fixes #23563.

2. test: always rescan after importing private keys in `init_wallet` helper

   This fixes the functional test feature_rbf.py for descriptor wallets.

   166f8ec28e
3. test: add feature_rbf.py --descriptors to test_runner.py b79dbe86a9
4. MarcoFalke requested review from ryanofsky on Nov 26, 2021
5. MarcoFalke requested review from achow101 on Nov 26, 2021
6. MarcoFalke approved
7. 
   MarcoFalke commented at 4:34 PM on November 26, 2021: member

   ACK, thanks.

8. DrahtBot added the label Tests on Nov 26, 2021
9. 
   mjdietzx commented at 10:44 PM on November 26, 2021: contributor

   ACK b79dbe86a9886b3539512f6c35205f4c5454a952

10. 
    DrahtBot commented at 5:02 AM on November 27, 2021: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #21085 (test: enable self.chain = 'main' to work in python bitcoin test framework by Saibato)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

11. fanquake merged this on Nov 28, 2021
12. fanquake closed this on Nov 28, 2021

    ---

13. theStack deleted the branch on Nov 28, 2021
14. sidhujag referenced this in commit 998dcb14f7 on Nov 29, 2021
15. RandyMcMillan referenced this in commit d082b4881f on Dec 23, 2021
16. DrahtBot locked this on Nov 28, 2022

Review Requested
achow101ryanofsky