refactor: Fix implicit-signed-integer-truncation in cuckoocache.h #23626

1. 
   MarcoFalke commented at 1:36 PM on November 29, 2021: member

   Using a file-wide suppression for this implicit truncation has several issues:

   • It is file-wide, thus suppressing any other (newly introduced) issues
   • The file doesn't compile with -Wimplicit-int-conversion

   Fix both issues by making the truncation explicit.

2. refactor: Fix implicit-signed-integer-truncation in cuckoocache.h fa7da227da
3. MarcoFalke added the label Refactoring on Nov 29, 2021
4. 
   MarcoFalke commented at 1:52 PM on November 29, 2021: member

   This should only change the binary with sanitizers enabled. I checked that my clang/gcc with -O2 produce no different binary.

5. fanquake requested review from JeremyRubin on Nov 30, 2021
6. 
   JeremyRubin commented at 9:02 AM on November 30, 2021: contributor

   utack

7. fanquake approved
8. 
   fanquake commented at 8:25 AM on December 2, 2021: member

   ACK fa7da227daf8558be14f226c4366583fdc59ba10

9. fanquake merged this on Dec 2, 2021
10. fanquake closed this on Dec 2, 2021

    ---

11. MarcoFalke deleted the branch on Dec 2, 2021
12. sidhujag referenced this in commit 563fbd3769 on Dec 2, 2021
13. RandyMcMillan referenced this in commit ec885af6fb on Dec 23, 2021
14. DrahtBot locked this on Dec 2, 2022

Review Requested
JeremyRubin