We require glibc 2.18+.
rpc: remove info about mallocinfo needing glibc 2.10+ #23643
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove_glibc_10_warning changing 2 files +2 −2-
fanquake commented at 11:22 AM on December 1, 2021: member
-
9a09d307e9
rpc: remove info about mallocinfo needing glibc 2.10+
We require glibc 2.18+.
- DrahtBot added the label RPC/REST/ZMQ on Dec 1, 2021
-
shaavan commented at 1:38 PM on December 1, 2021: contributor
@fanquake It would greatly help if you explained why you made the changes the way you created them. For example, you might have changed from:
"mallocinfo is only available when compiled with glibc 2.10+"to
"mallocinfo is only available when compiled with glibc 2.18+"So why did you prefer not to mention
glibcat all? -
jarolrod commented at 7:55 PM on December 1, 2021: member
ACK 9a09d307e9bd81ed218dd560d3eac7565f1f7a2f @shaavan I think you have a misconception with your comment. mallocinfo does not need glibc2.18. We require glibc2.18+ to build Bitcoin Core (since #23511).
The current comment is more information than is needed. If a user has built Bitcoin Core with < glibc2.10, then they most likely made that choice explicitly. They don't need to be reminded about what situations it would be available, nor is it our job.
-
fanquake commented at 1:35 AM on December 2, 2021: member
For example, you might have changed from: to
That wouldn't be correct.
malloc_infowas added to glibc in version 2.10.So why did you prefer not to mention glibc at all?
Warning that a certain feature is only available if you're using glibc 2.10+, is redundant if our binaries already require 2.18+.
- shaavan approved
-
shaavan commented at 7:24 AM on December 2, 2021: contributor
- MarcoFalke merged this on Dec 2, 2021
- MarcoFalke closed this on Dec 2, 2021
- fanquake deleted the branch on Dec 2, 2021
- sidhujag referenced this in commit 16ed1e51e4 on Dec 2, 2021
- RandyMcMillan referenced this in commit 707e9248dc on Dec 23, 2021
- PastaPastaPasta referenced this in commit d7424976b0 on Apr 7, 2022
- PastaPastaPasta referenced this in commit 01a6725650 on Apr 7, 2022
- PastaPastaPasta referenced this in commit d41fd8540e on Apr 7, 2022
- PastaPastaPasta referenced this in commit da28456688 on Apr 11, 2022
- DrahtBot locked this on Dec 2, 2022