test: fix: remove outdated TestNode.generate calls #23659

Currently failing on CI. After this change the test itself still fails, but at least it's apparently for a non-incidental reason.

This is due to a silent merge conflict from: https://github.com/bitcoin/bitcoin/pull/22929

Tested ACK 4e1cb904ba6777ea70edbbba42ebc803c9d1fbc9

Can confirm that this fixes the test wallet_listtransactions.py which currently fails on master. As a possible improvement, all the self.sync_all() after generating blocks can be removed, since that happens automatically per default by the test framework's generate function (if no explicit sync_fun is passed): https://github.com/bitcoin/bitcoin/blob/0b30bdd519ae06ec70e136a1b890421eb6f764cc/test/functional/test_framework/test_framework.py#L633-L636

The new failure looks like it may indicate some legitimate underlying issue. Given the (modified) code

        normalize_list(transactions0)
        normalize_list(transactions2)

        for t in transactions0:
            self.log.info("%s %s %s", t['address'], t['category'], t['amount'])
        self.log.info('total: %s', len(transactions0))

        self.log.info('')
        self.log.info('')

        for t in transactions2:
            self.log.info("%s %s %s", t['address'], t['category'], t['amount'])
        self.log.info('total: %s', len(transactions2))

        assert_equal(transactions0, transactions2)

2021-12-02T22:23:44.472000Z TestFramework (INFO): bcrt1q0ksqw5p9q4xd6v3we6m3svtux5xe29cmewupkp send -1.00000000
different   ------->  2021-12-02T22:23:44.472000Z TestFramework (INFO): mg3WrV5jmJS9xu14qJWVRBdNW7nxaVE2uN receive 0.00100000
different   ------->  2021-12-02T22:23:44.472000Z TestFramework (INFO): mg3WrV5jmJS9xu14qJWVRBdNW7nxaVE2uN send -0.00100000
2021-12-02T22:23:44.472000Z TestFramework (INFO): mjTkW3DjgyZck4KbiRusZsqTgaYTxdSz6z immature 25.00602820
2021-12-02T22:23:44.472000Z TestFramework (INFO): bcrt1q204qh9hu6lqgvr6ak3yveufry6fuaxfpkee0l0 receive 0.00100000
2021-12-02T22:23:44.472000Z TestFramework (INFO): 2NCwk8MJQWFnb1qjdiovCzQjUGgU5FpvCSi receive 0.00100000
2021-12-02T22:23:44.472000Z TestFramework (INFO): bcrt1quuwnsy9y8k608t9tvwr9kqp4gwswzek58kw6r0 send -0.99400000
2021-12-02T22:23:44.473000Z TestFramework (INFO): mjTkW3DjgyZck4KbiRusZsqTgaYTxdSz6z immature 25.00002880
2021-12-02T22:23:44.473000Z TestFramework (INFO): bcrt1quuwnsy9y8k608t9tvwr9kqp4gwswzek58kw6r0 send -0.99800000
2021-12-02T22:23:44.473000Z TestFramework (INFO): bcrt1qajxhhd4mvrhmskppj99cykjazfhlgzgrwkt9pm receive 0.99900000
2021-12-02T22:23:44.473000Z TestFramework (INFO): total: 10
2021-12-02T22:23:44.473000Z TestFramework (INFO):
2021-12-02T22:23:44.473000Z TestFramework (INFO):
2021-12-02T22:23:44.473000Z TestFramework (INFO): bcrt1q0ksqw5p9q4xd6v3we6m3svtux5xe29cmewupkp send -1.00000000
different   ------->  2021-12-02T22:23:44.473000Z TestFramework (INFO): bcrt1qw54aaklyd47cczp2dpl5h2mfcahf9xfdtatsvj receive 0.33000000
different   ------->  2021-12-02T22:23:44.473000Z TestFramework (INFO): bcrt1qstnfkq3k67lvcka7k8ps3aedrvkrpwqz4lxxht receive 0.11000000
2021-12-02T22:23:44.473000Z TestFramework (INFO): mjTkW3DjgyZck4KbiRusZsqTgaYTxdSz6z immature 25.00602820
2021-12-02T22:23:44.474000Z TestFramework (INFO): bcrt1q204qh9hu6lqgvr6ak3yveufry6fuaxfpkee0l0 receive 0.00100000
2021-12-02T22:23:44.474000Z TestFramework (INFO): 2NCwk8MJQWFnb1qjdiovCzQjUGgU5FpvCSi receive 0.00100000
2021-12-02T22:23:44.474000Z TestFramework (INFO): bcrt1quuwnsy9y8k608t9tvwr9kqp4gwswzek58kw6r0 send -0.99400000
2021-12-02T22:23:44.474000Z TestFramework (INFO): mjTkW3DjgyZck4KbiRusZsqTgaYTxdSz6z immature 25.00002880
2021-12-02T22:23:44.474000Z TestFramework (INFO): bcrt1quuwnsy9y8k608t9tvwr9kqp4gwswzek58kw6r0 send -0.99800000
2021-12-02T22:23:44.474000Z TestFramework (INFO): bcrt1qajxhhd4mvrhmskppj99cykjazfhlgzgrwkt9pm receive 0.99900000
2021-12-02T22:23:44.474000Z TestFramework (INFO): total: 10

@jamesob: What new failure do you get? On my side, the test wallet_listtrnsactions.py succeeds on the PR branch (CI also looks good so far).

ACK 4e1cb904ba6777ea70edbbba42ebc803c9d1fbc9

As a possible improvement, all the self.sync_all() after generating blocks can be removed, The new failure looks like it may indicate some legitimate underlying issue.

Merged this to fix the CI. However looks like we can have a couple follow ups.