ci: Make macOS native task sqlite only

MarcoFalke commented at 11:06 am on December 6, 2021: member

There are many sqlite-only test failures (#23563, #23562), so make one CI task sqlite-only.

Obviously this removes bdb coverage from macOS, but I don’t expect this to break very often.

ci: Make macOS native task sqlite only fad2e0a36a

fanquake added the label Tests on Dec 6, 2021

theStack commented at 11:56 am on December 6, 2021: member

Strong Concept ACK

MarcoFalke commented at 12:37 pm on December 6, 2021: member

#23684 :smiling_face_with_tear:

fanquake commented at 0:58 am on December 7, 2021: member

Concept ACK

Sjors commented at 5:21 am on December 7, 2021: member

On the one hand this seems alright, now that we’re gradually deprecating BDB. But at the same time, we haven’t finished the wallet upgrade tooling, which requires the presence of both.

MarcoFalke commented at 7:46 am on December 7, 2021: member

Given that there are plenty of devs on macOS and all the remaining CI tasks also test bdb, I don’t think this will cause any issues.

MarcoFalke referenced this in commit 877f3aa85c on Dec 7, 2021

MarcoFalke commented at 8:58 am on December 7, 2021: member

Blocked on #23686 (comment)

DrahtBot commented at 1:40 pm on December 7, 2021: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

MarcoFalke referenced this in commit f727d814bd on Dec 8, 2021

MarcoFalke commented at 5:59 pm on December 8, 2021: member

next failure:

 02021-12-08T17:56:13.138000Z TestFramework (ERROR): JSONRPC error
 1Traceback (most recent call last):
 2  File "/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin19/test/functional/test_framework/test_framework.py", line 132, in main
 3    self.run_test()
 4  File "/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin19/test/functional/feature_rbf.py", line 79, in run_test
 5    self.test_rpc()
 6  File "/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin19/test/functional/feature_rbf.py", line 542, in test_rpc
 7    self.init_wallet(node=0)
 8  File "/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin19/test/functional/test_framework/test_framework.py", line 433, in init_wallet
 9    n.createwallet(wallet_name=wallet_name, descriptors=self.options.descriptors, load_on_startup=True)
10  File "/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin19/test/functional/test_framework/test_node.py", line 704, in createwallet
11    return self.__getattr__('createwallet')(wallet_name, disable_private_keys, blank, passphrase, avoid_reuse, descriptors, load_on_startup, external_signer)
12  File "/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin19/test/functional/test_framework/coverage.py", line 49, in __call__
13    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
14  File "/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin19/test/functional/test_framework/authproxy.py", line 144, in __call__
15    raise JSONRPCException(response['error'], status)
16test_framework.authproxy.JSONRPCException: Compiled without bdb support (required for legacy wallets) (-4)

luke-jr commented at 2:28 am on December 9, 2021: member

Why not remove it from one of the Linux tasks instead?

MarcoFalke commented at 8:25 am on December 9, 2021: member

Why not remove it from one of the Linux tasks instead?

Why, and which one? They’d also loose coverage, since we run Linux with sanitizers enabled.

MarcoFalke referenced this in commit 529ed33362 on Dec 9, 2021

MarcoFalke commented at 12:56 pm on December 9, 2021: member

next failure:

 0 test  2021-12-09T10:13:33.507000Z TestFramework (ERROR): Assertion failed 
 1                                   Traceback (most recent call last):
 2                                     File "/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin/test/functional/test_framework/test_framework.py", line 132, in main
 3                                       self.run_test()
 4                                     File "/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin/test/functional/feature_coinstatsindex.py", line 51, in run_test
 5                                       self._test_coin_stats_index()
 6                                     File "/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin/test/functional/feature_coinstatsindex.py", line 176, in _test_coin_stats_index
 7                                       assert_equal(res6['block_info'], {
 8                                     File "/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin/test/functional/test_framework/util.py", line 50, in assert_equal
 9                                       raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
10                                   AssertionError: not(
11{'prevout_spent': Decimal('111.00000000'), 'coinbase': Decimal('50.01006620'), 'new_outputs_ex_coinbase': Decimal('89.99993380'), 'unspendable': Decimal('20.99000000'), 'unspendables': {'genesis_block': Decimal('0E-8'), 'bip30': Decimal('0E-8'), 'scripts': Decimal('20.99000000'), 'unclaimed_rewards': Decimal('0E-8')}} == 
12{'unspendable': Decimal('20.99000000'), 'prevout_spent': 111, 'new_outputs_ex_coinbase': Decimal('89.99993620'), 'coinbase': Decimal('50.01006380'), 'unspendables': {'genesis_block': 0, 'bip30': 0, 'scripts': Decimal('20.99000000'), 'unclaimed_rewards': 0}})

MarcoFalke referenced this in commit 2f26d8ec70 on Dec 9, 2021

MarcoFalke commented at 5:24 pm on December 9, 2021: member

CI is green now

fanquake approved

fanquake commented at 2:21 am on December 10, 2021: member

ACK fad2e0a36a56222ec6284a03f374e80527701d15 - clearly worthwhile having a sqlite only CI given the amount of bugs this has turned up in the past week or so. Tested running the functional tests with a --without-bdb build on macOS and Linux.

MarcoFalke merged this on Dec 10, 2021

MarcoFalke closed this on Dec 10, 2021

MarcoFalke deleted the branch on Dec 10, 2021

sidhujag referenced this in commit b216e0f8fb on Dec 10, 2021

RandyMcMillan referenced this in commit 51924900c5 on Dec 23, 2021

RandyMcMillan referenced this in commit 39c53817ee on Dec 23, 2021

RandyMcMillan referenced this in commit 453922b3d4 on Dec 23, 2021

DrahtBot locked this on Dec 10, 2022

ci: Make macOS native task sqlite only #23682

Conflicts