scripted-diff: Use named args in RPC docs #23703

1. 
   MarcoFalke commented at 10:56 am on December 8, 2021: member

   Incorrect named args are source of bugs, like #22979.

   To allow them being checked by clang-tidy, use a format it can understand.

2. scripted-diff: Use named args in RPC docs

   -BEGIN VERIFY SCRIPT-
    sed -i -e 's|, /\* optional \*/ true,|, /*optional=*/true,|g' $( git grep -l ', /\* optional \*/ true,' )
   -END VERIFY SCRIPT-

   fa9aaf8694
3. MarcoFalke added the label Refactoring on Dec 8, 2021
4. MarcoFalke added the label Docs on Dec 8, 2021
5. 
   MarcoFalke commented at 10:58 am on December 8, 2021: member

   PSA: Also, please do use /*optional=*/true where needed. It wasted a lot of my time creating a follow-up after literally every merged RPC change to add the missing optional.

   Alternatively, please review https://github.com/bitcoin/bitcoin/pull/23083

6. 
   DrahtBot commented at 11:08 am on December 8, 2021: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #23718 (PSBT: hash preimages fields by darosior)
   • #23508 (Add getdeploymentinfo RPC by ajtowns)
   • #23330 (WIP: [RPC] allow fetching headers by pages by JeremyRubin)
   • #22558 (psbt: Taproot fields for PSBT by achow101)
   • #22016 (rpc: add period_start to version bits statistics by Sjors)
   • #21283 (Implement BIP 370 PSBTv2 by achow101)
   • #19888 (rpc, test: Improve getblockstats for unspendables by fjahr)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. fanquake approved
8. 
   fanquake commented at 9:14 am on December 9, 2021: member

   ACK fa9aaf8694c63200ad01fd5659aba4f409b2c3b9 - checked clang-tidy and it’s fine here, (but throwing errors in other files. i.e wallet/test/wallet_tests.cpp).
9. fanquake merged this on Dec 9, 2021
10. fanquake closed this on Dec 9, 2021

    ---

11. MarcoFalke deleted the branch on Dec 9, 2021
12. sidhujag referenced this in commit 2f6d771799 on Dec 10, 2021
13. RandyMcMillan referenced this in commit 08bb24518b on Dec 23, 2021
14. DrahtBot locked this on Dec 9, 2022

Contributors
MarcoFalke DrahtBot fanquake

Labels
Refactoring Docs