build, qt: No need to set inapplicable QPA backend for Android

hebasto commented at 12:29 pm on December 12, 2021: member

The current workflow looks weird. At first, the inapplicable xcb QPA backend is set in Qt configure options. Then the correct android QPA backend is forced via the QT_QPA_PLATFORM environment variable.

Using the default QPA backend, which is android for Android devices, is just fine.

hebasto added the label Build system on Dec 12, 2021

hebasto added the label Android on Dec 12, 2021

hebasto commented at 12:30 pm on December 12, 2021: member

cc @icota

MarcoFalke added the label DrahtBot Guix build requested on Dec 12, 2021

luke-jr commented at 7:22 pm on December 12, 2021: member

We really shouldn’t have code assuming depends is being used…

But maybe we shouldn’t be forcing QPA anyway, so Concept ACK.

hebasto commented at 7:35 am on December 13, 2021: member

Guix builds:

 0$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 1e0abedce8bebd4012a584c2a3c0dfdcace2fe1ee5c1012d566f5e9b1e9ce991e  guix-build-480b2175fe65/output/aarch64-linux-gnu/SHA256SUMS.part
 28882c96f01f446e415fc820b3823c4ab4235be791dbc9f8b4290377eb0f09940  guix-build-480b2175fe65/output/aarch64-linux-gnu/bitcoin-480b2175fe65-aarch64-linux-gnu-debug.tar.gz
 394521e456b54498c89b2168822a6686aede6f928a329c76c8a8f9ca895e975fe  guix-build-480b2175fe65/output/aarch64-linux-gnu/bitcoin-480b2175fe65-aarch64-linux-gnu.tar.gz
 49c28bbc914c4b174bba34d08908775dba56310cfc18281cde21c0e563190f944  guix-build-480b2175fe65/output/arm-linux-gnueabihf/SHA256SUMS.part
 578d7bb0955e40b2d18c83ac04cac8657c6c7b270dd3d073f699773b87b6c7ff1  guix-build-480b2175fe65/output/arm-linux-gnueabihf/bitcoin-480b2175fe65-arm-linux-gnueabihf-debug.tar.gz
 6d042d607dae1b3a428eba221df3f06bd719722f307c573f25d326bcd61fd95cf  guix-build-480b2175fe65/output/arm-linux-gnueabihf/bitcoin-480b2175fe65-arm-linux-gnueabihf.tar.gz
 7d2e0d301436448f3018bd10bda268f437bb701c1d10d4c44c74483e71713a346  guix-build-480b2175fe65/output/dist-archive/bitcoin-480b2175fe65.tar.gz
 8c7d8bb5798bdc80d619f6fc12e6b9eba26adb2de1fdf35af481f7c3994d832bc  guix-build-480b2175fe65/output/powerpc64-linux-gnu/SHA256SUMS.part
 907ecb3b90ba5e338a5d1927eb24214d104804d285b2169e2daea51f7f26e1722  guix-build-480b2175fe65/output/powerpc64-linux-gnu/bitcoin-480b2175fe65-powerpc64-linux-gnu-debug.tar.gz
1062be8374f768a7e3beb9830471ce525adb6e9530fb66bbb8d91b0a8cc0745ae8  guix-build-480b2175fe65/output/powerpc64-linux-gnu/bitcoin-480b2175fe65-powerpc64-linux-gnu.tar.gz
1114d5b8ba004d710c512e0bff90dc3989690fe1ca166f876aa2afbe96b6435bf9  guix-build-480b2175fe65/output/powerpc64le-linux-gnu/SHA256SUMS.part
12f95acfdc25414b2e86a692fb49b8e1e53c3475d7c264712aededbcdff7572094  guix-build-480b2175fe65/output/powerpc64le-linux-gnu/bitcoin-480b2175fe65-powerpc64le-linux-gnu-debug.tar.gz
13969c120c1ed7da970b783b78ae26e368dee3ca2f8fe9103cd2bbcfaa35fc0e16  guix-build-480b2175fe65/output/powerpc64le-linux-gnu/bitcoin-480b2175fe65-powerpc64le-linux-gnu.tar.gz
14aa341b175f7bc574eb41291f3c91b1f560ca3464a3aad309f595ad4aaa7a0a57  guix-build-480b2175fe65/output/riscv64-linux-gnu/SHA256SUMS.part
1525b9c45df6b9a380ed9fae394377922cffd417e9d7b2d80d77db32827502022c  guix-build-480b2175fe65/output/riscv64-linux-gnu/bitcoin-480b2175fe65-riscv64-linux-gnu-debug.tar.gz
16aea4b740e81206c5590abd33c1469734ec49cba9b3e96ed03cc6774638342bd9  guix-build-480b2175fe65/output/riscv64-linux-gnu/bitcoin-480b2175fe65-riscv64-linux-gnu.tar.gz
17e5edc96bb3d745995be16e88ce1a253cd93f4c38268f5d1dac445009f4b79217  guix-build-480b2175fe65/output/x86_64-apple-darwin/SHA256SUMS.part
18281a941c4afed7452a4b4a5caf57cb2b3bdb3b3226f547d46084bf1f7a4bfd9a  guix-build-480b2175fe65/output/x86_64-apple-darwin/bitcoin-480b2175fe65-osx-unsigned.dmg
19ae9406e9648950939abc44d238749cd9d50007096a4844196ec1c80653ea584c  guix-build-480b2175fe65/output/x86_64-apple-darwin/bitcoin-480b2175fe65-osx-unsigned.tar.gz
2064934dd4f068b5007e0cdf0a4de2ab0605395ce99161b15dcb64d4e9794c9fc7  guix-build-480b2175fe65/output/x86_64-apple-darwin/bitcoin-480b2175fe65-osx64.tar.gz
21a572707b42ec749742d9d5dfd0433e638109ac47e2fcecba0bd692a0827d9e5c  guix-build-480b2175fe65/output/x86_64-linux-gnu/SHA256SUMS.part
225b0f55a7d27b861d5c85e97838fea8173ea212cd3fde2cf943d35329cea287ae  guix-build-480b2175fe65/output/x86_64-linux-gnu/bitcoin-480b2175fe65-x86_64-linux-gnu-debug.tar.gz
234f6a206f4c85895cd8bad584aefc6089f73d527361a9bb81615e429fa4069a62  guix-build-480b2175fe65/output/x86_64-linux-gnu/bitcoin-480b2175fe65-x86_64-linux-gnu.tar.gz
2428ceed984174e11fc6c5fd60dcab297dbb0ca93d6ffa98c86e88aed75b52d29b  guix-build-480b2175fe65/output/x86_64-w64-mingw32/SHA256SUMS.part
25e65226033c217d6510183fa34fc42016f0a6c586e428c1a7635be369d21897b1  guix-build-480b2175fe65/output/x86_64-w64-mingw32/bitcoin-480b2175fe65-win-unsigned.tar.gz
26a0b9b7622052f54019bb092748fefc6bbf6ac7930f54b23ad2ea233d5e8963df  guix-build-480b2175fe65/output/x86_64-w64-mingw32/bitcoin-480b2175fe65-win64-debug.zip
27d38056962bb4456a5cb63f06f48dbbbe071e6cb56f309e798bffb8dc4657129f  guix-build-480b2175fe65/output/x86_64-w64-mingw32/bitcoin-480b2175fe65-win64-setup-unsigned.exe
28ec9880d092153724ba8935cf9f84ea999b5dcc64726dee2d41ada680a88f0032  guix-build-480b2175fe65/output/x86_64-w64-mingw32/bitcoin-480b2175fe65-win64.zip

icota commented at 8:42 am on December 13, 2021: contributor

Concept ACK but this needs manual testing as QPA load tends to fail at runtime

hebasto commented at 8:48 am on December 13, 2021: member

@icota

Concept ACK but this needs manual testing as QPA load tends to fail at runtime

Also you could consider to combine this PR into https://github.com/bitcoin-core/gui/pull/504.

icota commented at 10:10 am on December 13, 2021: contributor

Also you could consider to combine this PR into bitcoin-core/gui#504.

I’d like to keep them separate because that one is to fix a regression and this is a nice-to-have improvement. Also I haven’t tested this at runtime.

DrahtBot commented at 11:55 am on January 2, 2022: member

Guix builds

File	commit 587cbca826d7331633a30b5a6cce170e3dbe2612(master)	commit 5dbb9188444094a5a7199cee6552746a4a7256f5(master and this pull)
SHA256SUMS.part	`54bf0fba61b0789f...`	`94e9cc926e58f679...`
*-aarch64-linux-gnu-debug.tar.gz	`99943d6bf15b523b...`	`bedb8191be3d34a0...`
*-aarch64-linux-gnu.tar.gz	`5af252a5fa34b686...`	`80c0bbece5b1c146...`
*-arm-linux-gnueabihf-debug.tar.gz	`9ed7eea7b54765e4...`	`7f1252a38811d858...`
*-arm-linux-gnueabihf.tar.gz	`42855682e42af5f8...`	`1f993a08af615634...`
*-osx-unsigned.dmg	`a62bbe4777e83f15...`	`8eb61245f4e2b4ae...`
*-osx-unsigned.tar.gz	`65fa556f437dcbde...`	`f02a9514bec154a3...`
*-osx64.tar.gz	`73a0ad1b30fdce75...`	`9e560cbfed0812a5...`
*-powerpc64-linux-gnu-debug.tar.gz	`d7c5c16039d0ffc3...`	`3ac7e561dcacc1eb...`
*-powerpc64-linux-gnu.tar.gz	`ffc000354f60afd5...`	`ca716b660c50cd2e...`
*-powerpc64le-linux-gnu-debug.tar.gz	`c273e299164508b2...`	`af077a8e26ea46e0...`
*-powerpc64le-linux-gnu.tar.gz	`c3a2cda7e9b4ef7c...`	`b081e01b9f9c17cf...`
*-riscv64-linux-gnu-debug.tar.gz	`7299d460303154ab...`	`0d908caeeba20620...`
*-riscv64-linux-gnu.tar.gz	`610783f6c2937a43...`	`495a6590e2cf3983...`
*-win-unsigned.tar.gz	`f485dff0967f6346...`	`2c5fc45882e7db3d...`
*-win64-debug.zip	`473f1631e5448937...`	`c2b819df89ecfee7...`
*-win64-setup-unsigned.exe	`20537ab5eecc1ce3...`	`054ccd5820d9ee92...`
*-win64.zip	`b9b5f15df3c6abd7...`	`c1bd7b3c3bff0517...`
*-x86_64-linux-gnu-debug.tar.gz	`b51a03099a61d75c...`	`1d172b7eb62bee6b...`
*-x86_64-linux-gnu.tar.gz	`42c2f600eff3d781...`	`83f3835a08daa6ca...`
*.tar.gz	`3dc92e1b19e7cbd9...`	`913b75c131da7896...`
guix_build.log	`d1b1af42e2c0bc4b...`	`c17bdf49a88d2bdf...`
guix_build.log.diff		`54718fb61a8c0cb4...`

DrahtBot removed the label DrahtBot Guix build requested on Jan 2, 2022

icota commented at 12:44 pm on January 3, 2022: contributor

tACK https://github.com/bitcoin/bitcoin/pull/23751/commits/480b2175fe65bfcc6706e7e1abe1455517108afb (but only after rebasing on top of master)

build, qt: No need to set inapplicable QPA backend for Android 29e1794ba5

hebasto force-pushed on Jan 3, 2022

hebasto commented at 12:47 pm on January 3, 2022: member

@icota

tACK 480b217 (but only after rebasing on top of master)

Rebased.

icota commented at 2:05 pm on January 3, 2022: contributor

re-tACK 29e1794ba5350914ea2be8cba33d8d6d2c99760b

fanquake approved

fanquake commented at 2:08 am on January 4, 2022: member

ACK 29e1794ba5350914ea2be8cba33d8d6d2c99760b - did not test anything Android related.

fanquake merged this on Jan 4, 2022

fanquake closed this on Jan 4, 2022

hebasto deleted the branch on Jan 4, 2022

sidhujag referenced this in commit efe815f7ca on Jan 4, 2022

DrahtBot locked this on Jan 4, 2023

build, qt: No need to set inapplicable QPA backend for Android #23751

Guix builds:

Guix builds